From: Quentin Schulz <quentin.schulz@cherry.de>
To: Cunhao Lu <1579567540@qq.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
kernel@pengutronix.de, Vincent Mailhol <mailhol@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Heiko Stuebner <heiko.stuebner@cherry.de>
Subject: Re: [PATCH v6 4/4] arm64: dts: rockchip: Enable CAN controller on RK3588-Tiger-Haikou
Date: Thu, 30 Jul 2026 17:21:35 +0200 [thread overview]
Message-ID: <d83d2d39-7c58-44e6-9454-6d8e38511bf5@cherry.de> (raw)
In-Reply-To: <tencent_A982C9885A401DE2AB5F405336CDA14C7C06@qq.com>
Hi Cunhao,
On 7/30/26 4:34 PM, Cunhao Lu wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
>
> CAN0 is piped through the Q7 connector to the CAN header on the Haikou
> baseboard, so enable support for it there.
>
> At least on RK3588 Tiger, the CAN clocks default to 99 MHz, limiting
> usable CAN bitrates without skew. The RK3568 errata documentation
> mentions 300 MHz as the default frequency, so request the same rate to
> allow more bitrates.
>
> The CAN clock setup is common to the Tiger SoM regardless of which
> carrier board exposes CAN0, so place it in rk3588-tiger.dtsi. Keep CAN0
> disabled by default and enable it in rk3588-tiger-haikou.dts, where the
> carrier board routes it to a transceiver.
>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
next prev parent reply other threads:[~2026-07-30 15:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260730-master-v6-0-dfb63e234775@qq.com>
2026-07-30 14:34 ` [PATCH v6 1/4] dt-bindings: can: rockchip: add rk3588 CAN-FD compatible Cunhao Lu
2026-09-02 11:11 ` (subset) " Heiko Stuebner
2026-07-30 14:34 ` [PATCH v6 2/4] can: rockchip: add RK3588 CAN support Cunhao Lu
2026-07-31 7:18 ` Marc Kleine-Budde
2026-07-31 9:23 ` Cunhao Lu
2026-07-31 10:35 ` Marc Kleine-Budde
2026-07-31 13:17 ` Cunhao Lu
2026-08-11 15:05 ` Cunhao Lu
2026-07-30 14:34 ` [PATCH v6 3/4] arm64: dts: rockchip: add CAN-FD nodes for RK3588 Cunhao Lu
2026-07-30 14:34 ` [PATCH v6 4/4] arm64: dts: rockchip: Enable CAN controller on RK3588-Tiger-Haikou Cunhao Lu
2026-07-30 15:21 ` Quentin Schulz [this message]
2026-07-30 14:34 [PATCH v6 0/4] can: rockchip: add RK3588 CAN support Cunhao Lu
2026-08-17 16:23 ` Marc Kleine-Budde
2026-08-17 16:25 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d83d2d39-7c58-44e6-9454-6d8e38511bf5@cherry.de \
--to=quentin.schulz@cherry.de \
--cc=1579567540@qq.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko.stuebner@cherry.de \
--cc=heiko@sntech.de \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®