From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757024AbdEUUP1 (ORCPT ); Sun, 21 May 2017 16:15:27 -0400 Received: from mout.web.de ([212.227.17.11]:57031 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752665AbdEUUP0 (ORCPT ); Sun, 21 May 2017 16:15:26 -0400 Subject: [PATCH 2/5] atm: Delete an error message for a failed memory allocation in make_entry() From: SF Markus Elfring To: netdev@vger.kernel.org, Augusto Mecking Caringi , "David S. Miller" , Jarod Wilson , Javier Martinez Canillas , Kees Cook Cc: LKML , kernel-janitors@vger.kernel.org References: <49543220-93e4-781c-877b-381277837152@users.sourceforge.net> Message-ID: Date: Sun, 21 May 2017 22:15:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <49543220-93e4-781c-877b-381277837152@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:SH+I9bLy5D9EPlh8qxYN4cSqb1OEr/NzLSJZtLzxjzJggTzExEm DgWPpuhSzT8pmexadgr18QmM7YekMBU1nyGtC/2gfs0RqRYZvLv34g8hiJJKKjHiaSBwKO5 jKJRxI5cStSHUSf3GCW6xCSSGcVL4YPgXhawOV53BKgfJi31bP4edV6QElPqW/Oor5DKTbe u/VidbXKEgDxOAAStgY/A== X-UI-Out-Filterresults: notjunk:1;V01:K0:LaMNDsxEnZY=:PXNrzQG3ufEtEGLVQslQd4 RZHnIRkl4MAIQxGpCaME++qHRA7AEpokHDi5oJjcSK5TinJE2/nmgvpyFuGRnkAacbnQa6Qd7 5ojwKCie1uKp3PL7xJH9zsEIo8qS3QPF5byBK1RJVVTpHkm92GsiEUE6skrZLznt5zZlMTVgX PRXixE+Ad2HMbP629E+Y1QWJkeJqOkqLMueC4FPoUv3eSGwn7V18KwD16/dyCsH70gtOXBbq7 gGZRht7uD0LTzhU5sD0H6rDd6Yq4FLELyrLyp0sFsWsa7k3x6LbS7R62HAz/3PN+URIGdozIy Ei+7yujDZkS/+r5ohpgyXMWZLWCVN+EHScJYyg/A/vZjMzVLIjO6wm8KhMMDXPfAbaeDrrg3D sz41L9OHWhzlT9z3YylcLywBOtwwBordWaVXQf7HGiyUpT9f1N+NFgZJIlzCpAizQsYtn7NHd vecFG7gaw7l+Y2eXHKVEzgM1WXKfFUSu/LW2xa5KxZJ7xdg8T1crP9rfP0+xaJzP+2Pq772Uf mynGFtXlQrbP5rF4zoUsnBhXJdX+UbJg0NCygrFVNipUzmYuv+TFaePgI7tMBaBFG6k4GH391 XUyQKLj1F5ERz+YdhmtAXbGWFx3QRWmT7ivObUA+IS5sKAXmO7GmjzN5+YXTtWH7aH5hhhPWS 3Zeas0+WKmvhvRyuBcNJvkzQ8zmI0C6L2DLSL821Fy5rvQHIhxEL1HET92gEkvNVnrZyVRLwV Wz1U0s5USG69O88eQa+IVtTI3LCjDcj2KuiNmvr9ymS1oNFNm8JR/HpM52WAPGU6ZVkh+OHkD Z1orbzr Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 21 May 2017 21:24:45 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- net/atm/lec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/atm/lec.c b/net/atm/lec.c index 6ad3ca625a44..a11dbd3a5119 100644 --- a/net/atm/lec.c +++ b/net/atm/lec.c @@ -1556,7 +1556,6 @@ static struct lec_arp_table *make_entry(struct lec_priv *priv, - if (!to_return) { - pr_info("LEC: Arp entry kmalloc failed\n"); + if (!to_return) return NULL; - } + ether_addr_copy(to_return->mac_addr, mac_addr); INIT_HLIST_NODE(&to_return->next); setup_timer(&to_return->timer, lec_arp_expire_arp, -- 2.13.0