From: bot+bpf-ci@kernel.org
To: find.dhiraj@gmail.com,bpf@vger.kernel.org
Cc: ast@kernel.org,alexei.starovoitov@gmail.com,daniel@iogearbox.net,andrii@kernel.org,martin.lau@linux.dev,eddyz87@gmail.com,memxor@gmail.com,song@kernel.org,yonghong.song@linux.dev,jolsa@kernel.org,corbet@lwn.net,skhan@linuxfoundation.org,emil@etsalapatis.com,linux-doc@vger.kernel.org,linux-kernel@vger.kernel.org,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,clm@meta.com,ihor.solodrai@linux.dev
Subject: Re: [PATCH bpf-next v2] bpf: Add kernel-doc for arena page kfuncs
Date: Mon, 25 May 2026 16:36:44 +0000 (UTC) [thread overview]
Message-ID: <d8cff7fda54cee7804535f32b9df53a6eee9d45b00acfac63296e8c4a110e1a0@mail.kernel.org> (raw)
In-Reply-To: <20260524114243.259916-1-find.dhiraj@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]
> bpf: Add kernel-doc for arena page kfuncs
>
> The page-management kfuncs exposed by BPF arena -
> bpf_arena_alloc_pages(), bpf_arena_free_pages() and
> bpf_arena_reserve_pages() - are part of the BPF kfunc ABI but lack
> rendered documentation. Their contracts (valid argument ranges,
> sleepable-only context, and the set of error returns) are today only
^^^^^^^^^^^^^^^^^^^^
> discoverable by reading kernel/bpf/arena.c.
Is the description "sleepable-only context" accurate here? The BPF
verifier supports calling bpf_arena_alloc_pages() and
bpf_arena_free_pages() in non-sleepable contexts by dynamically
replacing the calls with their non-sleepable variants.
Looking at the BTF_ID_FLAGS definitions, they do not include
KF_SLEEPABLE. While the code documentation was fixed in v2 to reflect
this, the commit message text was not updated.
This was flagged by both bot+bpf-ci@kernel.org and sashiko-bot@kernel.org
in their reviews of v2:
https://lore.kernel.org/bpf/a0b9a09127618cb4e3dd1aae92ef25aab9beb90bd533490ec5be7789420d9ef4@mail.kernel.org/
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/26409601656
next prev parent reply other threads:[~2026-05-25 16:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 4:35 [PATCH bpf-next] " Dhiraj Shah
2026-05-21 4:56 ` Emil Tsalapatis
2026-05-21 5:15 ` bot+bpf-ci
2026-05-21 5:28 ` Alexei Starovoitov
2026-05-24 11:42 ` [PATCH bpf-next v2] " Dhiraj Shah
2026-05-24 12:23 ` bot+bpf-ci
2026-05-25 16:36 ` bot+bpf-ci [this message]
2026-05-25 20:50 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8cff7fda54cee7804535f32b9df53a6eee9d45b00acfac63296e8c4a110e1a0@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clm@meta.com \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=find.dhiraj@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®