From: Joe Perches <joe@perches.com>
To: linux-kernel@vger.kernel.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@ozlabs.org
Subject: [PATCH 01/10] arch/powerpc: Fix continuation line formats
Date: Sun, 31 Jan 2010 12:02:03 -0800 [thread overview]
Message-ID: <d8e2cb6523906c5e77bb13ea9ffc077a9310dc9e.1264967498.git.joe@perches.com> (raw)
In-Reply-To: <cover.1264967493.git.joe@perches.com>
String constants that are continued on subsequent lines with \
are not good.
Signed-off-by: Joe Perches <joe@perches.com>
---
arch/powerpc/kernel/nvram_64.c | 6 +++---
arch/powerpc/platforms/pseries/hotplug-cpu.c | 8 ++++----
arch/powerpc/platforms/pseries/smp.c | 4 ++--
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c
index ad461e7..9cf197f 100644
--- a/arch/powerpc/kernel/nvram_64.c
+++ b/arch/powerpc/kernel/nvram_64.c
@@ -338,8 +338,8 @@ static int __init nvram_create_os_partition(void)
rc = nvram_write_header(new_part);
if (rc <= 0) {
- printk(KERN_ERR "nvram_create_os_partition: nvram_write_header \
- failed (%d)\n", rc);
+ printk(KERN_ERR "nvram_create_os_partition: nvram_write_header "
+ "failed (%d)\n", rc);
return rc;
}
@@ -349,7 +349,7 @@ static int __init nvram_create_os_partition(void)
rc = ppc_md.nvram_write((char *)&seq_init, sizeof(seq_init), &tmp_index);
if (rc <= 0) {
printk(KERN_ERR "nvram_create_os_partition: nvram_write "
- "failed (%d)\n", rc);
+ "failed (%d)\n", rc);
return rc;
}
diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c
index 6ea4698..a70de10 100644
--- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
+++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
@@ -397,12 +397,12 @@ static int parse_cede_parameters(void)
CEDE_LATENCY_PARAM_MAX_LENGTH);
if (call_status != 0)
- printk(KERN_INFO "CEDE_LATENCY: \
- %s %s Error calling get-system-parameter(0x%x)\n",
+ printk(KERN_INFO "CEDE_LATENCY: "
+ "%s %s Error calling get-system-parameter(0x%x)\n",
__FILE__, __func__, call_status);
else
- printk(KERN_INFO "CEDE_LATENCY: \
- get-system-parameter successful.\n");
+ printk(KERN_INFO "CEDE_LATENCY: "
+ "get-system-parameter successful.\n");
return call_status;
}
diff --git a/arch/powerpc/platforms/pseries/smp.c b/arch/powerpc/platforms/pseries/smp.c
index b488663..4e7f89a 100644
--- a/arch/powerpc/platforms/pseries/smp.c
+++ b/arch/powerpc/platforms/pseries/smp.c
@@ -144,8 +144,8 @@ static void __devinit smp_pSeries_kick_cpu(int nr)
hcpuid = get_hard_smp_processor_id(nr);
rc = plpar_hcall_norets(H_PROD, hcpuid);
if (rc != H_SUCCESS)
- printk(KERN_ERR "Error: Prod to wake up processor %d\
- Ret= %ld\n", nr, rc);
+ printk(KERN_ERR "Error: Prod to wake up processor %d "
+ "Ret= %ld\n", nr, rc);
}
}
--
1.6.6.rc0.57.gad7a
next prev parent reply other threads:[~2010-01-31 20:04 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 20:02 [PATCH 00/10] treewide: Fix format strings that misuse continuations Joe Perches
2010-01-31 20:02 ` Joe Perches [this message]
2010-02-01 2:16 ` [PATCH 01/10] arch/powerpc: Fix continuation line formats Benjamin Herrenschmidt
2010-02-01 18:30 ` Joe Perches
2010-02-08 3:46 ` Benjamin Herrenschmidt
2010-01-31 20:02 ` [PATCH 02/10] arch/blackfin: " Joe Perches
2010-01-31 20:02 ` [PATCH 03/10] drivers/ide: " Joe Perches
2010-02-04 2:44 ` David Miller
2010-01-31 20:02 ` [PATCH 04/10] drivers/serial/bfin_5xx.c: " Joe Perches
2010-01-31 20:02 ` [PATCH 05/10] drivers/scsi/arcmsr: " Joe Perches
2010-02-01 17:16 ` James Bottomley
2010-02-01 17:30 ` Joe Perches
2010-02-01 18:02 ` Frans Pop
2010-02-02 18:20 ` Stefan Richter
2010-01-31 20:02 ` [PATCH 06/10] drivers/staging: " Joe Perches
2010-01-31 21:22 ` Gábor Stefanik
2010-01-31 20:02 ` [PATCH 07/10] drivers/net/amd8111e.c: " Joe Perches
2010-02-04 2:44 ` David Miller
2010-01-31 20:02 ` [PATCH 08/10] fs/proc/array.c: " Joe Perches
2010-01-31 20:02 ` [PATCH 09/10] mm/slab.c: " Joe Perches
2010-01-31 20:08 ` Matt Mackall
2010-01-31 20:13 ` Joe Perches
2010-01-31 20:32 ` Frans Pop
2010-01-31 20:38 ` Joe Perches
2010-01-31 23:53 ` Frans Pop
2010-01-31 20:02 ` [PATCH 10/10] sound/soc/blackfin: " Joe Perches
2010-02-01 14:47 ` Mark Brown
2010-02-01 17:08 ` Joe Perches
2010-02-02 4:13 ` Mike Frysinger
2010-02-02 11:08 ` Mark Brown
2010-02-02 12:55 ` [RFC PATCH] checkpatch.pl: Add warning on non #define continuation lines Joe Perches
2010-02-02 13:49 ` John Kacur
2010-02-02 17:06 ` Mike Frysinger
2010-02-02 22:34 ` [RFC PATCH V2] " Joe Perches
2010-02-02 23:18 ` Daniel Walker
2010-02-03 15:15 ` Andy Whitcroft
[not found] ` <m2n.s.201002011906064544@fjphome.nl>
2010-02-01 19:07 ` [PATCH 05/10] drivers/scsi/arcmsr: Fix continuation line formats Frans Pop
2010-02-01 19:35 ` [RFC] Fix unnecessary spaces before newlines in logging messages Joe Perches
2010-02-01 20:10 ` Frans Pop
2010-02-01 20:34 ` [PATCH] Warn on unnecessary spaces before quoted newlines Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8e2cb6523906c5e77bb13ea9ffc077a9310dc9e.1264967498.git.joe@perches.com \
--to=joe@perches.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®