From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753539Ab2B0FuP (ORCPT ); Mon, 27 Feb 2012 00:50:15 -0500 Received: from eu1sys200aog112.obsmtp.com ([207.126.144.133]:55997 "EHLO eu1sys200aog112.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811Ab2B0FuN (ORCPT ); Mon, 27 Feb 2012 00:50:13 -0500 From: Viresh Kumar To: , , Cc: , , , , , , , , , , , , , , , Subject: [PATCH Resend] gpio/gpio-stmpe: Fix the value returned by _get_value routine Date: Mon, 27 Feb 2012 11:19:43 +0530 Message-ID: X-Mailer: git-send-email 1.7.8.110.g4cb5d In-Reply-To: <2f2b55523b707d514a15d822ff812cfae654510a.1330079584.git.viresh.kumar@st.com> References: <2f2b55523b707d514a15d822ff812cfae654510a.1330079584.git.viresh.kumar@st.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bhupesh Sharma The present _get_value routine returns the contents of the GPIO Monitor Pin Status Register(GPMR) starting from the bit whose value is requested to BIT 0 (irrelevant bits are replace by 0). For e.g. if we request the value of GPIO 6 in the earlier implementation the value returned is: BIT6 followed by 6 0's whereas it should just return BIT6. This patch addresses the same. Signed-off-by: Bhupesh Sharma Reviewed-by: Viresh Kumar --- Changes in Resend: Commit log fixed drivers/gpio/gpio-stmpe.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpio/gpio-stmpe.c b/drivers/gpio/gpio-stmpe.c index 094c5c4..dce3472 100644 --- a/drivers/gpio/gpio-stmpe.c +++ b/drivers/gpio/gpio-stmpe.c @@ -54,7 +54,7 @@ static int stmpe_gpio_get(struct gpio_chip *chip, unsigned offset) if (ret < 0) return ret; - return ret & mask; + return !!(ret & mask); } static void stmpe_gpio_set(struct gpio_chip *chip, unsigned offset, int val) -- 1.7.8.110.g4cb5d