From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751466AbdJSFKr (ORCPT <rfc822;w@1wt.eu>);
        Thu, 19 Oct 2017 01:10:47 -0400
Received: from mail.cn.fujitsu.com ([183.91.158.132]:54560 "EHLO
        heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S1750911AbdJSFKq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 19 Oct 2017 01:10:46 -0400
X-IronPort-AV: E=Sophos;i="5.43,368,1503331200"; 
   d="scan'208";a="29367653"
Subject: Re: [PATCH] perf test shell: trace+probe_libc_inet_pton.sh: force to
 use /bin/bash to load this script
To: <linux-kernel@vger.kernel.org>, <peterz@infradead.org>,
        <mingo@redhat.com>, <acme@kernel.org>,
        <alexander.shishkin@linux.intel.com>, <kim.phillips@arm.com>
CC: <philip.li@intel.com>
References: <1508385233-30676-1-git-send-email-lizhijian@cn.fujitsu.com>
From: Li Zhijian <lizhijian@cn.fujitsu.com>
Organization: fnst-ulinux
Message-ID: <dbe5e8b5-a823-e6ee-47fc-5dfb0b1ae6c5@cn.fujitsu.com>
Date: Thu, 19 Oct 2017 13:10:46 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <1508385233-30676-1-git-send-email-lizhijian@cn.fujitsu.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Originating-IP: [10.167.226.45]
X-yoursite-MailScanner-ID: 10CAE47F13D7.A2397
X-yoursite-MailScanner: Found to be clean
X-yoursite-MailScanner-From: lizhijian@cn.fujitsu.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

ignore this patch please, it will broken the test description which is read from the first line of this script

Thanks


On 10/19/2017 11:53 AM, Li Zhijian wrote:
> this script contains Array, but not all sh support Array. by default, dash provides sh at ubuntu/debian
> which can not support Array. so force to use /bin/bash
>
> it can fix following issue:
> lizhijian@localhost:~/lkp/linux/tools/perf/tests/shell$ sudo ./trace+probe_libc_inet_pton.sh
> [sudo] password for lizhijian: PING ::1(::1) 56 data bytes
> ./trace+probe_libc_inet_pton.sh: 30: ./trace+probe_libc_inet_pton.sh: Bad substitution
> ./trace+probe_libc_inet_pton.sh: 32: ./trace+probe_libc_inet_pton.sh: Bad substitution
>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---
>   tools/perf/tests/shell/trace+probe_libc_inet_pton.sh | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/tests/shell/trace+probe_libc_inet_pton.sh b/tools/perf/tests/shell/trace+probe_libc_inet_pton.sh
> index 7a84d73..df04cc1 100755
> --- a/tools/perf/tests/shell/trace+probe_libc_inet_pton.sh
> +++ b/tools/perf/tests/shell/trace+probe_libc_inet_pton.sh
> @@ -1,3 +1,5 @@
> +#!/bin/bash
> +
>   # probe libc's inet_pton & backtrace it with ping
>   
>   # Installs a probe on libc's inet_pton function, that will use uprobes,