From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Alim Akhtar <alim.akhtar@gmail.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <snawrocki@kernel.org>,
Sam Protsenko <semen.protsenko@linaro.org>,
Chanho Park <chanho61.park@samsung.com>
Subject: Re: [PATCH 08/24] ARM: dts: exynos: simplify PMIC DVS pin configuration in Peach Pi
Date: Fri, 7 Jan 2022 08:34:51 +0100 [thread overview]
Message-ID: <e13e70ff-1416-e0b8-93ae-991cf58a5f1d@canonical.com> (raw)
In-Reply-To: <CAGOxZ52PjcMD0hFQa95NHO2M5Z+Gpx4HNO14+KCsYnCffLc3JQ@mail.gmail.com>
On 06/01/2022 19:47, Alim Akhtar wrote:
> Hi Krzysztof,
>
> On Sat, Jan 1, 2022 at 1:15 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> The pin configuration for PMIC DVS (pmic-dvs-2 and pmic-dvs-3) are
>> exactly the same, so merge them.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> ---
>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 20 +++++++-------------
>> 1 file changed, 7 insertions(+), 13 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> index 6bf3fd37fb2b..eca805b83816 100644
>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> @@ -221,7 +221,7 @@ max77802: pmic@9 {
>> interrupts = <1 IRQ_TYPE_NONE>;
>> pinctrl-names = "default";
>> pinctrl-0 = <&max77802_irq>, <&pmic_selb>,
>> - <&pmic_dvs_1>, <&pmic_dvs_2>, <&pmic_dvs_3>;
>> + <&pmic_dvs_1>, <&pmic_dvs_2>;
>> wakeup-source;
>> reg = <0x9>;
>> #clock-cells = <1>;
>> @@ -874,26 +874,20 @@ &sd1_cmd {
>>
>> &pinctrl_2 {
>> pmic_dvs_2: pmic-dvs-2 {
>> - samsung,pins = "gpj4-2";
>> + samsung,pins = "gpj4-2", "gpj4-3";
>> samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
>> samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
>> samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>;
>> };
>> +};
>>
>> - pmic_dvs_3: pmic-dvs-3 {
>> - samsung,pins = "gpj4-3";
>> - samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
>> - samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
>> - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>;
>> - };
>> +/* pinctrl_3*/
>> +/* Drive SPI lines at x2 for better integrity */
>> +&spi2_bus {
>> + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
>> };
>>
> Maybe move this spi2_bus part to patch #07 as the commit does not
> mention this change.
>
Right, it should be part of #7.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-01-07 7:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-31 16:19 [PATCH 00/24] pinctrl: dt-bindings: samsung: convert to dtschema Krzysztof Kozlowski
2021-12-31 16:19 ` [PATCH 01/24] pinctrl: samsung: drop pin banks references on error paths Krzysztof Kozlowski
2022-01-03 14:49 ` Sam Protsenko
2022-01-05 20:24 ` Krzysztof Kozlowski
2021-12-31 16:19 ` [PATCH 02/24] pinctrl: samsung: accept GPIO bank nodes with a suffix Krzysztof Kozlowski
2022-01-03 18:43 ` Sam Protsenko
2022-01-05 20:31 ` Krzysztof Kozlowski
2021-12-31 16:19 ` [PATCH 03/24] ARM: dts: exynos: drop unused pinctrl defines in Exynos3250 Krzysztof Kozlowski
2022-01-06 18:20 ` Alim Akhtar
2021-12-31 16:19 ` [PATCH 04/24] ARM: dts: exynos: simplify PMIC DVS pin configuration in Odroid XU Krzysztof Kozlowski
2021-12-31 16:19 ` [PATCH 05/24] ARM: dts: exynos: override pins by label in Peach Pit Krzysztof Kozlowski
2022-01-06 18:42 ` Alim Akhtar
2021-12-31 16:19 ` [PATCH 06/24] ARM: dts: exynos: simplify PMIC DVS pin configuration " Krzysztof Kozlowski
2021-12-31 16:21 ` [PATCH 07/24] ARM: dts: exynos: override pins by label in Peach Pi Krzysztof Kozlowski
2022-01-06 18:44 ` Alim Akhtar
2021-12-31 16:21 ` [PATCH 08/24] ARM: dts: exynos: simplify PMIC DVS pin configuration " Krzysztof Kozlowski
2022-01-06 18:47 ` Alim Akhtar
2022-01-07 7:34 ` Krzysztof Kozlowski [this message]
2021-12-31 16:21 ` [PATCH 09/24] ARM: dts: s3c64xx: drop unneeded pinctrl wake-up interrupt mapping Krzysztof Kozlowski
2021-12-31 16:21 ` [PATCH 10/24] ARM: dts: exynos: align pinctrl with dtschema in Exynos3250 Krzysztof Kozlowski
2021-12-31 16:21 ` [PATCH 11/24] ARM: dts: exynos: align pinctrl with dtschema in Exynos4210 Krzysztof Kozlowski
2021-12-31 16:21 ` [PATCH 12/24] ARM: dts: exynos: align pinctrl with dtschema in Exynos4412 Krzysztof Kozlowski
2021-12-31 16:21 ` [PATCH 13/24] ARM: dts: exynos: align pinctrl with dtschema in Exynos5250 Krzysztof Kozlowski
2021-12-31 16:21 ` [PATCH 14/24] ARM: dts: exynos: align pinctrl with dtschema in Exynos5260 Krzysztof Kozlowski
2021-12-31 16:21 ` [PATCH 15/24] ARM: dts: exynos: align pinctrl with dtschema in Exynos5410 Krzysztof Kozlowski
2021-12-31 16:21 ` [PATCH 16/24] ARM: dts: exynos: align pinctrl with dtschema in Exynos542x/5800 Krzysztof Kozlowski
2021-12-31 16:22 ` [PATCH 17/24] arm64: dts: exynos: align pinctrl with dtschema in Exynos5433 Krzysztof Kozlowski
2021-12-31 16:23 ` [PATCH 18/24] arm64: dts: exynos: align pinctrl with dtschema in Exynos7 Krzysztof Kozlowski
2021-12-31 16:23 ` [PATCH 19/24] arm64: dts: exynos: align pinctrl with dtschema in Exynos850 Krzysztof Kozlowski
2022-01-03 14:45 ` Sam Protsenko
2021-12-31 16:23 ` [PATCH 20/24] arm64: dts: exynos: align pinctrl with dtschema in ExynosAutov9 Krzysztof Kozlowski
2021-12-31 16:23 ` [PATCH 21/24] ARM: dts: s3c24xx: align pinctrl with dtschema Krzysztof Kozlowski
2021-12-31 16:23 ` [PATCH 22/24] ARM: dts: s3c64xx: " Krzysztof Kozlowski
2021-12-31 16:23 ` [PATCH 23/24] ARM: dts: s5pv210: " Krzysztof Kozlowski
2021-12-31 16:23 ` [PATCH 24/24] dt-bindings: pinctrl: samsung: convert to dtschema Krzysztof Kozlowski
2022-01-03 21:19 ` Sam Protsenko
2022-01-10 20:43 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e13e70ff-1416-e0b8-93ae-991cf58a5f1d@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=alim.akhtar@gmail.com \
--cc=chanho61.park@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=semen.protsenko@linaro.org \
--cc=snawrocki@kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®