From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-50.mta1.migadu.com [95.215.58.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3858C54DAC4 for ; Tue, 22 Sep 2026 13:18:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790083087; cv=none; b=VJpNrpN4x1ntV5pW/YirUdrCZGByP60SaVVV4qozO2hw4yDdRVu0HwUMmraY7aoxrL3OaOpDWUYMatqq6XhtCaT+GhE/QzdHwrQDkx8a8BBzfdUHcpdM3aaj49cDyO97TxK3A49HyblECZKUWAcZUh713K2RO8OPG5RCMBHbsXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790083087; c=relaxed/simple; bh=4pfzmO/hwWCixkUYL+9BkgmWlmDGjMCDcNSgG5Tt31w=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=UyFDuFifgJPG0gl/CuJcNCQ3WryvTfJ3eYMWtPbekfkxvUWFOIoXHBquKKb/YF9r1z0aeo/8nn25jI+hpl4mQx2mPe2o1mf6OPonD+v8MMQv75sp4qj/yk2/KclAvsXVU+Y8H7u/sazulyzpFefssdE6OUcOumVD8E/2sJpWR2o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=m4Arnc8P; arc=none smtp.client-ip=95.215.58.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="m4Arnc8P" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=4pfzmO/hwWCixkUYL+9BkgmWlmDGjMCDcNSgG5Tt31w=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1790083084; v=1; x=1790687884; b=m4Arnc8PwqHlrALftJeTVQIJ4mnLRxWzOUNCGtvZnIfIVhzrFnncaCNiGWXJeKSLIEEQBvzO h5Mg0FrdMlBRlHe2RROkCp/zC3wDvSWSnIpYxPZkFYE7GOM6wQ4nb3GxnyJxZva25IZJaGavM/z f+qnxZ36eGgoiJkIBYnrz4b4= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 702c86f6eda1fa1b; Tue, 22 Sep 2026 13:18:00 +0000 X-Mizu-Trace-ID: 702c86f6eda1fa1b X-Migadu-Flow: FLOW_OUT Message-ID: Date: Tue, 22 Sep 2026 21:17:53 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: cui.tao@linux.dev, josef@toxicopanda.com, axboe@kernel.dk, ameryhung@gmail.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, andrii@kernel.org, eddyz87@gmail.com, ast@kernel.org, daniel@iogearbox.net, linux-kselftest@vger.kernel.org, Tao Cui Subject: Re: [RFC PATCH v6 1/5] blk-iocost: add BPF struct_ops cost model support To: Tejun Heo References: <20260918055001.1273840-1-cui.tao@linux.dev> <20260918055001.1273840-2-cui.tao@linux.dev> From: Tao Cui In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hello, Tejun. 在 2026/9/22 03:37, Tejun Heo 写道: > Hello, Tao. > > On Fri, 18 Sep 2026 13:49:57 +0800, Tao Cui wrote: > >> + mutex_lock(&iocost_bpf_reg_lock); >> + { >> + struct iocost_bpf_model *other; >> + >> + list_for_each_entry(other, &iocost_bpf_models, list) { > > No need for a block to scope a variable. Declare it at the top of the > function, or in the body if it has to sit inside an #ifdef block. Same for > the other blocks in this patch and the cursor block in the 2x example > model. > Thanks, fixed. The scopes used only to declare local variables are removed and the declarations moved up, including the cursor block in the 2x example model. Thanks, Tao > Thanks. > > -- > tejun