mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Indan Zupancic" <indan@nul.nu>
To: "Oleg Nesterov" <oleg@redhat.com>
Cc: "Denys Vlasenko" <vda.linux@googlemail.com>,
	"Tejun Heo" <tj@kernel.org>,
	"Denys Vlasenko" <dvlasenk@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: Why I want PTRACE_O_TRACESTOP option
Date: Sat, 10 Sep 2011 01:09:58 +0200	[thread overview]
Message-ID: <e7392891fba13321668f533c6a0d637b.squirrel@webmail.greenhost.nl> (raw)
In-Reply-To: <20110909162606.GC23271@redhat.com>

On Fri, September 9, 2011 18:26, Oleg Nesterov wrote:
> On 09/09, Indan Zupancic wrote:
>>
>> It is very useful to set options atomically at SEIZE time.
>
> Nobody argues with this.
>
>> Another important reason to make PTRACE_O_TRACESTOP an option is
>> because not everyone uses SEIZE: Users using PTRACE_TRACEME can't
>> set this option at all.
>
> Yes. This was already discussed, PTRACE_TRACEME obviously doesn't
> work if you need the new features. So far it was decided TRACEME
> should be avoided,

How do you want to attach/seize a just forked child without races
in a less ugly way than with TRACEME?

> but perhaps we can add SEIZE_ME. And, unlike
> TRACEME it should probably stop immediately to simplify the
> synchronization with parent. Afaik, any user of TRACEME does
> something like kill(getpid(), SIGSTOP), this doesn't look very
> good.

I let the child send a SIGTERM to itself, so if anything goes wrong
it terminates. It's only needed because you have to set options.

>
> But personally I'd prefer to avoid SEIZE_ME.

Me too. There is no need for it if PTRACE_O_TRACESTOP exists.

Alternatively, if you do want to add it, just allow PTRACE_SEIZE
with zero/own PID to achieve the same.

Greetings,

Indan



  reply	other threads:[~2011-09-09 23:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-08 16:50 Denys Vlasenko
2011-09-09  0:18 ` Tejun Heo
2011-09-09  5:45   ` Denys Vlasenko
2011-09-09 16:00     ` Oleg Nesterov
2011-09-10 23:43       ` Tejun Heo
2011-09-09  5:54   ` Denys Vlasenko
2011-09-09 12:26     ` Indan Zupancic
2011-09-09 13:01       ` Indan Zupancic
2011-09-09 16:46         ` Denys Vlasenko
2011-09-09 16:26       ` Oleg Nesterov
2011-09-09 23:09         ` Indan Zupancic [this message]
2011-09-10  1:17           ` Denys Vlasenko
2011-09-10 11:20             ` Pedro Alves
2011-09-11  0:58     ` Tejun Heo
2011-09-09 16:14   ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7392891fba13321668f533c6a0d637b.squirrel@webmail.greenhost.nl \
    --to=indan@nul.nu \
    --cc=dvlasenk@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=tj@kernel.org \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®