From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB3EE43CE5E for ; Mon, 17 Aug 2026 14:28:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786976924; cv=none; b=hfN7aevgGh/6KPoXDTkj0j+PXDBMsxUMCm237aINBg7OIKjqCle6wJ34styw1A6NJt4s0dkq4BaPnnfG8kr5/Eyf57cn0K8tFdKv20I9WGne5jJeMyC25p2o1q9R27J0QqOGBd79i+x7dmknJmcU/oNrxmJB9/yiuxxmfPEDr2M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786976924; c=relaxed/simple; bh=lW29cJnTuKEyNNpLjqCpqrDs2QH+wKuNOpzoasGDgYE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ivH2c0glR+GelBm+eE8HccXSH3LWtit6QQpEmhqP7hheSsoAsX2uEyDv/sn2jNchpeSpjpx5qlnA3jILibVdHvfUwijGjGmn+/ZyTzsHq+95/HKlHkyvd1S+xnHIt/xpODlFaRBuxn7lBC3uS4qkY66HleinVseQ89wj1rl4oLI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I1LCh2c7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Eo3z4yOQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I1LCh2c7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Eo3z4yOQ" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67HD5qHt1929245 for ; Mon, 17 Aug 2026 14:28:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MmAHkTLsRn7KVxOAfmPWk8I34Jvce7irwqDr0u/5/Pw=; b=I1LCh2c7l9eIoSPx J2ghJFyP70Rhkpo3zVz5kmOgpQ9LJekCcOf7rCnOt3GEmH0eEGwVrMGJI22SVgeX bnWRWYU0qBS3h7UV36Kou5lrbiiSxLyCNtqbVNJQsZ3LyQGsUdkUGvFYHNezbYhc bO7Ji7Vte/49Ee0rjk1Oe5vUbdCbr11oUPG8zdOUR5YpAjupNRZz/CCuxjp91Ao5 edwme3QGU5iVcKHHdg+S1Bc6UNNp/L4wBk/P8jUVX4ti45k2FxFbL3nUFrisN2UN LzKlg5DZBObT92Yh83OcJb9PynO/AEw/BEVJmWhcBW/mA2nFlwWMMRJrzsNwEOGh dVR3ag== Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g3xx7habd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Aug 2026 14:28:41 +0000 (GMT) Received: by mail-vk1-f198.google.com with SMTP id 71dfb90a1353d-5bf8356e54aso51468e0c.3 for ; Mon, 17 Aug 2026 07:28:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786976917; x=1787581717; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MmAHkTLsRn7KVxOAfmPWk8I34Jvce7irwqDr0u/5/Pw=; b=Eo3z4yOQ9V3rsW/ARewkWVr24rIVHRUnaEUSMnlbSAomyI7OtqEw90GIuQBiR/K4F9 /Jeui2Lm9qgG/Io7E+/AZRoRGOk+6VX5n5t0ulucc9KgFKAmuknXw3y0WJLv2a6Clew6 SCIjk0XDRmVP2f2jW97QNnLd2t90VSTpjklKLrpT7r2yMF8EoltxOWVX1PslC04AMTzv yahx8XhpTWClI0z8iuOrWbAgOYYsU9zht2/BnLBGwCpCANSI+8FlijUMqJyyaoF/snO2 K10efGjnLgq7dV92rHVswPRw+J0iMZTG+grCYm5O3k/t4X2S0MCvDwZgQy6MYYQMFOy1 MQGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786976917; x=1787581717; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MmAHkTLsRn7KVxOAfmPWk8I34Jvce7irwqDr0u/5/Pw=; b=B5QiR0Ehmc1if1Ck7lPLtAaSwALQqatcqUPcDzsNK6mA4szggw6UheRqDRCj1h2eeK MVF202/VBSN0lpGHUzzV0R2XpeZBbjCXc1849TSYEvz13il1PrJnEp6bquKqsHy+nOgx SI/IBhf0sMrAAXZJ9gYYSjG/ee+cE9MrIDpO1VgXbm+f8hYXAWgItmZkr31G7K5E3pVz OGQWz/wsC1QZv4CEGg1jxw8mudoE66t7lWJyLSDJdmJmFp8K++pfR1Wug5Y4TL3utJyV lLM7yY2D7RhM9RFzMfq16YDKIaFTlKQNma9jvQx5rRmEt7+d6SnlWBXc88cUKHq40ujW 3glA== X-Forwarded-Encrypted: i=1; AHgh+RrQ7H/3deBcq4J+N5/wfqGf+TOwQaNs6dIU435BWq8HLKqkuzxjwbc1QICn5KFvqW1H8oMRqnuW0GuaUYQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0Jd4pIM1HNoMYxoeoTkNpAznyvw01fCfKT11ZTeV9+x9BsoYm QGoYgtJxxmNJJXWAm3Iw2GDyxW2OP2hVWjqyQ8L6q5TGlRzQD9mM0ruvYnkEImuZI/rtJydoUcP v3KNXC//PSIzxZAzSFZunG6fTR8Sw9/KNgdJfoqq+WNDS7AyWBs22na644txrMuiYgKLiPBhBPg s= X-Gm-Gg: AR+sD128qslujxDGDjUU41+Mw3LjUOcqHqluc7V7+QoS45NHyXHu7m2D5IoSeGat2kY MeSiv29QO5XxMXUHhCRyUUfjvNdnlNRPqg9VzgZFA6x+Y8hAjpb7vrxARd3JD9w616ZR1wB/uHY HAkQJB4YMaynIYxMcXByyiGs1VjPezHMNumPOB3Y3mYPT81hz69wuKHLWF0Kl1Jb9SVGCb9b1xe z7nrS6tL56F/t44BFl4mndECPkKNWitYrW/UqAs4j6EZ7SXcv22oOxQfFtnDJLKrEgq9tbmsWc7 LrcwoT55zSzfKGixDYBvMFhPZdMLe0a7hCKRr5XUx2JOczU5rz9ayFjjo0K0UlEfwrFs1CLD2YH WRXFQ7kuuWDgFSJpTWNS2xelt X-Received: by 2002:a05:6102:5091:b0:74d:ce65:3e8b with SMTP id ada2fe7eead31-76f2c643703mr1636834137.2.1786976916974; Mon, 17 Aug 2026 07:28:36 -0700 (PDT) X-Received: by 2002:a05:6102:5091:b0:74d:ce65:3e8b with SMTP id ada2fe7eead31-76f2c643703mr1636826137.2.1786976916457; Mon, 17 Aug 2026 07:28:36 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2185b732a4sm36959166b.30.2026.08.17.07.28.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2026 07:28:35 -0700 (PDT) Message-ID: Date: Mon, 17 Aug 2026 16:28:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] soc: qcom: rpmh-rsc: Output debug information from RSC To: Maulik Shah , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, "Raju P.L.S.S.S.N" References: <20260812-rpmh-timeout-debug-v1-v3-0-68c0a40dce23@oss.qualcomm.com> <20260812-rpmh-timeout-debug-v1-v3-3-68c0a40dce23@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260812-rpmh-timeout-debug-v1-v3-3-68c0a40dce23@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODE3MDExMSBTYWx0ZWRfX6G1EDIal9+Oa LnCAApZfL80QxMTD1wmLaZ7ZHdwQ+tOejbDQCyUs/5JOS3EymVF75TtxPAwN6tXqBhML0UNaGHq VqqwtLuCBroRsjre58LRurJLKvKDCc0= X-Authority-Analysis: v=2.4 cv=TK91jVla c=1 sm=1 tr=0 ts=6a831a99 cx=c_pps a=1Os3MKEOqt8YzSjcPV0cFA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=LpQP-O61AAAA:8 a=IDCv8sMOEfYmDO7wiisA:9 a=QEXdDO2ut3YA:10 a=hhpmQAJR8DioWGSBphRh:22 a=pioyyrs4ZptJ924tMmac:22 X-Proofpoint-GUID: x0pTs0khf6cxs6SbKcb_IQnUJF_mGz8Y X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE3MDExMSBTYWx0ZWRfXxacUI60OlK0d 62RVN+n1iJhiaFp6tp3mMgeSYC1Bt77FhFtywMr7J1oAO7EEAOInirBWiIW0CiM/Jdzg32DoUqB o13iNKTtJEHmreWo+wk7l4wmz34rkNo8ebqqgfIMn8H4y+sslo0jfIJc8Cb3hHvhr8G78CE8jp1 hAJ01wC279vz2BDaJbX6LbQLnCrpVwVE+PutB6vbXkqlkQC3skJ6OqHRHwhzRSJX1emmUuB///8 tkp1IqYf2BgTGaF/F6bPTU34bXSfga4+VxPkjXoFkrE0g2Jz5BpmiKnmxpFER7FZuLUJbT3TzX1 rvLqL7O5CJtGi9f40nDwX24Qvs3UELndGY+qSCt911DutLgHeLAbzLO3UPRuafWtK6UA1YxBFVx DJsLvq/mEpzr2UMUVwoPlX7ejgyidrM4ydtNDFngHq5/yOTq2Mi2ARyw6rnmZgQoqo1YpL1Juyg +Pb1SeJzKt4F2wsSdCw== X-Proofpoint-ORIG-GUID: x0pTs0khf6cxs6SbKcb_IQnUJF_mGz8Y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-17_01,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 impostorscore=0 adultscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608170111 On 8/12/26 8:12 AM, Maulik Shah wrote: > From: "Raju P.L.S.S.S.N" > > When an RPMh transfer times out there is no visibility into which > TCS was stuck, what commands it was carrying, or whether the > completion IRQ was pending at the GIC. Add rpmh_rsc_debug() to > capture this state at timeout: [...] Looking good overall, some minor comments > +static void print_tcs_info(struct rsc_drv *drv, int tcs_id, > + bool *aoss_irq_sts) > +{ > + const struct tcs_request *req = get_req_from_tcs(drv, tcs_id); > + unsigned long cmds_enabled; > + char rname[CMD_DB_ID_SIZE + 1]; > + u32 addr, data, msgid, sts, irq_sts; > + bool in_use = test_bit(tcs_id, drv->tcs_in_use); > + int i; > + > + sts = read_tcs_reg(drv, drv->regs[RSC_DRV_STATUS], tcs_id); > + cmds_enabled = read_tcs_reg(drv, drv->regs[RSC_DRV_CMD_ENABLE], tcs_id); > + if (!cmds_enabled) > + return; > + > + if (!req) > + goto print_tcs_data; > + > + data = read_tcs_reg(drv, drv->regs[RSC_DRV_CONTROL], tcs_id); > + irq_sts = readl_relaxed(drv->tcs_base + drv->regs[RSC_DRV_IRQ_STATUS]); > + pr_warn("Request: tcs-in-use:%s state=%d wait_for_compl=%u\n", Let's use dev_foo() everywhere instead of pr_foo, you have a struct dev* in drv->dev > + in_use ? "YES" : "NO", Please use str_yes_no() here, or AI contributors will rush to "fix" it.. [...] > +/** > + * rpmh_rsc_debug() - Dump debug information on a transfer timeout. > + * @drv: The RSC controller. > + * @compl: The completion object that timed out. > + * > + * Dumps TCS state for all in-use TCSes and reports which accelerators > + * did not respond, to aid in diagnosing RPMH timeout failures. > + */ > +void rpmh_rsc_debug(struct rsc_drv *drv, struct completion *compl) > +{ > + struct irq_data *rsc_irq_data = irq_get_irq_data(drv->irq); > + bool gic_irq_sts, aoss_irq_sts = false; > + int i, busy = 0; > + > + pr_err("RSC:%s\n", drv->name); Let's perhaps touch this up to sth like "Timeout on RSC %s\n" Konrad