From: John Youn <johnyoun@synopsys.com>
To: John Youn <johnyoun@synopsys.com>
To: Felipe Balbi <balbi@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-usb@vger.kernel.org
To: linux-kernel@vger.kernel.org
Cc: linux-rpi-kernel@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: Remi Pommarel <repk@triplefau.lt>
Cc: Caesar Wang <caesar.upstream@gmail.com>
Cc: Kever Yang <kever.yang@rock-chips.com>
Cc: Tao Huang <huangtao@rock-chips.com>
Cc: Michael Niewoehner <linux@mniewoehner.de>
Cc: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Julius Werner <jwerner@chromium.org>
Cc: Doug Anderson <dianders@chromium.org>
Subject: [RFT PATCH v4 1/3] usb: dwc2: gadget: Only initialize device if in device mode
Date: Thu, 01 Sep 2016 14:07:51 -0700 [thread overview]
Message-ID: <ea433e9d1f683bc65939eb9eaab2b8597c9ede4a.1472763969.git.johnyoun@synopsys.com> (raw)
In-Reply-To: <cover.1472763969.git.johnyoun@synopsys.com>
In dwc2_hsotg_udc_start(), don't initialize the controller for device
mode unless we are actually in device mode.
Tested-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: John Youn <johnyoun@synopsys.com>
---
drivers/usb/dwc2/gadget.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 94bd19a..4cd6403 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -3466,8 +3466,11 @@ static int dwc2_hsotg_udc_start(struct usb_gadget *gadget,
otg_set_peripheral(hsotg->uphy->otg, &hsotg->gadget);
spin_lock_irqsave(&hsotg->lock, flags);
- dwc2_hsotg_init(hsotg);
- dwc2_hsotg_core_init_disconnected(hsotg, false);
+ if (dwc2_hw_is_device(hsotg)) {
+ dwc2_hsotg_init(hsotg);
+ dwc2_hsotg_core_init_disconnected(hsotg, false);
+ }
+
hsotg->enabled = 0;
spin_unlock_irqrestore(&hsotg->lock, flags);
--
2.9.0
next prev parent reply other threads:[~2016-09-01 21:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 21:07 [RFT PATCH v4 0/3] usb: dwc2: Fix core reset and force mode delays John Youn
2016-09-01 21:07 ` John Youn [this message]
2016-09-01 21:07 ` [RFT PATCH v4 2/3] usb: dwc2: Add delay to core soft reset John Youn
2016-09-01 21:07 ` [RFT PATCH v4 3/3] usb: dwc2: Properly account for the force mode delays John Youn
2016-09-06 21:40 ` [RFT PATCH v4 0/3] usb: dwc2: Fix core reset and " Stefan Wahren
2016-09-07 10:29 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea433e9d1f683bc65939eb9eaab2b8597c9ede4a.1472763969.git.johnyoun@synopsys.com \
--to=johnyoun@synopsys.com \
--cc=linux-rpi-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®