From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BA9541C2EA for ; Fri, 22 May 2026 14:41:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779460877; cv=none; b=GungZpw3nh6flrgM80fUCRAE4xGIlucqmpavtxGWO6AgbODhOI26gQR/j490jzWRFGJLj3hYrlfQiVU28cCbavyDfPFTs56LiawwtUGQ81FAhO45bhkICSlgOrLHIlW5hJRI10p5cWpSWUaZQfPeKkGf1vd3xml36X0rc9n6sGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779460877; c=relaxed/simple; bh=y/+/08RKkTsa2MuvavZnHZmq0MoOXmO5phHVtZs+8bc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IHMfZQ4gDt5RvGHkEVeVHPey8NnVW2p35TgPDugJuqt0gztO6IJUpTTN5JM5SFzATTyz4jjvHen8f3tYphRHtf8N4G0Ijl97pyIbcMCrLvSVAC1FHlUhL1t7+sLY0nAFP6oPiVSzIzLpFwCNp1lQwZxQmtA8Q7f7/0PvAB8xBjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jfihpSb1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PidOvA/B; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jfihpSb1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PidOvA/B" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64MBr4cB1297936 for ; Fri, 22 May 2026 14:41:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sSMMxHxRNCis+0TVEZjUEI9IKPS7rPdh57bkRY+Mtv0=; b=jfihpSb1ajNXjtB1 e+9hkWsNCDpF+XqTyA21VxoqCMeTq6TuOjMMZsUuYVi6U2GVLGY/LkzW5lDy066w Jey79YVI9wUY1+DzdCGa6rNMbIOWlszIfpVaxM31ASXMPhgN1h1Q+TC8CzHh+b9n WUw+Vo5n+PL1Vk6SR05lQn2OD1vbWgyjaiwyCHk+vMS6vIFHsBFYoJP1sx0nWjoj KkhILSPd+5x8E88YdaE5sOgsBDq1I4yhvNtAIXLDhg4uxpPXMbEDoGpini9DWu8X wd4XUmUUNMLm7QNcIyfNwzvizpNFt7C6EskD+awiG9XFcvW89jXeAyYPqoSl4fp0 vWi6SA== Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eaah0bdp0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 14:41:15 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-575296be5b1so564239e0c.0 for ; Fri, 22 May 2026 07:41:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779460875; x=1780065675; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sSMMxHxRNCis+0TVEZjUEI9IKPS7rPdh57bkRY+Mtv0=; b=PidOvA/BaILOO2VNN+QfwTp0kxHETTBaYJE2s7a3GT6VcKKr7oOq9niqvzUdZMyFUD QmElPhqcYGNvTVaWQS+f6jp/trJISSOhzhk+TiLro7caqD39Vs0QayBWZgripLexuEA0 hVkrZvYrOYDNc1lwCAF9KK9VyDLhFC30Y9EKmEcufbCBHS/r1pplOP+qfdtfNKk97/+v 3WlclRs4wlBtZZq8zfBJacu3srtlIDP4Lu+ytjUogiWCseEbOfiSMDCgHeXYGzLY+OHB w5fJEIIPOcfOVKDc9tFOxiLI907z+RYuSJEcTDWETfsbeU1SbVy669xLjv/UdLoS05rs m2Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779460875; x=1780065675; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sSMMxHxRNCis+0TVEZjUEI9IKPS7rPdh57bkRY+Mtv0=; b=rh/LwSROHON5iKOgHWfDphZABnGywJ73yyu1fzdmcKoX9y5Hk+r+vth4GtTDorkOiw Z7kMGjNgXWSCWwl3Z82w6iEIsWZkwNSyvwijD3DKQ7InKgcgf/MXfVVQPa1/mjkBDcLk Yv9XZ4y472yCiKU5etIDKJgMsnUhqE0qCMc4aTRiMGbQ6nGMkeq7gpoKEr5selLxM0QV Ea4b+9vkTaasss671w1Sl2u56Zmer7G6WgZicpskLU/0ATyi9VZcwiBmjqffuLUAokNe XamGqYSCxe2MfL7zx9T5eZNpy/cVFWP1LMcqI/RCmStkyZC6dwvjepjwIjdteYxSdPaA 1z9w== X-Forwarded-Encrypted: i=1; AFNElJ8KmpROYwCMCtr2zuXPpIOurzEVdalx6+hX/OJVDbQFO0xfL01j/16QgcJm2UfCnXcpdsqmbTSjcsnDRHA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5InxJ2u9Hc/EN0CE9sG7REAHZu3vtAL16T9vucowhH5VN46W2 qC8yR+5XLb5ZoQq/TlaJry/6UWcGWEv8i5gpHCmluLA4y2WZI9l0xoqucylfrktXPL7gW2pWCE7 nQZUB3cB5+4+RIryj8xBaV/E49pbbPGyeIu3ooZk964OehllBDZnVaN/1qZ2eEhPeaTI= X-Gm-Gg: Acq92OHiZBZXk+vmAOmNSC7RQ4WptimLhRSA25JBl/PVSfoQecV8BiJ1L1CXJWqnbnD vSqX+tCtJ+tRmoco+f4cEcdBF6Jh4fi4ocng0R+qZpaufSxqysMH32bm25/LSOtPx10BaR9of23 NBXUJmL4ddA7irCwIYwyXhJi7oJH1rbs+2il04GgVJpCVKEw4AQqmQqjLYDS5Q4DptRb7DBbpY2 wJrhe7i29EXguUyvgyt0hnQnSXQJHGViZT0YZdRf4KABBErg858eznkmXFRPWSEGotkYdEubjlc buOa+jmfE5H+sel3EGsfAXORtDOX6qR16leNZD313v4e7AbxBENQqEpSMUeVFpkzomm2px7J2lh jtP29g/5MYy+5jVznnSxVaGyfdnCQX8+Cj+3UYJFB54+n5g== X-Received: by 2002:a67:fd4e:0:b0:65b:c17:7052 with SMTP id ada2fe7eead31-67c5ff1dab4mr640209137.0.1779460874688; Fri, 22 May 2026 07:41:14 -0700 (PDT) X-Received: by 2002:a67:fd4e:0:b0:65b:c17:7052 with SMTP id ada2fe7eead31-67c5ff1dab4mr640187137.0.1779460874270; Fri, 22 May 2026 07:41:14 -0700 (PDT) Received: from [192.168.119.254] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bddc3652b34sm60566866b.28.2026.05.22.07.41.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 07:41:13 -0700 (PDT) Message-ID: Date: Fri, 22 May 2026 16:41:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 03/10] drm/msm/dp: Read DPCD and sink count in bridge detect() To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh , Yongxing Mou , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260314-hpd-refactor-v5-0-0c8450737d64@oss.qualcomm.com> <20260314-hpd-refactor-v5-3-0c8450737d64@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDE0NSBTYWx0ZWRfX7eMCcTzzDqHC 2YuTILKciSHXlKkeVnuyE7j6EyHSaePvQMJ3LSxIGENY+pu4dPoCjaYQXmZtlJ5k9CvswLIcI88 pjP7T8t4vTYoVdW9J4lbu0/uzIFlkDP6Jx4FHu3xg4+ffD/+nbZIBThg8HRZvdEiOR7PJtsCJ8V fYOUlOicLpKHSFk9LB93J7bBOHCkp5LPf+hOQN8qCkPqN1LsZl/PM5GgNyJ8M2lUZxgs07uo0hF UFGrqYVAzObs183gGtvTvC2n2vzLhtIYKWp+jPOZdz1+C4EpNN6cbpmc9u0i9oLi2omwdgAJwcc 8MjH8N94YfuzqoBEWBpIsqKv3BGGE1swJwdcaQGLb8dJn5l/CjTFvIokY5GlOXgnVqcVXWr9zch rq7dbd76bZcmub+eTuw8BbzLxUV2rSPf6hH1nih0UQVkojRBz3mSa4BtnmW76H+PvwlILeonrgI vUwCjcYnUFVaycXsjTg== X-Proofpoint-GUID: J_Lp3C5R260lLf6gmBsDv3xlhEEc51Av X-Authority-Analysis: v=2.4 cv=LNdWhpW9 c=1 sm=1 tr=0 ts=6a106b0b cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=FAVcj_sHJixdwfoHFuYA:9 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 X-Proofpoint-ORIG-GUID: J_Lp3C5R260lLf6gmBsDv3xlhEEc51Av X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220145 On 5/22/26 4:38 PM, Dmitry Baryshkov wrote: > On Fri, May 22, 2026 at 01:30:54PM +0200, Konrad Dybcio wrote: >> On 3/14/26 2:09 AM, Dmitry Baryshkov wrote: >>> From: Jessica Zhang >>> >>> Instead of relying on the link_ready flag to specify if DP is connected, >>> read the DPCD bits and get the sink count to accurately detect if DP is >>> connected. >>> >>> Signed-off-by: Jessica Zhang >>> Signed-off-by: Dmitry Baryshkov >>> --- >> >> There's still some trailing style/documentation feedback here from v3 > > I'll correct most of the feedback from both you and Bjorn. I'll leave pm > calls as is, without using ACQUIRE macros. I will think about using them > for the whole driver rather than just a single function. Sounds good Konrad