mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peng Donglin <dolinux.peng@gmail.com>
To: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
	Peng Donglin <dolinux.peng@gmail.com>
Subject: [PATCH v2 06/10] ASoC: mxs-sgtl5000: Remove unnecessary function call
Date: Wed, 23 Aug 2017 05:20:30 -0700	[thread overview]
Message-ID: <f672a072d422e23df2c1e56f643874caf613c360.1503484313.git.dolinux.peng@gmail.com> (raw)
In-Reply-To: <cover.1503484313.git.dolinux.peng@gmail.com>

The work of the function platform_set_drvdata is done by
devm_snd_soc_register_card.

Signed-off-by: Peng Donglin <dolinux.peng@gmail.com>
---
 sound/soc/mxs/mxs-sgtl5000.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/sound/soc/mxs/mxs-sgtl5000.c b/sound/soc/mxs/mxs-sgtl5000.c
index a96276e77332..90ca6f9131a1 100644
--- a/sound/soc/mxs/mxs-sgtl5000.c
+++ b/sound/soc/mxs/mxs-sgtl5000.c
@@ -140,16 +140,13 @@ static int mxs_sgtl5000_probe(struct platform_device *pdev)
 	}
 
 	card->dev = &pdev->dev;
-	platform_set_drvdata(pdev, card);
 
 	ret = devm_snd_soc_register_card(&pdev->dev, card);
-	if (ret) {
+	if (ret)
 		dev_err(&pdev->dev, "snd_soc_register_card failed (%d)\n",
 			ret);
-		return ret;
-	}
 
-	return 0;
+	return ret;
 }
 
 static int mxs_sgtl5000_remove(struct platform_device *pdev)
-- 
2.14.1

  parent reply	other threads:[~2017-08-23 12:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23 12:17 [PATCH v2 00/10] Remove unnecessary function Peng Donglin
2017-08-23 12:17 ` [PATCH v2 01/10] ASoC: s3c24xx_uda134x: Remove unnecessary function call Peng Donglin
2017-08-24 10:39   ` Mark Brown
2017-08-23 12:18 ` [PATCH v2 02/10] ASoC: mediatek: " Peng Donglin
2017-08-24 10:40   ` Mark Brown
2017-08-23 12:19 ` [PATCH v2 03/10] ASoC: Intel: " Peng Donglin
2017-08-28  2:20   ` Donglin Peng
2017-08-29 18:29     ` Mark Brown
2017-08-23 12:19 ` [PATCH v2 04/10] ASoC: atmel: " Peng Donglin
2017-08-23 12:20 ` [PATCH v2 05/10] ASoC: rockchip: " Peng Donglin
2017-08-23 12:20 ` Peng Donglin [this message]
2017-08-23 12:20 ` [PATCH v2 07/10] ASoC: qcom: Remove useless " Peng Donglin
2017-08-23 12:21 ` [PATCH v2 08/10] ASoC: sun4i-codec: Remove unnecessary " Peng Donglin
2017-08-23 12:21 ` [PATCH v2 09/10] ASoC: tegra: " Peng Donglin
2017-08-23 12:21 ` [PATCH v2 10/10] ASoC: ux500: " Peng Donglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f672a072d422e23df2c1e56f643874caf613c360.1503484313.git.dolinux.peng@gmail.com \
    --to=dolinux.peng@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®