From: Waiman Long <longman@redhat.com>
To: Tejun Heo <tj@kernel.org>,
lizefan@huawei.com, hannes@cmpxchg.org, peterz@infradead.org,
mingo@redhat.com
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, pjt@google.com, luto@amacapital.net,
efault@gmx.de, torvalds@linux-foundation.org, guro@fb.com
Subject: Re: [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v3
Date: Mon, 17 Jul 2017 10:48:44 -0400 [thread overview]
Message-ID: <f6cdb0b7-4c73-ff4c-6693-fd1cb17015c0@redhat.com> (raw)
In-Reply-To: <20170717020721.3612468-1-tj@kernel.org>
On 07/16/2017 10:07 PM, Tejun Heo wrote:
> Hello,
>
> This is v3 of cgroup2 thread mode patchset. The changes from v2[L]
> are
>
> * Switched to marking each cgroup threaded instead of doing it
> per-subtree as suggested by PeterZ. This allows more flexibility
> and removes certain interface quirks.
>
> * Dropped RFC tag and excluded cpu controller patches from this
> patchset as threaded mode behaviors can easily be verified with the
> pid controller. Will follow up with cpu controller patchset later.
>
> It is largely based on the discussions that we had at the plumbers
> last year. Here's the rough outline.
>
> * Thread mode is explicitly enabled on a cgroup by writing "threaded"
> into "cgroup.type" file. The cgroup shouldn't have any processes or
> child cgroups. A threaded cgroup joins the the parent's resource
> domain and becomes a part of the threaded subtree anchored at the
> nearest domain ancestor, which is called the threaded domain cgroup
> of the subtree.
>
> * Threads can be put anywhere in a threaded subtree by writing TIDs
> into "cgroup.threads" file. Process granularity and
> no-internal-process constraint don't apply in a threaded subtree.
>
> * To be used in a threaded subtree, controllers should explicitly
> declare thread mode support and should be able to handle internal
> competition in some way.
>
> * The threaded domain cgroup of a threaded subtree serves as the
> resource domain for the whole subtree. This is where all the
> controllers are guaranteed to have a common ground and resource
> consumptions in the threaded subtree which aren't tied to a specific
> thread are charged. Non-threaded controllers never see beyond
> thread root and can assume that all controllers will follow the same
> rules upto that point.
>
> * Unlike other cgroups, the system root cgroup can serve as parent to
> domain child cgroups and threaded domains to threaded subtrees.
>
> This allows threaded controllers to implement thread granular resource
> control without getting in the way of system level resource
> partitioning.
>
> For more details on the interface and behavior, please refer to 0005.
>
> This patchset contains the following six patches.
>
> 0001-cgroup-reorganize-cgroup.procs-task-write-path.patch
> 0002-cgroup-add-flags-to-css_task_iter_start-and-implemen.patch
> 0003-cgroup-introduce-cgroup-dom_cgrp-and-threaded-css_se.patch
> 0004-cgroup-implement-CSS_TASK_ITER_THREADED.patch
> 0005-cgroup-implement-cgroup-v2-thread-support.patch
> 0006-cgroup-update-debug-controller-to-print-out-thread-m.patch
>
> 0001-0005 implement cgroup2 thread mode. 0006 enables debug
> controller on it.
>
> The patchset is based on the current cgroup/for-4.14 27f26753f8c0
> ("cgroup: replace css_set walking populated test with testing
> cgrp->nr_populated_csets") and also available in the following git
> branch.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-cgroup2-threads-v3
Your new patches don't seem to be pushed to your git tree yet. I
couldn't find them there.
Cheers,
Longman
next prev parent reply other threads:[~2017-07-17 14:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 2:07 Tejun Heo
2017-07-17 2:07 ` [PATCH 1/6] cgroup: reorganize cgroup.procs / task write path Tejun Heo
2017-07-17 2:07 ` [PATCH 2/6] cgroup: add @flags to css_task_iter_start() and implement CSS_TASK_ITER_PROCS Tejun Heo
2017-07-17 2:07 ` [PATCH 3/6] cgroup: introduce cgroup->dom_cgrp and threaded css_set handling Tejun Heo
2017-07-17 2:07 ` [PATCH 4/6] cgroup: implement CSS_TASK_ITER_THREADED Tejun Heo
2017-07-17 2:07 ` [PATCH 5/6] cgroup: implement cgroup v2 thread support Tejun Heo
2017-07-17 14:14 ` Peter Zijlstra
2017-07-17 14:26 ` Tejun Heo
2017-07-18 17:28 ` Peter Zijlstra
2017-07-18 17:35 ` Waiman Long
2017-07-18 17:54 ` Tejun Heo
2017-07-18 18:41 ` Peter Zijlstra
2017-07-18 18:47 ` Tejun Heo
2017-07-19 14:07 ` Peter Zijlstra
2017-07-19 16:34 ` Tejun Heo
2017-07-17 20:56 ` Waiman Long
2017-07-18 14:37 ` Waiman Long
2017-07-18 17:10 ` Tejun Heo
2017-07-18 17:23 ` Waiman Long
2017-07-19 16:29 ` Tejun Heo
2017-07-19 17:09 ` Waiman Long
2017-07-19 17:48 ` Tejun Heo
2017-07-17 21:12 ` Waiman Long
2017-07-19 15:40 ` Tejun Heo
2017-07-17 2:07 ` [PATCH 6/6] cgroup: update debug controller to print out thread mode information Tejun Heo
2017-07-17 21:19 ` Waiman Long
2017-07-19 15:31 ` Tejun Heo
2017-07-19 15:41 ` Waiman Long
2017-07-19 15:44 ` Tejun Heo
2017-07-17 14:48 ` Waiman Long [this message]
2017-07-17 14:51 ` [PATCHSET for-4.13] cgroup: implement cgroup2 thread mode, v3 Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6cdb0b7-4c73-ff4c-6693-fd1cb17015c0@redhat.com \
--to=longman@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=efault@gmx.de \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®