From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966318AbcKLOlH (ORCPT ); Sat, 12 Nov 2016 09:41:07 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:35300 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935938AbcKLOlF (ORCPT ); Sat, 12 Nov 2016 09:41:05 -0500 Subject: Re: [PATCH] iio: cros_ec_sensors_core: fix unsigned compared less than zero on status To: Guenter Roeck , Colin King References: <20161109231231.6223-1-colin.king@canonical.com> Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Guenter Roeck , Gwendal Grignou , Enric Balletbo i Serra , linux-iio@vger.kernel.org, linux-kernel From: Jonathan Cameron Message-ID: Date: Sat, 12 Nov 2016 14:40:58 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/16 03:16, Guenter Roeck wrote: > On Wed, Nov 9, 2016 at 3:12 PM, Colin King wrote: >> From: Colin Ian King >> >> status is a u8 hence the check if status is less than zero has no effect. >> Fix this by replacing status with int ret so the less than zero compare >> will correctly detect errors. >> >> Issue found with static analysis with CoverityScan, CID 1375919 >> >> Signed-off-by: Colin Ian King > > Good catch! > > Fixes: 974e6f02e27e ("iio: cros_ec_sensors_core: Add common functions > for the ChromeOS EC Sensor Hub") > Reviewed-by: Guenter Roeck Thanks and applied to the togreg branch of iio.git - shortly to be pushed out as testing for the autobuilders to take a look at it. Jonathan > > For the benefit of others, this is in today's linux-next. > > Thanks, > Guenter > >> --- >> drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c >> index a3be799..416cae5 100644 >> --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c >> +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c >> @@ -291,15 +291,15 @@ int cros_ec_sensors_read_lpc(struct iio_dev *indio_dev, >> return -EIO; >> >> /* Read status byte until EC is not busy. */ >> - status = cros_ec_sensors_read_until_not_busy(st); >> - if (status < 0) >> - return status; >> + ret = cros_ec_sensors_read_until_not_busy(st); >> + if (ret < 0) >> + return ret; >> >> /* >> * Store the current sample id so that we can compare to the >> * sample id after reading the data. >> */ >> - samp_id = status & EC_MEMMAP_ACC_STATUS_SAMPLE_ID_MASK; >> + samp_id = ret & EC_MEMMAP_ACC_STATUS_SAMPLE_ID_MASK; >> >> /* Read all EC data, format it, and store it into data. */ >> ret = cros_ec_sensors_read_data_unsafe(indio_dev, scan_mask, >> -- >> 2.10.2 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >