From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Stefan Agner <stefan@agner.ch>, <plagnioj@jcrosoft.com>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>,
<devicetree@vger.kernel.org>, <linux-fbdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] video: mxsfb: get supply regulator optionally
Date: Tue, 6 Sep 2016 11:21:33 +0300 [thread overview]
Message-ID: <f8368040-bb5a-91e0-7511-df462719b949@ti.com> (raw)
In-Reply-To: <20160904042627.30182-1-stefan@agner.ch>
[-- Attachment #1.1: Type: text/plain, Size: 749 bytes --]
Hi,
On 04/09/16 07:26, Stefan Agner wrote:
> The lcd-supply is meant to be optional, there are several device-
> trees not specifying it and the code handles error values silently.
> Therefor, avoid creating a dummy regulator (and the associated
> warning) by using devm_regulator_get_optional.
>
> While at it, document that fact also in the device-tree bindings.
The binding change looks correct, but using
devm_regulator_get_optional() does not sound correct.
devm_regulator_get_optional() is to be used when the device in question
truly can function without the power supply. But if the supply is there,
it's just not controlled by the SW, devm_regulator_get() is to be used.
At least this is my understanding.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-06 8:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 4:26 Stefan Agner
2016-09-06 8:21 ` Tomi Valkeinen [this message]
2016-09-06 18:23 ` Stefan Agner
2016-09-06 22:22 ` Mark Brown
2016-09-07 7:20 ` Tomi Valkeinen
2016-09-12 23:47 ` Mark Brown
2016-11-09 0:16 ` Stefan Agner
2016-09-12 15:47 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8368040-bb5a-91e0-7511-df462719b949@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®