From: Grant Likely <grant.likely@secretlab.ca>
To: steve@digidescorp.com
Cc: Dan Williams <dan.j.williams@intel.com>,
linux-kernel@vger.kernel.org, monstr@monstr.eu,
microblaze-uclinux@itee.uq.edu.au
Subject: Re: [microblaze-uclinux] Re: [PATCH 3/4] dmaengine: xlldma platform bus driver
Date: Fri, 26 Mar 2010 16:27:29 -0600 [thread overview]
Message-ID: <fa686aa41003261527g434b1971k35422f91479d2e11@mail.gmail.com> (raw)
In-Reply-To: <1269642001.3001.325.camel@iscandar.digidescorp.com>
On Fri, Mar 26, 2010 at 4:20 PM, Steven J. Magnani
<steve@digidescorp.com> wrote:
> On Fri, 2010-03-26 at 15:33 -0600, Grant Likely wrote:
>> On Wed, Mar 17, 2010 at 10:26 AM, Steven J. Magnani
>> <steve@digidescorp.com> wrote:
>> > Platform bus attachment for the Xilinx MPMC Soft Direct Memory
>> > Access Controller DMA engine.
>> >
>> > Signed-off-by: Steven J. Magnani <steve@digidescorp.com>
>> > ---
>> > diff -uprN a/drivers/dma/xlldma_plat.c b/drivers/dma/xlldma_plat.c
>> > --- a/drivers/dma/xlldma_plat.c 1969-12-31 18:00:00.000000000 -0600
>> > +++ b/drivers/dma/xlldma_plat.c 2010-03-17 11:11:16.000000000 -0500
>>
>> Not really worth putting into a separate file. Just put this hunk in
>> the xlldma.c file to keep a few more symbols out of the global
>> namespace.
>
> I can certainly do that, but as someone who's had to add platform bus
> attachments to drivers that only have OF attachments, I can say from
> experience that the result ends up being rather messy. I thought
> (explicitly) decoupling the bus logic from the driver might be an
> improvement. Maybe it's not enough of a benefit.
of_platform is geting merged with platform bus so this issue is going
away. Just put it all in one file.
g.
prev parent reply other threads:[~2010-03-26 22:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 16:26 Steven J. Magnani
2010-03-26 21:33 ` Grant Likely
2010-03-26 22:20 ` [microblaze-uclinux] " Steven J. Magnani
2010-03-26 22:27 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa41003261527g434b1971k35422f91479d2e11@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=monstr@monstr.eu \
--cc=steve@digidescorp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®