From: Dirk Behme <dirk.behme@de.bosch.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Gary Guo <gary@garyguo.net>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Dave Ertman" <david.m.ertman@intel.com>,
"Ira Weiny" <ira.weiny@intel.com>,
"Leon Romanovsky" <leon@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] samples: rust: remove imports available via prelude
Date: Fri, 30 Jan 2026 13:45:05 +0100 [thread overview]
Message-ID: <fb68b2d2-a5bd-4359-a0c5-019ef4060e7d@de.bosch.com> (raw)
In-Reply-To: <CANiq72kwRdYbs9L1hrX_0SdGHsycMi9fz6+wh+qGgWiOsFZZiQ@mail.gmail.com>
On 27/01/2026 12:10, Miguel Ojeda wrote:
> On Sat, Jan 24, 2026 at 6:08 AM Gary Guo <gary@garyguo.net> wrote:
>>
>> These imports are already in scope by importing `kernel::prelude::*` and
>> does not need to be imported separately.
>>
>> Signed-off-by: Gary Guo <gary@garyguo.net>
>
> Applied (this one only) to `rust-next` -- thanks everyone!
Having my klint setup running now (many thanks Gary!) on today's
rust-next [1] I still get
error: this item is available via prelude
--> samples/rust/rust_driver_auxiliary.rs:12:5
|
12 | error::Error,
| ^^^^^^^^^^^^
|
= help: import with `kernel::prelude::*` instead
= note: `-D klint::not-using-prelude` implied by `-D warnings`
= help: to override `-D warnings` add
`#[allow(klint::not_using_prelude)]`
error: aborting due to 1 previous error
Somehow dropping this was not part of this patch. Not sure why ...
Best regards
Dirk
[1] HEAD is 08afcc38a64c ("Merge patch series "Add support for print
exactly once"")
next prev parent reply other threads:[~2026-01-30 12:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260123172007.136873-1-gary@garyguo.net>
2026-01-23 17:19 ` [PATCH 1/3] gpu: nova-core: " Gary Guo
2026-01-25 21:17 ` Danilo Krummrich
2026-01-27 11:30 ` Danilo Krummrich
2026-01-27 11:44 ` Miguel Ojeda
2026-01-30 4:42 ` Miguel Ojeda
2026-01-23 17:19 ` [PATCH 2/3] block: rnull: " Gary Guo
2026-01-26 18:27 ` Andreas Hindborg
2026-01-26 18:37 ` Miguel Ojeda
2026-01-27 12:51 ` Andreas Hindborg
2026-01-23 17:19 ` [PATCH 3/3] samples: rust: " Gary Guo
2026-01-25 21:17 ` Danilo Krummrich
2026-01-26 9:23 ` Alice Ryhl
2026-01-26 15:02 ` Miguel Ojeda
2026-01-26 16:04 ` Greg Kroah-Hartman
2026-01-27 11:10 ` Miguel Ojeda
2026-01-30 12:45 ` Dirk Behme [this message]
2026-01-30 14:24 ` Gary Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb68b2d2-a5bd-4359-a0c5-019ef4060e7d@de.bosch.com \
--to=dirk.behme@de.bosch.com \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=arnd@arndb.de \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=david.m.ertman@intel.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®