From: bot+bpf-ci@kernel.org
To: ihor.solodrai@linux.dev,bp@alien8.de,dave.hansen@linux.intel.com,mingo@redhat.com,tglx@kernel.org
Cc: ast@kernel.org,andrii@kernel.org,ryabinin.a.a@gmail.com,akpm@linux-foundation.org,hpa@zytor.com,andreyknvl@gmail.com,linux-kernel@vger.kernel.org,x86@kernel.org,bpf@vger.kernel.org,kasan-dev@googlegroups.com,linux-mm@kvack.org,kernel-team@meta.com,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,mason@kernel.org,ihor.solodrai@linux.dev
Subject: Re: [PATCH v3 3/5] x86/cpu: Inline generic_identify() into identify_cpu()
Date: Thu, 17 Sep 2026 23:49:43 +0000 (UTC) [thread overview]
Message-ID: <fc85d83ac07c116cd243a2bbfff0a994abcea9e9588048e80f9a1234d772b757@mail.kernel.org> (raw)
In-Reply-To: <20260916195203.1099646-4-ihor.solodrai@linux.dev>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
> generic_identify() has exactly one call site: at the top of
> identify_cpu(). Fold it into identify_cpu() so that a single function
> does the job for both the boot CPU and the secondary CPUs.
>
> While at it, fix up both copies of the Cyrix comment.
>
> No functional changes.
This isn't a bug, but since identify_cpu() already covered both the
boot and secondary CPUs before this patch, could the changelog instead
say what the fold enables for the following patches (e.g. making the
init_cpu_info() placement explicit)?
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/35285131592
next prev parent reply other threads:[~2026-09-17 23:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 19:51 [PATCH v3 0/5] x86/cpu: Refactor identify_cpu() Ihor Solodrai
2026-09-16 19:51 ` [PATCH v3 1/5] x86/cpu: Factor init_cpu_info() out of identify_cpu() Ihor Solodrai
2026-09-17 2:00 ` [tip: x86/cpu] " tip-bot2 for Ihor Solodrai
2026-09-17 23:49 ` [PATCH v3 1/5] " bot+bpf-ci
2026-09-16 19:52 ` [PATCH v3 2/5] x86/cpu: Initialize boot CPU cpuinfo defaults early Ihor Solodrai
2026-09-17 2:00 ` [tip: x86/cpu] " tip-bot2 for Ihor Solodrai
2026-09-17 23:49 ` [PATCH v3 2/5] " bot+bpf-ci
2026-09-16 19:52 ` [PATCH v3 3/5] x86/cpu: Inline generic_identify() into identify_cpu() Ihor Solodrai
2026-09-17 2:00 ` [tip: x86/cpu] " tip-bot2 for Ihor Solodrai
2026-09-17 23:49 ` bot+bpf-ci [this message]
2026-09-16 19:52 ` [PATCH v3 4/5] x86/cpu: Move 32-bit SEP setup " Ihor Solodrai
2026-09-17 2:00 ` [tip: x86/cpu] " tip-bot2 for Ihor Solodrai
2026-09-17 23:49 ` [PATCH v3 4/5] " bot+bpf-ci
2026-09-16 19:52 ` [PATCH v3 5/5] x86/cpu: Don't transiently clear the boot CPU's capabilities Ihor Solodrai
2026-09-17 2:00 ` [tip: x86/cpu] " tip-bot2 for Ihor Solodrai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc85d83ac07c116cd243a2bbfff0a994abcea9e9588048e80f9a1234d772b757@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dave.hansen@linux.intel.com \
--cc=eddyz87@gmail.com \
--cc=hpa@zytor.com \
--cc=ihor.solodrai@linux.dev \
--cc=kasan-dev@googlegroups.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin.lau@kernel.org \
--cc=mason@kernel.org \
--cc=mingo@redhat.com \
--cc=ryabinin.a.a@gmail.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®