From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754013AbbJGNlM (ORCPT ); Wed, 7 Oct 2015 09:41:12 -0400 Received: from max.feld.cvut.cz ([147.32.192.36]:35136 "EHLO max.feld.cvut.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751727AbbJGNlL (ORCPT ); Wed, 7 Oct 2015 09:41:11 -0400 User-Agent: Kaiten Mail In-Reply-To: <56151E38.5030006@ezchip.com> References: <87k2qyyh4x.fsf@steelpick.2x.cz> <56151E38.5030006@ezchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: error: implicit declaration of function 'zero_bytemask' From: Michal Sojka Date: Wed, 07 Oct 2015 15:41:04 +0200 To: Chris Metcalf CC: lkml Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7. října 2015 15:29:28 CEST, Chris Metcalf wrote: >On 10/07/2015 08:53 AM, Michal Sojka wrote: >> Dear Chris, >> >> the following commit breaks my Linux build. >> >> commit 990486c8af044f89bddfbde1d1cf9fde449bedbf >> Author: Chris Metcalf >> Date: Tue Oct 6 12:37:41 2015 -0400 >> >> strscpy: zero any trailing garbage bytes in the destination >> >> It's possible that the destination can be shadowed in >userspace >> (as, for example, the perf buffers are now). So we should >take >> care not to leak data that could be inspected by userspace. >> >> The error message is: >> >> lib/string.c: In function 'strscpy': >> lib/string.c:209:4: error: implicit declaration of function >'zero_bytemask' [-Werror=implicit-function-declaration] >> cc1: some warnings being treated as errors >> >> I compile the kernel for PowerPC (32 bit) with the attached config. > >Ah, it appears that big-endian powerpc does not provide >zero_bytemask(), only little-endian. I'll fix this in v3 of >the patch series - thanks! The patch is already in mainline so I guess a fixup patch would be more appropriate. -- Odesláno z mého telefonu pomocí Kaiten Mail. Omluvte prosím mou stručnost.