mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Petr Mladek <pmladek@suse.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: Make CONSOLE_LOGLEVEL_QUIET configurable
Date: Wed, 20 Jun 2018 16:18:12 +0200	[thread overview]
Message-ID: <s5h4lhxmti3.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180620100753.7acaee14@gandalf.local.home>

On Wed, 20 Jun 2018 16:07:53 +0200,
Steven Rostedt wrote:
> 
> On Wed, 20 Jun 2018 13:03:35 +0200
> Petr Mladek <pmladek@suse.com> wrote:
> 
> > I find it a bit confusing that "quiet" would mean something different
> > on different systems.
> 
> I disagree. "quiet" to me is for people that really don't care to see
> anything from the kernel except for real issues that they need to
> report. The first thing that I do, and many other kernel developers I
> know, when installing a new distro, is to remove the "quiet" from the
> command line. Because *I* care about the output.
> 
> 
> > 
> > Why did not you use loglevel=<whatever_you_need> instead of "quiet"?
> > 
> > Alternative solution would be to add "silent" or so to calm down
> > everything. But I am afraid that any change in this area would
> > just create a mess similar to grep -s and -q options.
> > 
> > 
> > Best Regards,
> > Petr
> > 
> > PS: I will not block it if Steven and Sergey are fine with this. But
> > I want to be sure that they considered the above views. It looked like
> > a no-brainer to me at the beginning. I even pushed this to printk.git.
> > But the pushing gave me some more time to think about it...
> 
> I prefer this patch over adding yet another kernel command line command
> that will just add to the confusion. I can imagine people saying
> "what's the difference between 'quiet' and 'silent'?". I would.
> 
> I think having it as a config option is the perfect solution. I imagine
> that as soon as Red Hat changes the meaning of "quiet" so will all the
> other distros.

Yeah, SUSE has gathered a pile of such bug reports and complaints from
customers, too, so we'd happily follow that :)


thanks,

Takashi

      reply	other threads:[~2018-06-20 14:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-19 11:57 Hans de Goede
2018-06-19 13:31 ` Steven Rostedt
2018-06-20  6:34   ` Sergey Senozhatsky
2018-06-20 11:03 ` Petr Mladek
2018-06-20 11:24   ` Sergey Senozhatsky
2018-06-20 13:43     ` Hans de Goede
2018-06-21  1:43       ` Sergey Senozhatsky
2018-06-20 13:37   ` Hans de Goede
2018-06-25 14:56     ` Petr Mladek
2018-06-20 14:07   ` Steven Rostedt
2018-06-20 14:18     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h4lhxmti3.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®