mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Sachin Kumar Garg <sachin.garg@oss.qualcomm.com>
Cc: Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
	Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Bryan O'Donoghue <bod@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] media: iris: enable pipe for hfi gen2 encoder
Date: Sun, 27 Sep 2026 21:23:25 +0300	[thread overview]
Message-ID: <y33yqv3wnviooarmgbiunmy7gxckot26hrju3fekxtvuxgqyvz@ee5pz4ogx4vn> (raw)
In-Reply-To: <20260927-iris_vbv_delay-v4-1-8ee2b7462e68@oss.qualcomm.com>

On Sun, Sep 27, 2026 at 09:27:45AM +0530, Sachin Kumar Garg wrote:
> Currently the PIPE capability (HFI_PROP_PIPE / work-route) is only
> wired up for the HFI Gen2 decoder. Add a PIPE entry to the HFI Gen2
> encoder instance capability table, and extend the encoder
> branch of iris_session_init_caps() to derive PIPE's min/max/value
> from the platform's num_vpp_pipe, mirroring the existing decoder
> handling.
> 
> Reviewed-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
> Signed-off-by: Sachin Kumar Garg <sachin.garg@oss.qualcomm.com>
> ---
>  drivers/media/platform/qcom/iris/iris_ctrls.c    | 16 +++++++++++++---
>  drivers/media/platform/qcom/iris/iris_hfi_gen2.c |  7 +++++++
>  2 files changed, 20 insertions(+), 3 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

Nit: it's strongly recommended to send new iterations of the series as a
new thread instead of sending it as a reply to the previous iteration.

-- 
With best wishes
Dmitry

  reply	other threads:[~2026-09-27 18:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 14:55 [PATCH 0/2] media: iris: add vbv delay support Sachin Kumar Garg
2026-07-30 14:55 ` [PATCH 1/2] media: iris: enable pipe for hfi gen2 encoder Sachin Kumar Garg
2026-09-22 13:50   ` Vikash Garodia
2026-07-30 14:55 ` [PATCH 2/2] media: iris: add support for vbv delay Sachin Kumar Garg
2026-09-22 13:51   ` Vikash Garodia
2026-09-26 13:08 ` [PATCH v2 0/2] media: iris: add vbv delay support Sachin Kumar Garg
2026-09-26 13:08   ` [PATCH v2 1/2] media: iris: enable pipe for hfi gen2 encoder Sachin Kumar Garg
2026-09-26 13:08   ` [PATCH v2 2/2] media: iris: add support for vbv delay Sachin Kumar Garg
2026-09-26 17:09   ` [PATCH v3 0/2] media: iris: add vbv delay support Sachin Kumar Garg
2026-09-26 17:09     ` [PATCH v3 1/2] media: iris: enable pipe for hfi gen2 encoder Sachin Kumar Garg
2026-09-26 17:09     ` [PATCH v3 2/2] media: iris: add support for vbv delay Sachin Kumar Garg
2026-09-27  3:57     ` [PATCH v4 0/2] media: iris: add vbv delay support Sachin Kumar Garg
2026-09-27  3:57       ` [PATCH v4 1/2] media: iris: enable pipe for hfi gen2 encoder Sachin Kumar Garg
2026-09-27 18:23         ` Dmitry Baryshkov [this message]
2026-09-27  3:57       ` [PATCH v4 2/2] media: iris: add support for vbv delay Sachin Kumar Garg
2026-09-27 18:25         ` Dmitry Baryshkov
2026-09-29 11:53           ` Sachin Kumar Garg
2026-09-29 15:05             ` Dmitry Baryshkov
2026-09-29 16:07               ` Sachin Kumar Garg
2026-10-03 22:28                 ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=y33yqv3wnviooarmgbiunmy7gxckot26hrju3fekxtvuxgqyvz@ee5pz4ogx4vn \
    --to=dmitry.baryshkov@oss.qualcomm.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=bod@kernel.org \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sachin.garg@oss.qualcomm.com \
    --cc=vikash.garodia@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®