mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
* [PATCH] ASoC: meson: aiu: make aiu_formatter_i2s_drv static
@ 2026-08-12 20:50 Jerome Brunet
  2026-08-12 22:13 ` Valerio Setti
  2026-08-13 12:17 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Jerome Brunet @ 2026-08-12 20:50 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	Neil Armstrong, Kevin Hilman, Martin Blumenstingl, Valerio Setti
  Cc: linux-sound, linux-arm-kernel, linux-amlogic, linux-kernel,
	kernel test robot, Jerome Brunet

aiu_formatter_i2s_drv is indeed used only in the aiu and it is not meant
to be exported. It should be static.

Cc: Valerio Setti <vsetti@baylibre.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202608080634.hf6aJGPB-lkp@intel.com/
Fixes: 83b83024cdbf ("ASoC: meson: aiu: use aiu-formatter-i2s to format I2S output data")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 sound/soc/meson/aiu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/meson/aiu.c b/sound/soc/meson/aiu.c
index 2668646e3597..535fbf7c1639 100644
--- a/sound/soc/meson/aiu.c
+++ b/sound/soc/meson/aiu.c
@@ -182,7 +182,7 @@ static const struct regmap_config aiu_regmap_cfg = {
 	.max_register	= 0x2ac,
 };
 
-const struct gx_formatter_driver aiu_formatter_i2s_drv = {
+static const struct gx_formatter_driver aiu_formatter_i2s_drv = {
 	.regmap_cfg	= &aiu_regmap_cfg,
 	.ops		= &aiu_formatter_i2s_ops,
 };

---
base-commit: 83bf17424a97ab277ead2d98e3500bc632df0c40
change-id: 20260812-aiu-formatter-static-23aaa4c3bdbb

Best regards,
--  
Jerome


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: meson: aiu: make aiu_formatter_i2s_drv static
  2026-08-12 20:50 [PATCH] ASoC: meson: aiu: make aiu_formatter_i2s_drv static Jerome Brunet
@ 2026-08-12 22:13 ` Valerio Setti
  2026-08-13 12:17 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Valerio Setti @ 2026-08-12 22:13 UTC (permalink / raw)
  To: Jerome Brunet
  Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	Neil Armstrong, Kevin Hilman, Martin Blumenstingl, Valerio Setti,
	linux-sound, linux-arm-kernel, linux-amlogic, linux-kernel,
	kernel test robot

On Wed, 12 Aug 2026 22:50:34 +0200, Jerome Brunet <jbrunet@baylibre.com> wrote:
> aiu_formatter_i2s_drv is indeed used only in the aiu and it is not meant
> to be exported. It should be static.
> 

Thanks for the fix!

Reviewed-by: Valerio Setti <vsetti@baylibre.com>

-- 
Valerio Setti <vsetti@baylibre.com>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: meson: aiu: make aiu_formatter_i2s_drv static
  2026-08-12 20:50 [PATCH] ASoC: meson: aiu: make aiu_formatter_i2s_drv static Jerome Brunet
  2026-08-12 22:13 ` Valerio Setti
@ 2026-08-13 12:17 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2026-08-13 12:17 UTC (permalink / raw)
  To: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Neil Armstrong,
	Kevin Hilman, Martin Blumenstingl, Valerio Setti, Jerome Brunet
  Cc: linux-sound, linux-arm-kernel, linux-amlogic, linux-kernel,
	kernel test robot

On Wed, 12 Aug 2026 22:50:34 +0200, Jerome Brunet wrote:
> ASoC: meson: aiu: make aiu_formatter_i2s_drv static

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.3

Thanks!

[1/1] ASoC: meson: aiu: make aiu_formatter_i2s_drv static
      https://git.kernel.org/broonie/sound/c/583e44f2828b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-08-13 17:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-12 20:50 [PATCH] ASoC: meson: aiu: make aiu_formatter_i2s_drv static Jerome Brunet
2026-08-12 22:13 ` Valerio Setti
2026-08-13 12:17 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®