Re: [PATCH v3 1/4] spi: dt-bindings: amlogic: spisg: Document A9-specific properties

[Xianwei Zhao <xianwei.zhao@amlogic.com>]

Hi Mark,
    Thanks for your review.

On 2026/8/1 06:51, Mark Brown wrote:
> On Fri, Jul 31, 2026 at 09:08:25AM +0000, Xianwei Zhao via B4 Relay wrote:
>> From: Xianwei Zhao<xianwei.zhao@amlogic.com>
>>
>> Document the Amlogic A9 SPISG controller and its additional Device Tree
>> properties.
>>
>> Add the "amlogic,a9-spisg" compatible string and define the A9-specific
>> "amlogic,mo-idle-output" property, which configure the MOSI idle output
>> level.
>> +  amlogic,mo-idle-output:
>> +    description: |
>> +      Controls the MOSI output level when the controller is idle.
>> +      0 - Drive MOSI low
>> +      1 - Drive MOSI high
>> +      2 - Follow the last transmitted bit
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    enum: [0, 1, 2]
>> +    default: 0
> This looks like the standard SPI_MOSI_IDLE_{LOW,HIGH} we have in the
> kernel, plus one new option.  Usually the client driver would control
> this.  Why do something different here?

This controls the MOSI output level during the clock idle cycles 
inserted between consecutive SPI words, rather than the bus idle state 
after a transfer completes.There are some issues with the description 
here and I will make modifications. Meanwhile, there is another problem 
here. Since this mainly concerns the attributes of the device rather 
than the host, is it correct to add it here? Can I plus 
SPI_MOSI_INTERWORD_LOW/SPI_MOSI_INTERWORD_HIGH/SPI_MOSI_INTERWORD_KEEP 
option, in spidev mode?

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic