* [PATCH v2] staging: ft1000: convert pack pragma to __packed
@ 2015-06-25 17:34 Giedrius Statkevičius
0 siblings, 0 replies; only message in thread
From: Giedrius Statkevičius @ 2015-06-25 17:34 UTC (permalink / raw)
To: gregkh
Cc: marek.belisko, joe, tapaswenipathak, mahfouz.saif.elyazal,
gulsah.1004, hamohammed.sa, devel, linux-kernel,
Giedrius Statkevičius
Convert a Microsoft compiler specific directive "#pragma pack(1)" to a
GCC equivalent __packed. Also, by doing this we save
ourselves from trouble if any other struct definitions are added after
the #pragma because it will be applied to all of the definitions
following it.
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
---
v2: Convert __atribute__ ((__packed__)) to __packed as advised by Joe Perches
---
drivers/staging/ft1000/ft1000-usb/ft1000_download.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
index 5def347..121792f 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
@@ -95,7 +95,6 @@ struct dsp_file_hdr {
long nDspImages; /* Number of DSP images in file. */
};
-#pragma pack(1)
struct dsp_image_info {
long coff_date; /* Date/time when DSP Coff image was built. */
long begin_offset; /* Offset in file where image begins. */
@@ -105,7 +104,7 @@ struct dsp_image_info {
long version; /* Embedded version # of DSP code. */
unsigned short checksum; /* DSP File checksum */
unsigned short pad1;
-};
+} __packed;
/* checks if the doorbell register is cleared */
--
2.4.4
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-06-25 17:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-25 17:34 [PATCH v2] staging: ft1000: convert pack pragma to __packed Giedrius Statkevičius
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®