* [PATCH] drivers: staging: greybus: audio_codec.c: Fixed CHECKS for brace issues
@ 2016-10-09 22:26 Chase Metzger
2016-10-10 11:55 ` Vaibhav Agarwal
0 siblings, 1 reply; 2+ messages in thread
From: Chase Metzger @ 2016-10-09 22:26 UTC (permalink / raw)
To: vaibhav.sr
Cc: Chase Metzger, Mark Greer, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, devel, linux-kernel
Added braces to else statement where checkpatch complained.
Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
---
drivers/staging/greybus/audio_codec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
index 8a0744b..1bdf849 100644
--- a/drivers/staging/greybus/audio_codec.c
+++ b/drivers/staging/greybus/audio_codec.c
@@ -655,8 +655,10 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
ret = gb_audio_apbridgea_shutdown_rx(data->connection,
0);
params->state = GBAUDIO_CODEC_STOP;
- } else
+ } else {
ret = -EINVAL;
+ }
+
if (ret)
dev_err_ratelimited(dai->dev,
"%s:Error during %s %s stream:%d\n",
--
2.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: staging: greybus: audio_codec.c: Fixed CHECKS for brace issues
2016-10-09 22:26 [PATCH] drivers: staging: greybus: audio_codec.c: Fixed CHECKS for brace issues Chase Metzger
@ 2016-10-10 11:55 ` Vaibhav Agarwal
0 siblings, 0 replies; 2+ messages in thread
From: Vaibhav Agarwal @ 2016-10-10 11:55 UTC (permalink / raw)
To: Chase Metzger
Cc: Mark Greer, Johan Hovold, Alex Elder, Greg Kroah-Hartman, devel,
linux-kernel
On Mon, Oct 10, 2016 at 3:56 AM, Chase Metzger <chasemetzger15@gmail.com> wrote:
> Added braces to else statement where checkpatch complained.
>
> Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
> ---
> drivers/staging/greybus/audio_codec.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index 8a0744b..1bdf849 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -655,8 +655,10 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
> ret = gb_audio_apbridgea_shutdown_rx(data->connection,
> 0);
> params->state = GBAUDIO_CODEC_STOP;
> - } else
> + } else {
> ret = -EINVAL;
> + }
> +
> if (ret)
> dev_err_ratelimited(dai->dev,
> "%s:Error during %s %s stream:%d\n",
> --
> 2.1.4
>
Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-10 12:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-09 22:26 [PATCH] drivers: staging: greybus: audio_codec.c: Fixed CHECKS for brace issues Chase Metzger
2016-10-10 11:55 ` Vaibhav Agarwal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®