* [PATCH] drivers: watchdog: pika_wdt: add __ro_after_init to ident
@ 2016-12-25 8:00 Bhumika Goyal
2016-12-26 10:39 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Bhumika Goyal @ 2016-12-25 8:00 UTC (permalink / raw)
To: julia.lawall, wim, linux, linux-watchdog, linux-kernel
Cc: keescook, Bhumika Goyal
The object ident of type watchdog_info structure is not
modified after getting initialized by pikawdt_init. Apart from getting
referenced in init it is also passed as an argument to the function
copy_to_user but this argument is of type const void *. Therefore add
__ro_after_init to its declaration.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/watchdog/pika_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/pika_wdt.c b/drivers/watchdog/pika_wdt.c
index 0cdfee2..e35cf5e 100644
--- a/drivers/watchdog/pika_wdt.c
+++ b/drivers/watchdog/pika_wdt.c
@@ -54,7 +54,7 @@
struct timer_list timer; /* The timer that pings the watchdog */
} pikawdt_private;
-static struct watchdog_info ident = {
+static struct watchdog_info ident __ro_after_init = {
.identity = DRV_NAME,
.options = WDIOF_CARDRESET |
WDIOF_SETTIMEOUT |
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drivers: watchdog: pika_wdt: add __ro_after_init to ident
2016-12-25 8:00 [PATCH] drivers: watchdog: pika_wdt: add __ro_after_init to ident Bhumika Goyal
@ 2016-12-26 10:39 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2016-12-26 10:39 UTC (permalink / raw)
To: Bhumika Goyal, julia.lawall, wim, linux-watchdog, linux-kernel; +Cc: keescook
On 12/25/2016 12:00 AM, Bhumika Goyal wrote:
> The object ident of type watchdog_info structure is not
> modified after getting initialized by pikawdt_init. Apart from getting
> referenced in init it is also passed as an argument to the function
> copy_to_user but this argument is of type const void *. Therefore add
> __ro_after_init to its declaration.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/pika_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/pika_wdt.c b/drivers/watchdog/pika_wdt.c
> index 0cdfee2..e35cf5e 100644
> --- a/drivers/watchdog/pika_wdt.c
> +++ b/drivers/watchdog/pika_wdt.c
> @@ -54,7 +54,7 @@
> struct timer_list timer; /* The timer that pings the watchdog */
> } pikawdt_private;
>
> -static struct watchdog_info ident = {
> +static struct watchdog_info ident __ro_after_init = {
> .identity = DRV_NAME,
> .options = WDIOF_CARDRESET |
> WDIOF_SETTIMEOUT |
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-26 10:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-25 8:00 [PATCH] drivers: watchdog: pika_wdt: add __ro_after_init to ident Bhumika Goyal
2016-12-26 10:39 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®