* [PATCH v3 01/28] media: staging: atomisp: Remove unnecessary return statement in void function
2026-03-10 21:39 ` [PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions Tomasz Unger
@ 2026-03-10 21:39 ` Tomasz Unger
2026-03-10 21:39 ` [PATCH v3 02/28] media: staging: atomisp: Remove unnecessary return statements in inputfifo.c Tomasz Unger
` (8 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: Tomasz Unger @ 2026-03-10 21:39 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman
Cc: linux-media, linux-kernel, linux-staging, Tomasz Unger
Remove redundant 'return;' at the end of void function
ia_css_dvs_statistics_get(). There are other similar occurrences
in the driver that will be addressed in follow-up patches.
Found with checkpatch.pl --strict.
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
drivers/staging/media/atomisp/pci/sh_css_param_dvs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/sh_css_param_dvs.c b/drivers/staging/media/atomisp/pci/sh_css_param_dvs.c
index 9ccdb66de2df..3d2cb2d25fdb 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_param_dvs.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_param_dvs.c
@@ -269,5 +269,4 @@ ia_css_dvs_statistics_get(enum dvs_statistics_type type,
ia_css_get_dvs2_statistics(host_stats->p_dvs2_statistics_host,
isp_stats->p_dvs_statistics_isp);
}
- return;
}
--
2.53.0
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH v3 02/28] media: staging: atomisp: Remove unnecessary return statements in inputfifo.c
2026-03-10 21:39 ` [PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions Tomasz Unger
2026-03-10 21:39 ` [PATCH v3 01/28] media: staging: atomisp: Remove unnecessary return statement in void function Tomasz Unger
@ 2026-03-10 21:39 ` Tomasz Unger
2026-03-10 21:39 ` [PATCH v3 03/28] media: staging: atomisp: Remove unnecessary return statement in bufq.c Tomasz Unger
` (7 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: Tomasz Unger @ 2026-03-10 21:39 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman
Cc: linux-media, linux-kernel, linux-staging, Tomasz Unger
Remove redundant 'return;' statements at the end of void functions
in inputfifo.c. Void functions do not need an explicit return
statement at the end.
Found with checkpatch.pl --strict.
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
.../media/atomisp/pci/runtime/inputfifo/src/inputfifo.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c b/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c
index 8e1efeb6372c..f0dcd839e33b 100644
--- a/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c
+++ b/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c
@@ -88,7 +88,6 @@ _sh_css_fifo_snd(unsigned int token)
while (!can_event_send_token(STR2MIPI_EVENT_ID))
udelay(1);
event_send_token(STR2MIPI_EVENT_ID, token);
- return;
}
static void inputfifo_send_data_a(
@@ -98,7 +97,6 @@ static void inputfifo_send_data_a(
unsigned int token = (1 << HIVE_STR_TO_MIPI_VALID_A_BIT) |
(data << HIVE_STR_TO_MIPI_DATA_A_LSB);
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_send_data_b(
@@ -108,7 +106,6 @@ static void inputfifo_send_data_b(
unsigned int token = (1 << HIVE_STR_TO_MIPI_VALID_B_BIT) |
(data << _HIVE_STR_TO_MIPI_DATA_B_LSB);
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_send_data(
@@ -121,7 +118,6 @@ static void inputfifo_send_data(
(a << HIVE_STR_TO_MIPI_DATA_A_LSB) |
(b << _HIVE_STR_TO_MIPI_DATA_B_LSB));
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_send_sol(void)
@@ -131,7 +127,6 @@ static void inputfifo_send_sol(void)
1 << HIVE_STR_TO_MIPI_SOL_BIT);
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_send_eol(void)
@@ -140,7 +135,6 @@ static void inputfifo_send_eol(void)
hrt_data token = inputfifo_wrap_marker(
1 << HIVE_STR_TO_MIPI_EOL_BIT);
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_send_sof(void)
@@ -150,7 +144,6 @@ static void inputfifo_send_sof(void)
1 << HIVE_STR_TO_MIPI_SOF_BIT);
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_send_eof(void)
@@ -159,7 +152,6 @@ static void inputfifo_send_eof(void)
hrt_data token = inputfifo_wrap_marker(
1 << HIVE_STR_TO_MIPI_EOF_BIT);
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_send_ch_id_and_fmt_type(
@@ -177,7 +169,6 @@ static void inputfifo_send_ch_id_and_fmt_type(
*/
token = inputfifo_wrap_marker(0);
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_send_empty_token(void)
@@ -186,7 +177,6 @@ static void inputfifo_send_empty_token(void)
hrt_data token = inputfifo_wrap_marker(0);
_sh_css_fifo_snd(token);
- return;
}
static void inputfifo_start_frame(
@@ -196,7 +186,6 @@ static void inputfifo_start_frame(
{
inputfifo_send_ch_id_and_fmt_type(ch_id, fmt_type);
inputfifo_send_sof();
- return;
}
static void inputfifo_end_frame(
@@ -207,7 +196,6 @@ static void inputfifo_end_frame(
for (i = 0; i < marker_cycles; i++)
inputfifo_send_empty_token();
inputfifo_send_eof();
- return;
}
static void inputfifo_send_line2(
@@ -297,7 +285,6 @@ static void inputfifo_send_line2(
for (i = 0; i < hblank_cycles; i++)
inputfifo_send_empty_token();
inputfifo_send_eol();
- return;
}
static void
@@ -377,7 +364,6 @@ static void inputfifo_send_frame(
}
}
inputfifo_end_frame(marker_cycles);
- return;
}
static enum inputfifo_mipi_data_type inputfifo_determine_type(
@@ -453,7 +439,6 @@ void ia_css_inputfifo_start_frame(
s2mi->streaming = true;
inputfifo_start_frame(ch_id, s2mi->fmt_type);
- return;
}
void ia_css_inputfifo_send_line(
@@ -516,5 +501,4 @@ void ia_css_inputfifo_end_frame(
inputfifo_end_frame(s2mi->marker_cycles);
s2mi->streaming = false;
- return;
}
--
2.53.0
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH v3 03/28] media: staging: atomisp: Remove unnecessary return statement in bufq.c
2026-03-10 21:39 ` [PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions Tomasz Unger
2026-03-10 21:39 ` [PATCH v3 01/28] media: staging: atomisp: Remove unnecessary return statement in void function Tomasz Unger
2026-03-10 21:39 ` [PATCH v3 02/28] media: staging: atomisp: Remove unnecessary return statements in inputfifo.c Tomasz Unger
@ 2026-03-10 21:39 ` Tomasz Unger
2026-03-10 21:39 ` [PATCH v3 04/28] media: staging: atomisp: Remove unnecessary return statement in ifmtr.c Tomasz Unger
` (6 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: Tomasz Unger @ 2026-03-10 21:39 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman
Cc: linux-media, linux-kernel, linux-staging, Tomasz Unger
Remove redundant 'return;' statement at the end of void function
map_buffer_type_to_queue_id(). Void functions do not need an explicit
return statement at the end.
Found with checkpatch.pl --strict.
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
drivers/staging/media/atomisp/pci/runtime/bufq/src/bufq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/runtime/bufq/src/bufq.c b/drivers/staging/media/atomisp/pci/runtime/bufq/src/bufq.c
index 0f0d16f4ce7c..51f7c9d6f378 100644
--- a/drivers/staging/media/atomisp/pci/runtime/bufq/src/bufq.c
+++ b/drivers/staging/media/atomisp/pci/runtime/bufq/src/bufq.c
@@ -176,7 +176,6 @@ static void map_buffer_type_to_queue_id(
}
assert(i != SH_CSS_MAX_NUM_QUEUES);
- return;
}
static void unmap_buffer_type_to_queue_id(
--
2.53.0
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH v3 04/28] media: staging: atomisp: Remove unnecessary return statement in ifmtr.c
2026-03-10 21:39 ` [PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions Tomasz Unger
` (2 preceding siblings ...)
2026-03-10 21:39 ` [PATCH v3 03/28] media: staging: atomisp: Remove unnecessary return statement in bufq.c Tomasz Unger
@ 2026-03-10 21:39 ` Tomasz Unger
2026-03-11 6:53 ` Dan Carpenter
2026-03-10 21:39 ` [PATCH v3 05/28] media: staging: atomisp: Remove unnecessary return statements in frame.c Tomasz Unger
` (5 subsequent siblings)
9 siblings, 1 reply; 16+ messages in thread
From: Tomasz Unger @ 2026-03-10 21:39 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman
Cc: linux-media, linux-kernel, linux-staging, Tomasz Unger
Remove redundant 'return;' statement at the end of void function
ifmtr_set_if_blocking_mode(). Void functions do not need an explicit
return statement at the end.
Found with checkpatch.pl --strict.
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c b/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c
index 50b0b31d734a..31dd3f99e28e 100644
--- a/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c
+++ b/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c
@@ -472,7 +472,6 @@ static void ifmtr_set_if_blocking_mode(
}
}
- return;
}
static int ifmtr_start_column(
--
2.53.0
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH v3 04/28] media: staging: atomisp: Remove unnecessary return statement in ifmtr.c
2026-03-10 21:39 ` [PATCH v3 04/28] media: staging: atomisp: Remove unnecessary return statement in ifmtr.c Tomasz Unger
@ 2026-03-11 6:53 ` Dan Carpenter
0 siblings, 0 replies; 16+ messages in thread
From: Dan Carpenter @ 2026-03-11 6:53 UTC (permalink / raw)
To: Tomasz Unger
Cc: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman, linux-media, linux-kernel,
linux-staging
On Tue, Mar 10, 2026 at 10:39:15PM +0100, Tomasz Unger wrote:
> Remove redundant 'return;' statement at the end of void function
> ifmtr_set_if_blocking_mode(). Void functions do not need an explicit
> return statement at the end.
>
> Found with checkpatch.pl --strict.
>
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
> drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c b/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c
> index 50b0b31d734a..31dd3f99e28e 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c
> @@ -472,7 +472,6 @@ static void ifmtr_set_if_blocking_mode(
> }
> }
>
> - return;
Delete the blank line as well.
regards,
dan carpenter
> }
>
> static int ifmtr_start_column(
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v3 05/28] media: staging: atomisp: Remove unnecessary return statements in frame.c
2026-03-10 21:39 ` [PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions Tomasz Unger
` (3 preceding siblings ...)
2026-03-10 21:39 ` [PATCH v3 04/28] media: staging: atomisp: Remove unnecessary return statement in ifmtr.c Tomasz Unger
@ 2026-03-10 21:39 ` Tomasz Unger
2026-03-10 21:39 ` [PATCH v3 06/28] media: staging: atomisp: Remove unnecessary return statements in rx.c Tomasz Unger
` (4 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: Tomasz Unger @ 2026-03-10 21:39 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman
Cc: linux-media, linux-kernel, linux-staging, Tomasz Unger
Remove redundant 'return;' statements at the end of void functions
in frame.c. Void functions do not need an explicit return
statement at the end.
Found with checkpatch.pl --strict.
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c b/drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c
index 8614efc28b19..ae952df03cc6 100644
--- a/drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c
+++ b/drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c
@@ -525,7 +525,6 @@ static void frame_init_nv_planes(struct ia_css_frame *frame,
frame_init_plane(&frame->planes.nv.y, y_width, y_stride, y_height, 0);
frame_init_plane(&frame->planes.nv.uv, uv_width,
uv_stride, uv_height, y_bytes);
- return;
}
static void frame_init_yuv_planes(struct ia_css_frame *frame,
@@ -558,7 +557,6 @@ static void frame_init_yuv_planes(struct ia_css_frame *frame,
frame_init_plane(&frame->planes.yuv.v, uv_width, uv_stride,
uv_height, y_bytes + uv_bytes);
}
- return;
}
static void frame_init_rgb_planes(struct ia_css_frame *frame,
@@ -575,7 +573,6 @@ static void frame_init_rgb_planes(struct ia_css_frame *frame,
width, stride, height, 1 * bytes);
frame_init_plane(&frame->planes.planar_rgb.b,
width, stride, height, 2 * bytes);
- return;
}
static void frame_init_qplane6_planes(struct ia_css_frame *frame)
@@ -599,7 +596,6 @@ static void frame_init_qplane6_planes(struct ia_css_frame *frame)
width, stride, height, 4 * bytes);
frame_init_plane(&frame->planes.plane6.b_at_r,
width, stride, height, 5 * bytes);
- return;
}
static int frame_allocate_buffer_data(struct ia_css_frame *frame)
--
2.53.0
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH v3 06/28] media: staging: atomisp: Remove unnecessary return statements in rx.c
2026-03-10 21:39 ` [PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions Tomasz Unger
` (4 preceding siblings ...)
2026-03-10 21:39 ` [PATCH v3 05/28] media: staging: atomisp: Remove unnecessary return statements in frame.c Tomasz Unger
@ 2026-03-10 21:39 ` Tomasz Unger
2026-03-11 6:54 ` Dan Carpenter
2026-03-10 21:39 ` [PATCH v3 07/28] media: staging: atomisp: Remove unnecessary return statement in binary.c Tomasz Unger
` (3 subsequent siblings)
9 siblings, 1 reply; 16+ messages in thread
From: Tomasz Unger @ 2026-03-10 21:39 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman
Cc: linux-media, linux-kernel, linux-staging, Tomasz Unger
Remove redundant 'return;' statements at the end of void functions
in rx.c. Void functions do not need an explicit return
statement at the end.
Found with checkpatch.pl --strict.
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c b/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c
index 9cfb8bc97e24..bf9be11335d4 100644
--- a/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c
+++ b/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c
@@ -44,7 +44,6 @@ void ia_css_isys_rx_enable_all_interrupts(enum mipi_port_id port)
*/
ia_css_irq_enable(IA_CSS_IRQ_INFO_CSS_RECEIVER_ERROR, true);
- return;
}
/* This function converts between the enum used on the CSS API and the
@@ -197,7 +196,6 @@ void ia_css_isys_rx_clear_irq_info(enum mipi_port_id port,
port,
_HRT_CSS_RECEIVER_IRQ_ENABLE_REG_IDX, bits);
- return;
}
static int ia_css_isys_2400_set_fmt_type(enum atomisp_input_format input_format,
@@ -638,7 +636,6 @@ void ia_css_isys_rx_configure(const rx_cfg_t *config,
*/
input_system_reg_store(INPUT_SYSTEM0_ID, 0x207, 1);
- return;
}
void ia_css_isys_rx_disable(void)
@@ -650,5 +647,4 @@ void ia_css_isys_rx_disable(void)
_HRT_CSS_RECEIVER_DEVICE_READY_REG_IDX,
false);
}
- return;
}
--
2.53.0
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH v3 06/28] media: staging: atomisp: Remove unnecessary return statements in rx.c
2026-03-10 21:39 ` [PATCH v3 06/28] media: staging: atomisp: Remove unnecessary return statements in rx.c Tomasz Unger
@ 2026-03-11 6:54 ` Dan Carpenter
0 siblings, 0 replies; 16+ messages in thread
From: Dan Carpenter @ 2026-03-11 6:54 UTC (permalink / raw)
To: Tomasz Unger
Cc: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman, linux-media, linux-kernel,
linux-staging
On Tue, Mar 10, 2026 at 10:39:17PM +0100, Tomasz Unger wrote:
> Remove redundant 'return;' statements at the end of void functions
> in rx.c. Void functions do not need an explicit return
> statement at the end.
>
> Found with checkpatch.pl --strict.
>
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
> drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c b/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c
> index 9cfb8bc97e24..bf9be11335d4 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c
> @@ -44,7 +44,6 @@ void ia_css_isys_rx_enable_all_interrupts(enum mipi_port_id port)
> */
> ia_css_irq_enable(IA_CSS_IRQ_INFO_CSS_RECEIVER_ERROR, true);
>
> - return;
Delete the blank line.
> }
>
> /* This function converts between the enum used on the CSS API and the
> @@ -197,7 +196,6 @@ void ia_css_isys_rx_clear_irq_info(enum mipi_port_id port,
> port,
> _HRT_CSS_RECEIVER_IRQ_ENABLE_REG_IDX, bits);
>
> - return;
Same.
> }
>
> static int ia_css_isys_2400_set_fmt_type(enum atomisp_input_format input_format,
> @@ -638,7 +636,6 @@ void ia_css_isys_rx_configure(const rx_cfg_t *config,
> */
> input_system_reg_store(INPUT_SYSTEM0_ID, 0x207, 1);
>
> - return;
Same.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v3 07/28] media: staging: atomisp: Remove unnecessary return statement in binary.c
2026-03-10 21:39 ` [PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions Tomasz Unger
` (5 preceding siblings ...)
2026-03-10 21:39 ` [PATCH v3 06/28] media: staging: atomisp: Remove unnecessary return statements in rx.c Tomasz Unger
@ 2026-03-10 21:39 ` Tomasz Unger
2026-03-10 21:39 ` [PATCH v3 08/28] media: staging: atomisp: Remove unnecessary return statements in ia_css_debug.c Tomasz Unger
` (2 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: Tomasz Unger @ 2026-03-10 21:39 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman
Cc: linux-media, linux-kernel, linux-staging, Tomasz Unger
Remove redundant 'return;' statement at the end of void function
ia_css_binary_dvs_stat_grid_info(). Void functions do not need an
explicit return statement at the end.
Found with checkpatch.pl --strict.
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
index af93ca96747c..c3645fc074e4 100644
--- a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
+++ b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
@@ -344,7 +344,6 @@ ia_css_binary_dvs_stat_grid_info(
{
(void)pipe;
sh_css_binary_common_grid_info(binary, info);
- return;
}
int
--
2.53.0
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH v3 08/28] media: staging: atomisp: Remove unnecessary return statements in ia_css_debug.c
2026-03-10 21:39 ` [PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions Tomasz Unger
` (6 preceding siblings ...)
2026-03-10 21:39 ` [PATCH v3 07/28] media: staging: atomisp: Remove unnecessary return statement in binary.c Tomasz Unger
@ 2026-03-10 21:39 ` Tomasz Unger
2026-03-11 6:56 ` Dan Carpenter
2026-03-10 21:39 ` [PATCH v3 09/28] media: staging: atomisp: Remove unnecessary return statement in mmu_public.h Tomasz Unger
2026-03-10 22:46 ` [PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions Andy Shevchenko
9 siblings, 1 reply; 16+ messages in thread
From: Tomasz Unger @ 2026-03-10 21:39 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman
Cc: linux-media, linux-kernel, linux-staging, Tomasz Unger
Remove redundant 'return;' statements at the end of void functions
in ia_css_debug.c. Void functions do not need an explicit return
statement at the end.
Found with checkpatch.pl --strict.
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
.../staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c b/drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c
index b411ca2f415e..2e0a13938d89 100644
--- a/drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c
+++ b/drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c
@@ -136,7 +136,6 @@ void ia_css_debug_dtrace(unsigned int level, const char *fmt, ...)
void ia_css_debug_set_dtrace_level(const unsigned int trace_level)
{
dbg_level = trace_level;
- return;
}
unsigned int ia_css_debug_get_dtrace_level(void)
@@ -315,7 +314,6 @@ static void debug_print_fifo_channel_state(const fifo_channel_state_t *state,
state->fifo_valid);
ia_css_debug_dtrace(2, "\t%-32s: %d\n", "sink accept",
state->sink_accept);
- return;
}
void ia_css_debug_dump_pif_a_isp_fifo_state(void)
@@ -364,7 +362,6 @@ void ia_css_debug_dump_all_fifo_state(void)
for (i = 0; i < N_FIFO_CHANNEL; i++)
debug_print_fifo_channel_state(&state.fifo_channels[i],
"squepfstqkt");
- return;
}
static void debug_binary_info_print(const struct ia_css_binary_xinfo *info)
@@ -386,7 +383,6 @@ static void debug_binary_info_print(const struct ia_css_binary_xinfo *info)
ia_css_debug_dtrace(2, "enable_uds = %d\n", info->sp.enable.uds);
ia_css_debug_dtrace(2, "enable ds = %d\n", info->sp.enable.ds);
ia_css_debug_dtrace(2, "s3atbl_use_dmem = %d\n", info->sp.s3a.s3atbl_use_dmem);
- return;
}
void ia_css_debug_binary_print(const struct ia_css_binary *bi)
@@ -441,7 +437,6 @@ void ia_css_debug_binary_print(const struct ia_css_binary *bi)
bi->sctbl_width_per_color);
ia_css_debug_dtrace(2, "s3atbl_width = %d\n", bi->s3atbl_width);
ia_css_debug_dtrace(2, "s3atbl_height = %d\n", bi->s3atbl_height);
- return;
}
void ia_css_debug_frame_print(const struct ia_css_frame *frame,
@@ -526,7 +521,6 @@ void ia_css_debug_frame_print(const struct ia_css_frame *frame,
ia_css_debug_dtrace(2, " unknown frame type\n");
break;
}
- return;
}
#if SP_DEBUG != SP_DEBUG_NONE
@@ -809,7 +803,6 @@ void ia_css_debug_print_sp_debug_state(const struct sh_css_sp_debug_state
#if SP_DEBUG != SP_DEBUG_NONE
- return;
}
#endif
@@ -823,7 +816,6 @@ void ia_css_debug_dump_sp_sw_debug_info(void)
#endif
ia_css_bufq_dump_queue_info();
ia_css_pipeline_dump_thread_map_info();
- return;
}
/* this function is for debug use, it can make SP go to sleep
--
2.53.0
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH v3 08/28] media: staging: atomisp: Remove unnecessary return statements in ia_css_debug.c
2026-03-10 21:39 ` [PATCH v3 08/28] media: staging: atomisp: Remove unnecessary return statements in ia_css_debug.c Tomasz Unger
@ 2026-03-11 6:56 ` Dan Carpenter
0 siblings, 0 replies; 16+ messages in thread
From: Dan Carpenter @ 2026-03-11 6:56 UTC (permalink / raw)
To: Tomasz Unger
Cc: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman, linux-media, linux-kernel,
linux-staging
On Tue, Mar 10, 2026 at 10:39:19PM +0100, Tomasz Unger wrote:
> @@ -809,7 +803,6 @@ void ia_css_debug_print_sp_debug_state(const struct sh_css_sp_debug_state
>
> #if SP_DEBUG != SP_DEBUG_NONE
>
> - return;
> }
> #endif
>
After you write your patch, then re-run checkpatch.pl -f on the file and
it will catch these extra blank lines.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v3 09/28] media: staging: atomisp: Remove unnecessary return statement in mmu_public.h
2026-03-10 21:39 ` [PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions Tomasz Unger
` (7 preceding siblings ...)
2026-03-10 21:39 ` [PATCH v3 08/28] media: staging: atomisp: Remove unnecessary return statements in ia_css_debug.c Tomasz Unger
@ 2026-03-10 21:39 ` Tomasz Unger
2026-03-10 22:46 ` [PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions Andy Shevchenko
9 siblings, 0 replies; 16+ messages in thread
From: Tomasz Unger @ 2026-03-10 21:39 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman
Cc: linux-media, linux-kernel, linux-staging, Tomasz Unger
Remove redundant 'return;' statement at the end of void function
mmu_reg_store(). Void functions do not need an explicit return
statement at the end.
Found with checkpatch.pl --strict.
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mmu_public.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mmu_public.h b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mmu_public.h
index 1a435a348318..2fc137ef46da 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mmu_public.h
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/mmu_public.h
@@ -63,7 +63,6 @@ static inline void mmu_reg_store(
assert(ID < N_MMU_ID);
assert(MMU_BASE[ID] != (hrt_address) - 1);
ia_css_device_store_uint32(MMU_BASE[ID] + reg * sizeof(hrt_data), value);
- return;
}
/*! Read from a control register of MMU[ID]
--
2.53.0
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions
2026-03-10 21:39 ` [PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions Tomasz Unger
` (8 preceding siblings ...)
2026-03-10 21:39 ` [PATCH v3 09/28] media: staging: atomisp: Remove unnecessary return statement in mmu_public.h Tomasz Unger
@ 2026-03-10 22:46 ` Andy Shevchenko
9 siblings, 0 replies; 16+ messages in thread
From: Andy Shevchenko @ 2026-03-10 22:46 UTC (permalink / raw)
To: Tomasz Unger
Cc: Andy Shevchenko, Hans de Goede, Mauro Carvalho Chehab,
Sakari Ailus, Greg Kroah-Hartman, linux-media, linux-kernel,
linux-staging
On Tue, Mar 10, 2026 at 10:39:11PM +0100, Tomasz Unger wrote:
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
> Changes in v3:
> - Extended cleanup to all 27 files in the driver containing redundant
> 'return;' statements at the end of void functions (as suggested by
> Andy Shevchenko): inputfifo.c, bufq.c, ifmtr.c, frame.c, rx.c,
> binary.c, ia_css_debug.c, mmu_public.h,
> isp2400_input_system_private.h, hmm_bo.c, sh_css.c, sp_private.h,
> fifo_monitor_private.h, isp.c, input_formatter_private.h, irq.c,
> mmu.c, fifo_monitor.c, gp_device.c, gdc.c, event_fifo_private.h,
> isp_private.h, input_formatter.c, irq_private.h, gpio_private.h,
> gp_device_private.h, atomisp_cmd.c
> - Each removed 'return;' was verified to be at the end of a void function
> - Compiled successfully: make M=drivers/staging/media/atomisp/
> - Module loaded successfully in QEMU with Linux 7.0-rc3
> - Link to v2: https://lore.kernel.org/r/20260310-atomisp-remove-void-return-v2b-v2-1-b0e73f498e25@yahoo.pl
You sent the series 3 times and all of the times it's not sent in full.
Besides that it must not be split by file! This kind of change is okay
to have in one patch.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 16+ messages in thread