* [PATCH] Documentation: ACPI: EINJ: Update stale driver source reference
@ 2026-09-02 11:49 Prabhakar Pujeri
2026-09-09 15:54 ` Rafael J. Wysocki (Intel)
0 siblings, 1 reply; 2+ messages in thread
From: Prabhakar Pujeri @ 2026-09-02 11:49 UTC (permalink / raw)
To: Rafael J . Wysocki; +Cc: Len Brown, linux-acpi, linux-kernel, Prabhakar Pujeri
The EINJ implementation was split when CXL protocol error injection
support landed: einj-core.c holds the core logic, einj-cxl.c the
CXL-specific part, and apei-internal.h the shared plumbing. The old
drivers/acpi/apei/einj.c does not exist anymore, so the documentation
points readers at a nonexistent file.
Point them at the actual files instead.
Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
---
Documentation/firmware-guide/acpi/apei/einj.rst | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/firmware-guide/acpi/apei/einj.rst b/Documentation/firmware-guide/acpi/apei/einj.rst
index 7d8435d35..70fa59bd9 100644
--- a/Documentation/firmware-guide/acpi/apei/einj.rst
+++ b/Documentation/firmware-guide/acpi/apei/einj.rst
@@ -180,8 +180,10 @@ function are specified using param1::
| segment | bus | device | function | reserved |
+-------------------------------------------------+
-Anyway, you get the idea, if there's doubt just take a look at the code
-in drivers/acpi/apei/einj.c.
+Anyway, you get the idea, if there's doubt just take a look at the code:
+drivers/acpi/apei/einj-core.c holds the core logic, while CXL-specific
+handling lives in drivers/acpi/apei/einj-cxl.c and the shared plumbing
+in drivers/acpi/apei/apei-internal.h.
An ACPI 5.0 BIOS may also allow vendor-specific errors to be injected.
In this case a file named vendor will contain identifying information
base-commit: 89a312991dc6e638a36adc43ccb91dbc25504c04
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Documentation: ACPI: EINJ: Update stale driver source reference
2026-09-02 11:49 [PATCH] Documentation: ACPI: EINJ: Update stale driver source reference Prabhakar Pujeri
@ 2026-09-09 15:54 ` Rafael J. Wysocki (Intel)
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki (Intel) @ 2026-09-09 15:54 UTC (permalink / raw)
To: Prabhakar Pujeri; +Cc: Rafael J . Wysocki, Len Brown, linux-acpi, linux-kernel
On Wed, Sep 2, 2026 at 1:49 PM Prabhakar Pujeri
<prabhakar.pujeri@dell.com> wrote:
>
> The EINJ implementation was split when CXL protocol error injection
> support landed: einj-core.c holds the core logic, einj-cxl.c the
> CXL-specific part, and apei-internal.h the shared plumbing. The old
> drivers/acpi/apei/einj.c does not exist anymore, so the documentation
> points readers at a nonexistent file.
>
> Point them at the actual files instead.
>
> Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
> ---
> Documentation/firmware-guide/acpi/apei/einj.rst | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/firmware-guide/acpi/apei/einj.rst b/Documentation/firmware-guide/acpi/apei/einj.rst
> index 7d8435d35..70fa59bd9 100644
> --- a/Documentation/firmware-guide/acpi/apei/einj.rst
> +++ b/Documentation/firmware-guide/acpi/apei/einj.rst
> @@ -180,8 +180,10 @@ function are specified using param1::
> | segment | bus | device | function | reserved |
> +-------------------------------------------------+
>
> -Anyway, you get the idea, if there's doubt just take a look at the code
> -in drivers/acpi/apei/einj.c.
> +Anyway, you get the idea, if there's doubt just take a look at the code:
> +drivers/acpi/apei/einj-core.c holds the core logic, while CXL-specific
> +handling lives in drivers/acpi/apei/einj-cxl.c and the shared plumbing
> +in drivers/acpi/apei/apei-internal.h.
>
> An ACPI 5.0 BIOS may also allow vendor-specific errors to be injected.
> In this case a file named vendor will contain identifying information
>
> base-commit: 89a312991dc6e638a36adc43ccb91dbc25504c04
> --
Applied as 7.4 material, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-09 15:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-02 11:49 [PATCH] Documentation: ACPI: EINJ: Update stale driver source reference Prabhakar Pujeri
2026-09-09 15:54 ` Rafael J. Wysocki (Intel)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®