* [PATCH] dt-bindings: arm: Fix CoreSight CTI Kconfig symbol
@ 2026-08-22 8:19 Karl Mehltretter
2026-09-16 19:57 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Karl Mehltretter @ 2026-08-22 8:19 UTC (permalink / raw)
To: Suzuki K Poulose
Cc: Karl Mehltretter, Mike Leach, James Clark, Leo Yan, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, coresight, linux-arm-kernel,
devicetree, linux-kernel
The option exposing CoreSight CTI integration registers is
CONFIG_CORESIGHT_CTI_INTEGRATION_REGS, not
CONFIG_CORESIGHT_CTI_INTEGRATION_TEST.
Fixes: b39b46fb9c6a ("dt-bindings: arm: Adds CoreSight CTI hardware definitions")
Assisted-by: Codex:gpt-5.6-sol
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
index 949444aba1f8b..345e93ca39f96 100644
--- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
+++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
@@ -43,7 +43,7 @@ description: |
connection. Any user / client application will require additional information
on the connections between the CTI and other components for correct operation.
This information might be found by enabling the Integration Test registers in
- the driver (set CONFIG_CORESIGHT_CTI_INTEGRATION_TEST in Kernel
+ the driver (set CONFIG_CORESIGHT_CTI_INTEGRATION_REGS in Kernel
configuration). These registers may be used to explore the trigger connections
between CTI and other CoreSight components.
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: arm: Fix CoreSight CTI Kconfig symbol
2026-08-22 8:19 [PATCH] dt-bindings: arm: Fix CoreSight CTI Kconfig symbol Karl Mehltretter
@ 2026-09-16 19:57 ` Rob Herring
2026-09-23 10:34 ` Mike Leach
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2026-09-16 19:57 UTC (permalink / raw)
To: Karl Mehltretter
Cc: Suzuki K Poulose, Mike Leach, James Clark, Leo Yan,
Krzysztof Kozlowski, Conor Dooley, coresight, linux-arm-kernel,
devicetree, linux-kernel
On Sat, Aug 22, 2026 at 10:19:12AM +0200, Karl Mehltretter wrote:
> The option exposing CoreSight CTI integration registers is
> CONFIG_CORESIGHT_CTI_INTEGRATION_REGS, not
> CONFIG_CORESIGHT_CTI_INTEGRATION_TEST.
DT bindings should not be referring to kernel kconfig symbols (or
anything else in the kernel) in the first place.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: arm: Fix CoreSight CTI Kconfig symbol
2026-09-16 19:57 ` Rob Herring
@ 2026-09-23 10:34 ` Mike Leach
0 siblings, 0 replies; 3+ messages in thread
From: Mike Leach @ 2026-09-23 10:34 UTC (permalink / raw)
To: Rob Herring, Karl Mehltretter
Cc: Suzuki K Poulose, James Clark, Leo Yan, Krzysztof Kozlowski,
Conor Dooley, coresight, linux-arm-kernel, devicetree,
linux-kernel, nd
On 9/16/26 20:57, Rob Herring wrote:
> On Sat, Aug 22, 2026 at 10:19:12AM +0200, Karl Mehltretter wrote:
>> The option exposing CoreSight CTI integration registers is
>> CONFIG_CORESIGHT_CTI_INTEGRATION_REGS, not
>> CONFIG_CORESIGHT_CTI_INTEGRATION_TEST.
>
> DT bindings should not be referring to kernel kconfig symbols (or
> anything else in the kernel) in the first place.
>
Agreed - the comment in general is correct but the last sentence in the
paragraph should drop the config reference. e.g.
"This information might be found by using the CTI Integration Test
registers to explore the trigger connections between CTI and other
CoreSight components."
The coresight/KConfig file itself adequately documents adding this
support and the perils therein.
Mike
> Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-23 10:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-22 8:19 [PATCH] dt-bindings: arm: Fix CoreSight CTI Kconfig symbol Karl Mehltretter
2026-09-16 19:57 ` Rob Herring
2026-09-23 10:34 ` Mike Leach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®