mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] of: unittest: Fix np reference leak in of_unittest_dynamic()
@ 2026-09-17 12:54 Wentao Liang
  0 siblings, 0 replies; only message in thread
From: Wentao Liang @ 2026-09-17 12:54 UTC (permalink / raw)
  To: devicetree
  Cc: grant.likely, linux-kernel, robh, saravanak, Wentao Liang, stable

The node obtained with of_find_node_by_path() is never released, both
on the early return after a failed allocation and on the normal return
path. Add the missing of_node_put() calls.

Fixes: 7e66c5c74f73 ("of/selftest: Add self tests for manipulation of properties")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/of/unittest.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 5c90be158dd5..316f082c430d 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -200,6 +200,7 @@ static void __init of_unittest_dynamic(void)
 	prop = kzalloc_objs(*prop, 4);
 	if (!prop) {
 		unittest(0, "kzalloc() failed\n");
+		of_node_put(np);
 		return;
 	}
 
@@ -244,6 +245,8 @@ static void __init of_unittest_dynamic(void)
 	if (prop->value)
 		unittest(of_add_property(np, prop) == 0,
 			 "Adding a large property should have passed\n");
+
+	of_node_put(np);
 }
 
 static int __init of_unittest_check_node_linkage(struct device_node *np)
-- 
2.34.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-09-17 12:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-17 12:54 [PATCH] of: unittest: Fix np reference leak in of_unittest_dynamic() Wentao Liang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®