* [PATCH 1/2] arm64: dts: mediatek: mt7988a-bpi-r4pro: add names for i2c-to-gpio chip
2026-09-18 14:38 [PATCH 0/2] Add gpio labels for R4Pro Frank Wunderlich
@ 2026-09-18 14:38 ` Frank Wunderlich
2026-09-30 13:31 ` Linus Walleij
2026-09-18 14:38 ` [PATCH 2/2] arm64: dts: mediatek: mt7988a-bpi-r4pro: label gpio-hogs Frank Wunderlich
2026-09-21 10:22 ` [PATCH 0/2] Add gpio labels for R4Pro AngeloGioacchino Del Regno
2 siblings, 1 reply; 6+ messages in thread
From: Frank Wunderlich @ 2026-09-18 14:38 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: Frank Wunderlich, Bartosz Golaszewski, Mika Westerberg,
Linus Walleij, Andy Shevchenko, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek
From: Frank Wunderlich <frank-w@public-files.de>
Add line-names for the PCA9555 i2c to gpio expander to have more
information in debugfs.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
.../mediatek/mt7988a-bananapi-bpi-r4-pro.dtsi | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro.dtsi
index 1eeb72108b9b..f54787fbbc71 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro.dtsi
@@ -315,6 +315,24 @@ pca9555: i2c-gpio-expander@20 {
reg = <0x20>;
gpio-controller;
#gpio-cells = <2>;
+
+ gpio-line-names =
+ "BKEY-A-PDN", /* GPIO0 */
+ "BKEY-A-Vset", /* GPIO1 */
+ "BKEY-B-PDN", /* GPIO2 */
+ "BKEY-B-Vset", /* GPIO3 */
+ "BKEY-C-PDN", /* GPIO4 */
+ "BKEY-C-Vset", /* GPIO5 */
+ "SIM_SEL", /* GPIO6 */
+ "mPCIe_AB_Vset",/* GPIO7 */
+ "mPCIe_A_PDN", /* GPIO8 */
+ "mPCIe_B_PDN", /* GPIO9 */
+ "BKEY-A-RST", /* GPIO10 */
+ "VBUS_AB_PDN", /* GPIO11 */
+ "BKEY-B-RST", /* GPIO12 */
+ "BKEY-C-RST", /* GPIO13 */
+ "SYS_LEDB", /* GPIO14 */
+ "SYS_LEDR"; /* GPIO15 */
};
rtc@51 {
--
2.53.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] arm64: dts: mediatek: mt7988a-bpi-r4pro: add names for i2c-to-gpio chip
2026-09-18 14:38 ` [PATCH 1/2] arm64: dts: mediatek: mt7988a-bpi-r4pro: add names for i2c-to-gpio chip Frank Wunderlich
@ 2026-09-30 13:31 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2026-09-30 13:31 UTC (permalink / raw)
To: Frank Wunderlich
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Frank Wunderlich,
Bartosz Golaszewski, Mika Westerberg, Andy Shevchenko,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek
On Fri, Sep 18, 2026 at 4:39 PM Frank Wunderlich <linux@fw-web.de> wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Add line-names for the PCA9555 i2c to gpio expander to have more
> information in debugfs.
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: mediatek: mt7988a-bpi-r4pro: label gpio-hogs
2026-09-18 14:38 [PATCH 0/2] Add gpio labels for R4Pro Frank Wunderlich
2026-09-18 14:38 ` [PATCH 1/2] arm64: dts: mediatek: mt7988a-bpi-r4pro: add names for i2c-to-gpio chip Frank Wunderlich
@ 2026-09-18 14:38 ` Frank Wunderlich
2026-09-30 13:30 ` Linus Walleij
2026-09-21 10:22 ` [PATCH 0/2] Add gpio labels for R4Pro AngeloGioacchino Del Regno
2 siblings, 1 reply; 6+ messages in thread
From: Frank Wunderlich @ 2026-09-18 14:38 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: Frank Wunderlich, Bartosz Golaszewski, Mika Westerberg,
Linus Walleij, Andy Shevchenko, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek
From: Frank Wunderlich <frank-w@public-files.de>
GPIO hogs were tagged with name "?" in recent kernel versions (7.1+) due to
commit d1d564ec4992 ("gpio: move hogs into GPIO core").
7.0 showed the unit-name which behaviour is restored by patch [1], but
labeling the hog directly makes things easier.
gpiochip0: 84 GPIOs, parent: platform/1001f000.pinctrl, pinctrl_moore:
gpio-0 ( |tx-disable ) in lo
gpio-1 ( |mod-def0 ) in hi IRQ ACTIVE LOW
gpio-2 ( |los ) in hi IRQ
gpio-12 ( |cd ) in lo IRQ ACTIVE LOW
gpio-13 ( |reset ) in hi IRQ ACTIVE LOW
gpio-14 ( |WPS ) in hi IRQ ACTIVE LOW
gpio-21 ( |tx-disable ) in lo
gpio-63 ( |? ) out hi
gpio-69 ( |mod-def0 ) in hi IRQ ACTIVE LOW
gpio-70 ( |los ) in hi IRQ
gpio-79 ( |? ) out lo
gpio-82 ( |PHY reset ) out hi ACTIVE LOW
gpio-83 ( |PHY reset ) out hi ACTIVE LOW
after the change:
root@bpi-r4:~# cat /sys/kernel/debug/gpio
gpiochip0: 84 GPIOs, parent: platform/1001f000.pinctrl, pinctrl_moore:
gpio-0 ( |tx-disable ) in lo
gpio-1 ( |mod-def0 ) in hi IRQ ACTIVE LOW
gpio-2 ( |los ) in hi IRQ
gpio-12 ( |cd ) in lo IRQ ACTIVE LOW
gpio-13 ( |reset ) in hi IRQ ACTIVE LOW
gpio-14 ( |WPS ) in hi IRQ ACTIVE LOW
gpio-21 ( |tx-disable ) in lo
gpio-63 ( |pcie3-cn14-hog ) out hi
gpio-69 ( |mod-def0 ) in hi IRQ ACTIVE LOW
gpio-70 ( |los ) in hi IRQ
gpio-79 ( |pcie2-cn15-hog ) out lo
gpio-82 ( |PHY reset ) out hi ACTIVE LOW
gpio-83 ( |PHY reset ) out hi ACTIVE LOW
[1] https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git/commit/?id=d54a489c8c4b627775445d54a6cbd32f209bda8f
"gpiolib: use of_node_name if line-name is missing"
Fixes: d1d564ec4992 ("gpio: move hogs into GPIO core")
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
.../boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn13.dtso | 1 +
.../boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn14.dtso | 1 +
.../boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn15.dtso | 1 +
.../boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn18.dtso | 1 +
4 files changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn13.dtso b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn13.dtso
index 973b76ba0cbf..e9c322df15fc 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn13.dtso
+++ b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn13.dtso
@@ -16,5 +16,6 @@ / {
};
&{/soc/pinctrl@1001f000/pcie-2-hog} {
+ line-name = "pcie2-cn13-hog";
output-high;
};
diff --git a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn14.dtso b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn14.dtso
index 90b2a64459c3..9d8de737ca40 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn14.dtso
+++ b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn14.dtso
@@ -16,5 +16,6 @@ / {
};
&{/soc/pinctrl@1001f000/pcie-3-hog} {
+ line-name = "pcie3-cn14-hog";
output-high;
};
diff --git a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn15.dtso b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn15.dtso
index 9750916042de..57ee7dacdd78 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn15.dtso
+++ b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn15.dtso
@@ -16,5 +16,6 @@ / {
};
&{/soc/pinctrl@1001f000/pcie-2-hog} {
+ line-name = "pcie2-cn15-hog";
output-low;
};
diff --git a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn18.dtso b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn18.dtso
index 9830fb0fd97a..7830980ac95a 100644
--- a/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn18.dtso
+++ b/arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-pro-cn18.dtso
@@ -16,5 +16,6 @@ / {
};
&{/soc/pinctrl@1001f000/pcie-3-hog} {
+ line-name = "pcie3-cn18-hog";
output-low;
};
--
2.53.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] arm64: dts: mediatek: mt7988a-bpi-r4pro: label gpio-hogs
2026-09-18 14:38 ` [PATCH 2/2] arm64: dts: mediatek: mt7988a-bpi-r4pro: label gpio-hogs Frank Wunderlich
@ 2026-09-30 13:30 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2026-09-30 13:30 UTC (permalink / raw)
To: Frank Wunderlich
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Frank Wunderlich,
Bartosz Golaszewski, Mika Westerberg, Andy Shevchenko,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek
On Fri, Sep 18, 2026 at 4:39 PM Frank Wunderlich <linux@fw-web.de> wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> GPIO hogs were tagged with name "?" in recent kernel versions (7.1+) due to
> commit d1d564ec4992 ("gpio: move hogs into GPIO core").
>
> 7.0 showed the unit-name which behaviour is restored by patch [1], but
> labeling the hog directly makes things easier.
>
> gpiochip0: 84 GPIOs, parent: platform/1001f000.pinctrl, pinctrl_moore:
> gpio-0 ( |tx-disable ) in lo
> gpio-1 ( |mod-def0 ) in hi IRQ ACTIVE LOW
> gpio-2 ( |los ) in hi IRQ
> gpio-12 ( |cd ) in lo IRQ ACTIVE LOW
> gpio-13 ( |reset ) in hi IRQ ACTIVE LOW
> gpio-14 ( |WPS ) in hi IRQ ACTIVE LOW
> gpio-21 ( |tx-disable ) in lo
> gpio-63 ( |? ) out hi
> gpio-69 ( |mod-def0 ) in hi IRQ ACTIVE LOW
> gpio-70 ( |los ) in hi IRQ
> gpio-79 ( |? ) out lo
> gpio-82 ( |PHY reset ) out hi ACTIVE LOW
> gpio-83 ( |PHY reset ) out hi ACTIVE LOW
>
> after the change:
>
> root@bpi-r4:~# cat /sys/kernel/debug/gpio
> gpiochip0: 84 GPIOs, parent: platform/1001f000.pinctrl, pinctrl_moore:
> gpio-0 ( |tx-disable ) in lo
> gpio-1 ( |mod-def0 ) in hi IRQ ACTIVE LOW
> gpio-2 ( |los ) in hi IRQ
> gpio-12 ( |cd ) in lo IRQ ACTIVE LOW
> gpio-13 ( |reset ) in hi IRQ ACTIVE LOW
> gpio-14 ( |WPS ) in hi IRQ ACTIVE LOW
> gpio-21 ( |tx-disable ) in lo
> gpio-63 ( |pcie3-cn14-hog ) out hi
> gpio-69 ( |mod-def0 ) in hi IRQ ACTIVE LOW
> gpio-70 ( |los ) in hi IRQ
> gpio-79 ( |pcie2-cn15-hog ) out lo
> gpio-82 ( |PHY reset ) out hi ACTIVE LOW
> gpio-83 ( |PHY reset ) out hi ACTIVE LOW
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git/commit/?id=d54a489c8c4b627775445d54a6cbd32f209bda8f
> "gpiolib: use of_node_name if line-name is missing"
>
> Fixes: d1d564ec4992 ("gpio: move hogs into GPIO core")
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
It's always good to use line-names on boards for tinkering
makerspaces prototyping etc.
Reviewed-by: Linus Walleij <linusw@kernel.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Add gpio labels for R4Pro
2026-09-18 14:38 [PATCH 0/2] Add gpio labels for R4Pro Frank Wunderlich
2026-09-18 14:38 ` [PATCH 1/2] arm64: dts: mediatek: mt7988a-bpi-r4pro: add names for i2c-to-gpio chip Frank Wunderlich
2026-09-18 14:38 ` [PATCH 2/2] arm64: dts: mediatek: mt7988a-bpi-r4pro: label gpio-hogs Frank Wunderlich
@ 2026-09-21 10:22 ` AngeloGioacchino Del Regno
2 siblings, 0 replies; 6+ messages in thread
From: AngeloGioacchino Del Regno @ 2026-09-21 10:22 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Frank Wunderlich
Cc: Frank Wunderlich, Bartosz Golaszewski, Mika Westerberg,
Linus Walleij, Andy Shevchenko, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek
On Fri, 18 Sep 2026 16:38:41 +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> This Series adds line-names for i2c-gpio adapter and pcie hogs
> for easier debugging via /sys/kernel/debug/gpio.
>
> Frank Wunderlich (2):
> arm64: dts: mediatek: mt7988a-bpi-r4pro: add names for i2c-to-gpio
> chip
> arm64: dts: mediatek: mt7988a-bpi-r4pro: label gpio-hogs
>
> [...]
Applied to v7.3-next/dts64, thanks!
[1/2] arm64: dts: mediatek: mt7988a-bpi-r4pro: add names for i2c-to-gpio chip
commit: ee3f4a1785bd73a865a4aa5e1974c6079f96b2bc
[2/2] arm64: dts: mediatek: mt7988a-bpi-r4pro: label gpio-hogs
commit: bf89276b2db391cbb25d1a0e898280fe85b16fb5
Cheers,
Angelo
^ permalink raw reply [flat|nested] 6+ messages in thread