[PATCH] fs: remove unused vfs_empty_path()

[PATCH] fs: remove unused vfs_empty_path()

[Sang-Heon Jeon]

Since commit e896474fe485 ("getname_maybe_null() - the third variant of
pathname copy-in"), vfs_empty_path() has no callers.

So remove it.

No functional change.

Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
 include/linux/fs.h | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 05d05bb9c951..ef8eb5af06c5 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -3653,23 +3653,6 @@ extern int vfs_fadvise(struct file *file, loff_t offset, loff_t len,
 extern int generic_fadvise(struct file *file, loff_t offset, loff_t len,
 			   int advice);
 
-static inline bool vfs_empty_path(int dfd, const char __user *path)
-{
-	char c;
-
-	if (dfd < 0)
-		return false;
-
-	/* We now allow NULL to be used for empty path. */
-	if (!path)
-		return true;
-
-	if (unlikely(get_user(c, path)))
-		return false;
-
-	return !c;
-}
-
 int generic_atomic_write_valid(struct kiocb *iocb, struct iov_iter *iter);
 
 static inline bool extensible_ioctl_valid(unsigned int cmd_a,
-- 
2.43.0

Re: [PATCH] fs: remove unused vfs_empty_path()

[Jan Kara]

On Sat 19-09-26 01:51:03, Sang-Heon Jeon wrote:
> Since commit e896474fe485 ("getname_maybe_null() - the third variant of
> pathname copy-in"), vfs_empty_path() has no callers.
> 
> So remove it.
> 
> No functional change.
> 
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  include/linux/fs.h | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 05d05bb9c951..ef8eb5af06c5 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -3653,23 +3653,6 @@ extern int vfs_fadvise(struct file *file, loff_t offset, loff_t len,
>  extern int generic_fadvise(struct file *file, loff_t offset, loff_t len,
>  			   int advice);
>  
> -static inline bool vfs_empty_path(int dfd, const char __user *path)
> -{
> -	char c;
> -
> -	if (dfd < 0)
> -		return false;
> -
> -	/* We now allow NULL to be used for empty path. */
> -	if (!path)
> -		return true;
> -
> -	if (unlikely(get_user(c, path)))
> -		return false;
> -
> -	return !c;
> -}
> -
>  int generic_atomic_write_valid(struct kiocb *iocb, struct iov_iter *iter);
>  
>  static inline bool extensible_ioctl_valid(unsigned int cmd_a,
> -- 
> 2.43.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: [PATCH] fs: remove unused vfs_empty_path()

[Christian Brauner]

On Sat, 19 Sep 2026 01:51:03 +0900, Sang-Heon Jeon wrote:
> fs: remove unused vfs_empty_path()

Applied to the vfs-7.4.misc branch of the vfs/vfs.git tree.
Patches in the vfs-7.4.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-7.4.misc

[1/1] fs: remove unused vfs_empty_path()
      https://git.kernel.org/vfs/vfs/c/98abb2b35835