* [PATCH] media: rkvdec: Remove redundant dev_err()
@ 2026-09-19 9:34 Diederik de Haas
2026-09-29 20:28 ` Nicolas Dufresne
0 siblings, 1 reply; 2+ messages in thread
From: Diederik de Haas @ 2026-09-19 9:34 UTC (permalink / raw)
To: Detlev Casanova, Ezequiel Garcia, Mauro Carvalho Chehab, Heiko Stuebner
Cc: linux-media, linux-rockchip, linux-arm-kernel, linux-kernel,
Diederik de Haas
The devm_request_threaded_irq() function already logs detailed error
messages on failure automatically since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()")
So remove the now-redundant driver-specific dev_err() calls.
Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>
---
drivers/media/platform/rockchip/rkvdec/rkvdec.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.c b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
index 061281f903f3..13d13c041509 100644
--- a/drivers/media/platform/rockchip/rkvdec/rkvdec.c
+++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
@@ -1824,10 +1824,8 @@ static int rkvdec_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
rkvdec_irq_handler, IRQF_ONESHOT,
dev_name(&pdev->dev), rkvdec);
- if (ret) {
- dev_err(&pdev->dev, "Could not request vdec IRQ\n");
+ if (ret)
return ret;
- }
rkvdec->sram_pool = of_gen_pool_get(pdev->dev.of_node, "sram", 0);
if (!rkvdec->sram_pool && rkvdec->variant->num_rcb_sizes > 0)
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: rkvdec: Remove redundant dev_err()
2026-09-19 9:34 [PATCH] media: rkvdec: Remove redundant dev_err() Diederik de Haas
@ 2026-09-29 20:28 ` Nicolas Dufresne
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Dufresne @ 2026-09-29 20:28 UTC (permalink / raw)
To: Diederik de Haas, Detlev Casanova, Ezequiel Garcia,
Mauro Carvalho Chehab, Heiko Stuebner
Cc: linux-media, linux-rockchip, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1346 bytes --]
Le samedi 19 septembre 2026 à 11:34 +0200, Diederik de Haas a écrit :
> The devm_request_threaded_irq() function already logs detailed error
> messages on failure automatically since commit
> 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()")
> So remove the now-redundant driver-specific dev_err() calls.
>
> Signed-off-by: Diederik de Haas <diederik@cknow-tech.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
> drivers/media/platform/rockchip/rkvdec/rkvdec.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.c b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> index 061281f903f3..13d13c041509 100644
> --- a/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> +++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> @@ -1824,10 +1824,8 @@ static int rkvdec_probe(struct platform_device *pdev)
> ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> rkvdec_irq_handler, IRQF_ONESHOT,
> dev_name(&pdev->dev), rkvdec);
> - if (ret) {
> - dev_err(&pdev->dev, "Could not request vdec IRQ\n");
> + if (ret)
> return ret;
> - }
>
> rkvdec->sram_pool = of_gen_pool_get(pdev->dev.of_node, "sram", 0);
> if (!rkvdec->sram_pool && rkvdec->variant->num_rcb_sizes > 0)
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-29 20:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-19 9:34 [PATCH] media: rkvdec: Remove redundant dev_err() Diederik de Haas
2026-09-29 20:28 ` Nicolas Dufresne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®