mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suryansh Singh <technosfan14@gmail.com>
To: baoshuwen2013@outlook.com
Cc: emreleno@gmail.com, hansg@kernel.org, hello@kursatabayli.dev,
	ilpo.jarvinen@linux.intel.com, krishna.chomal108@gmail.com,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, radheykalra901@gmail.com,
	technosfan14@gmail.com
Subject: Re: [PATCH] platform/x86: hp-wmi: add support for OMEN 16-am2xxx boards
Date: Sun, 20 Sep 2026 12:06:31 +0530	[thread overview]
Message-ID: <20260920063631.142985-1-technosfan14@gmail.com> (raw)
In-Reply-To: <SI2PR04MB58957D08A31E56D73C751885A2862@SI2PR04MB5895.apcprd04.prod.outlook.com>

On Sat, Sep 19, 2026 at 09:24:25 +0800, Shuwen Bao wrote:
> Add 8F1C to the OMEN thermal profile board list. On this platform
> the EC firmware also arms its own thermal profile revert timer (EC
> offset 0x63, armed with 0x5a when performance is selected) and
> switches back to the balanced profile once it expires, so also add
> the board to omen_timed_thermal_profile_boards in order to have the
> driver clear the timer and set the NOTIMER|TURBO flags when
> switching to the performance profile. Testing further showed that
> this board uses v0 commands, so also add it to
> omen_thermal_profile_force_v0_boards.

Thanks for the patch.

It is slightly unusual to see a board ID ending up in all 3 arrays.
(I believe no other board is present in the base, force v0 and
timed thermal profile simultaneously.)

But, it has been explained well in the commit message and tested,
so it is completely plausible.

Oh, and since the first revision of this patch had a corrupted
patch file (stated by the maintainer), I did apply it to check,
and it works.

LGTM.

Reviewed-by: Suryansh Singh <technosfan14@gmail.com>

  reply	other threads:[~2026-09-20  6:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-19  1:24 [PATCH v2] " Shuwen Bao
2026-09-20  6:36 ` Suryansh Singh [this message]
2026-10-05 17:45 ` Ilpo Järvinen
2026-10-07  6:15   ` Shuwen Bao
2026-10-07 10:11     ` Ilpo Järvinen
2026-10-06  4:49 ` Krishna Chomal
  -- strict thread matches above, loose matches on Subject: below --
2026-08-29 11:27 [PATCH] " 保 舒文
2026-09-18 17:13 ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260920063631.142985-1-technosfan14@gmail.com \
    --to=technosfan14@gmail.com \
    --cc=baoshuwen2013@outlook.com \
    --cc=emreleno@gmail.com \
    --cc=hansg@kernel.org \
    --cc=hello@kursatabayli.dev \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=krishna.chomal108@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=radheykalra901@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®