mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krishna Chomal <krishna.chomal108@gmail.com>
To: Shuwen Bao <baoshuwen2013@outlook.com>
Cc: "Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Emre Cecanpunar" <emreleno@gmail.com>,
	"Suryansh Singh" <technosfan14@gmail.com>,
	"Radhey Kalra" <radheykalra901@gmail.com>,
	"Kürşat Abaylı" <hello@kursatabayli.dev>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: hp-wmi: add support for OMEN 16-am2xxx boards
Date: Tue, 6 Oct 2026 10:19:45 +0530	[thread overview]
Message-ID: <asR9Q8Xia4ijLvXM@archlinux> (raw)
In-Reply-To: <SI2PR04MB58957D08A31E56D73C751885A2862@SI2PR04MB5895.apcprd04.prod.outlook.com>

On Sat, Sep 19, 2026 at 09:24:25AM +0800, Shuwen Bao wrote:
>The HP HyperX OMEN 16-am2xxx (DMI board 8F1C, 26C1 platform cycle,
>Arrow Lake-HXR) is listed in the OMEN Command Center device
>capability table with DisplayName "HyperX OMEN 16" and the
>"PerformanceControl" feature, but is missing from the kernel's
>omen_thermal_profile_boards whitelist. The thermal profile path is
>therefore not enabled and the embedded controller keeps the CPU
>pinned at the default frequency cap while running Linux.
>
>Add 8F1C to the OMEN thermal profile board list. On this platform
>the EC firmware also arms its own thermal profile revert timer (EC
>offset 0x63, armed with 0x5a when performance is selected) and
>switches back to the balanced profile once it expires, so also add
>the board to omen_timed_thermal_profile_boards in order to have the
>driver clear the timer and set the NOTIMER|TURBO flags when
>switching to the performance profile. Testing further showed that
>this board uses v0 commands, so also add it to
>omen_thermal_profile_force_v0_boards.
>
>Tested on a HyperX OMEN 16-am2xxx: after loading the patched hp-wmi
>module the platform_profile interface is exposed, and switching to
>the performance profile raises the CPU from a ~2.9 GHz (P-core) /
>2.6 GHz (E-core) cap to ~4.8 GHz / ~4.3 GHz under a single-thread
>load. The EC then reports the performance profile (0x31) with the
>NOTIMER|TURBO flags set (0x62=0x06) and the revert timer cleared
>(0x63=0x00); a plain write of the profile without those flags
>instead arms the timer (0x63=0x5a) and the profile reverts to
>balanced when it expires.

Hi Shuwen Bao,

I was working a patch[1] involving omen_timed_thermal_profile_boards[]
and needed some diagostic info. Would you mind attaching the acpidump
for your board 8F1C?

Thanks!

[1]: https://lore.kernel.org/platform-driver-x86/asPy5Q5wNYaMzTqJ@archlinux/#m922ff6cf9a68285d2b0f64e578fd6d2d6fa573f4

>Signed-off-by: Shuwen Bao <baoshuwen2013@outlook.com>
>---
> drivers/platform/x86/hp/hp-wmi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
>index 615b4cf6fc45..f229da54366a 100644
>--- a/drivers/platform/x86/hp/hp-wmi.c
>+++ b/drivers/platform/x86/hp/hp-wmi.c
>@@ -211,6 +211,7 @@ static const char * const omen_thermal_profile_boards[] = {
> 	"8BAD",
> 	"8C58",
> 	"8E41",
>+	"8F1C",
> };
>
> /* DMI Board names of Omen laptops that are specifically set to be thermal
>@@ -220,6 +221,7 @@ static const char * const omen_thermal_profile_boards[] = {
> static const char * const omen_thermal_profile_force_v0_boards[] = {
> 	"8607",
> 	"8746", "8747", "8748", "8749", "874A",
>+	"8F1C",
> };
>
> /* DMI board names of Omen laptops that have a thermal profile timer which will
>@@ -229,6 +231,7 @@ static const char * const omen_thermal_profile_force_v0_boards[] = {
> static const char * const omen_timed_thermal_profile_boards[] = {
> 	"8A15", "8A42",
> 	"8BAD",
>+	"8F1C",
> };
>
> /* DMI Board names of Victus 16-d laptops */
>-- 
>2.53.0
>

      parent reply	other threads:[~2026-10-06  4:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-19  1:24 Shuwen Bao
2026-09-20  6:36 ` [PATCH] " Suryansh Singh
2026-10-05 17:45 ` [PATCH v2] " Ilpo Järvinen
2026-10-07  6:15   ` Shuwen Bao
2026-10-06  4:49 ` Krishna Chomal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=asR9Q8Xia4ijLvXM@archlinux \
    --to=krishna.chomal108@gmail.com \
    --cc=baoshuwen2013@outlook.com \
    --cc=emreleno@gmail.com \
    --cc=hansg@kernel.org \
    --cc=hello@kursatabayli.dev \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=radheykalra901@gmail.com \
    --cc=technosfan14@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®