[PATCH] counter: ti-eqep: Fix runtime PM error handling in probe

[PATCH] counter: ti-eqep: Fix runtime PM error handling in probe

[phucduc.bui]

From: bui duc phuc <phucduc.bui@gmail.com>

pm_runtime_get_sync() errors were not checked, and if
devm_clk_get_enabled() failed afterwards, the function returned without
calling pm_runtime_put_sync()/pm_runtime_disable(), leaking the runtime PM
usage count.

Switch to pm_runtime_resume_and_get() and add proper error unwinding via
goto labels so every failure path after pm_runtime_enable() is cleaned up
correctly.

Fixes: f213729f6796 ("counter: new TI eQEP driver")
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
 drivers/counter/ti-eqep.c | 27 +++++++++++++++++++--------
 1 file changed, 19 insertions(+), 8 deletions(-)

diff --git a/drivers/counter/ti-eqep.c b/drivers/counter/ti-eqep.c
index 0dda3f2b14c7..698a9920f20d 100644
--- a/drivers/counter/ti-eqep.c
+++ b/drivers/counter/ti-eqep.c
@@ -544,20 +544,31 @@ static int ti_eqep_probe(struct platform_device *pdev)
 	 * domain.
 	 */
 	pm_runtime_enable(dev);
-	pm_runtime_get_sync(dev);
+	err = pm_runtime_resume_and_get(dev);
+	if (err < 0) {
+		dev_err_probe(dev, err, "failed to enable runtime PM\n");
+		goto err_runtime_disable;
+	}
 
 	clk = devm_clk_get_enabled(dev, NULL);
-	if (IS_ERR(clk))
-		return dev_err_probe(dev, PTR_ERR(clk), "failed to enable clock\n");
+	if (IS_ERR(clk)) {
+		err = PTR_ERR(clk);
+		dev_err_probe(dev, err, "failed to enable clock\n");
+		goto err_runtime_put;
+	}
 
 	err = counter_add(counter);
-	if (err < 0) {
-		pm_runtime_put_sync(dev);
-		pm_runtime_disable(dev);
-		return err;
-	}
+	if (err < 0)
+		goto err_runtime_put;
 
 	return 0;
+
+err_runtime_put:
+	pm_runtime_put_sync(dev);
+err_runtime_disable:
+	pm_runtime_disable(dev);
+
+	return err;
 }
 
 static void ti_eqep_remove(struct platform_device *pdev)
-- 
2.43.0