Re: [PATCH] leds: netxbig: Fix platform device reference leak on successful probe

[Lee Jones <lee@kernel.org>]

On Thu, 17 Sep 2026, Wentao Liang wrote:

> of_find_device_by_node() returns the GPIO extension device with an
> elevated reference count.  The error paths release it through the
> put_device label, but the success path returns directly, so the
> reference is leaked whenever the LED driver probes successfully.
> 
> Let the success path fall through to the put_device label.
> 
> Fixes: 9af512e81964 ("leds: netxbig: Convert to use GPIO descriptors")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
>  drivers/leds/leds-netxbig.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c
> index 99df46f2d9f5..d79fee1d9143 100644
> --- a/drivers/leds/leds-netxbig.c
> +++ b/drivers/leds/leds-netxbig.c
> @@ -597,8 +597,7 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
>  	pdata->leds = leds;
>  	pdata->num_leds = num_leds;
>  
> -	return 0;
> -
> +	ret = 0;
>  put_device:
>  	put_device(gpio_ext_dev);
> 	return ret;

Or you could do a nicer clean-up by putting it after last use, then
remove all of the gotos?

-- 
Lee Jones