* [PATCH] leds: netxbig: Fix platform device reference leak on successful probe
@ 2026-09-17 9:36 Wentao Liang
2026-09-22 16:03 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Wentao Liang @ 2026-09-17 9:36 UTC (permalink / raw)
To: lee; +Cc: linusw, linux-kernel, linux-leds, pavel, Wentao Liang, stable
of_find_device_by_node() returns the GPIO extension device with an
elevated reference count. The error paths release it through the
put_device label, but the success path returns directly, so the
reference is leaked whenever the LED driver probes successfully.
Let the success path fall through to the put_device label.
Fixes: 9af512e81964 ("leds: netxbig: Convert to use GPIO descriptors")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/leds/leds-netxbig.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c
index 99df46f2d9f5..d79fee1d9143 100644
--- a/drivers/leds/leds-netxbig.c
+++ b/drivers/leds/leds-netxbig.c
@@ -597,8 +597,7 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
pdata->leds = leds;
pdata->num_leds = num_leds;
- return 0;
-
+ ret = 0;
put_device:
put_device(gpio_ext_dev);
return ret;
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: netxbig: Fix platform device reference leak on successful probe
2026-09-17 9:36 [PATCH] leds: netxbig: Fix platform device reference leak on successful probe Wentao Liang
@ 2026-09-22 16:03 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2026-09-22 16:03 UTC (permalink / raw)
To: Wentao Liang; +Cc: linusw, linux-kernel, linux-leds, pavel, stable
On Thu, 17 Sep 2026, Wentao Liang wrote:
> of_find_device_by_node() returns the GPIO extension device with an
> elevated reference count. The error paths release it through the
> put_device label, but the success path returns directly, so the
> reference is leaked whenever the LED driver probes successfully.
>
> Let the success path fall through to the put_device label.
>
> Fixes: 9af512e81964 ("leds: netxbig: Convert to use GPIO descriptors")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> drivers/leds/leds-netxbig.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c
> index 99df46f2d9f5..d79fee1d9143 100644
> --- a/drivers/leds/leds-netxbig.c
> +++ b/drivers/leds/leds-netxbig.c
> @@ -597,8 +597,7 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
> pdata->leds = leds;
> pdata->num_leds = num_leds;
>
> - return 0;
> -
> + ret = 0;
> put_device:
> put_device(gpio_ext_dev);
> return ret;
Or you could do a nicer clean-up by putting it after last use, then
remove all of the gotos?
--
Lee Jones
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-22 16:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-17 9:36 [PATCH] leds: netxbig: Fix platform device reference leak on successful probe Wentao Liang
2026-09-22 16:03 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®