[PATCH] ASoC: amd: acp: add EFI dependency for selecting TAS2783

[PATCH] ASoC: amd: acp: add EFI dependency for selecting TAS2783

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

The TAS2783 codec requires EFI support, so it cannot be selected
unless that is also enabled:

WARNING: unmet direct dependencies detected for SND_SOC_TAS2783_SDW
  Depends on [n]: SOUND [=m] && SND [=m] && SND_SOC [=m] && SOUNDWIRE [=m] && SND_SOC_SDCA [=m] && EFI [=n]
  Selected by [m]:
  - SND_SOC_AMD_LEGACY_SDW_MACH [=m] && SOUND [=m] && SND [=m] && SND_SOC [=m] && SND_SOC_AMD_ACP_COMMON [=m] && X86 [=y] && PCI [=y] && ACPI [=y] && SOUNDWIRE [=m]

Add this as a dependency for SND_SOC_AMD_LEGACY_SDW_MACH, assuming
that this is only needed on modern x86 machines that require EFI
support already. It would likely be possible to do something more
complex to still allow SND_SOC_AMD_LEGACY_SDW_MACH to be used without
TAS2783 when EFI is disabled, but I cannot see a usecase for that.

Fixes: 28114992dd2f ("ASoC: amd: acp: enable TAS2783 and add RT712-VB SoundWire machine")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 sound/soc/amd/acp/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/amd/acp/Kconfig b/sound/soc/amd/acp/Kconfig
index ed0f93a5a7e5..ab49712545b0 100644
--- a/sound/soc/amd/acp/Kconfig
+++ b/sound/soc/amd/acp/Kconfig
@@ -167,7 +167,7 @@ config SND_SOC_AMD_SOF_SDW_MACH
 
 config SND_SOC_AMD_LEGACY_SDW_MACH
 	tristate "AMD Legacy(No DSP) Soundwire Machine Driver Support"
-	depends on X86 && PCI && ACPI
+	depends on X86 && PCI && ACPI && EFI
 	depends on SOUNDWIRE
 	select SND_SOC_AMD_SDW_MACH_COMMON
 	select SND_SOC_SDW_UTILS
-- 
2.53.0

Re: [PATCH] ASoC: amd: acp: add EFI dependency for selecting TAS2783

[Mark Brown]

On Fri, 25 Sep 2026 15:11:27 +0200, Arnd Bergmann wrote:
> ASoC: amd: acp: add EFI dependency for selecting TAS2783

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.4

Thanks!

[1/1] ASoC: amd: acp: add EFI dependency for selecting TAS2783
      https://git.kernel.org/broonie/sound/c/4d2b92b82ee8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark