* [PATCH] ASoC: tegra: Fix ASRC Stream6 input threshold control
@ 2026-10-05 8:55 Sheetal
2026-10-05 15:24 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Sheetal @ 2026-10-05 8:55 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown
Cc: Jaroslav Kysela, Takashi Iwai, Thierry Reding, Jonathan Hunter,
Sameer Pujar, Kuninori Morimoto, Mohan Kumar, linux-sound,
linux-tegra, linux-kernel, Sheetal, Thierry Reding
The Stream6 Input Threshold control points at stream index 4, which is
already used by Stream5. The threshold get and put callbacks derive the
lane ID from the register offset, so the duplicate index makes Stream6
operate on lane 4 and leaves lane 5 inaccessible from userspace.
Use stream index 5 for Stream6.
Fixes: a2df8c2d5b36 ("ASoC: tegra: Add Tegra186 based ASRC driver")
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Sheetal <sheetal@nvidia.com>
---
Changes from RFC v1:
- Split out from the ASRC ratio-control RFC series because this is an
independent fix and should not be blocked by the ABI discussion.
sound/soc/tegra/tegra186_asrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/tegra/tegra186_asrc.c b/sound/soc/tegra/tegra186_asrc.c
index 7f360dfaf8b1..d8ae5d997615 100644
--- a/sound/soc/tegra/tegra186_asrc.c
+++ b/sound/soc/tegra/tegra186_asrc.c
@@ -828,7 +828,7 @@ static const struct snd_kcontrol_new tegra186_asrc_controls[] = {
tegra186_asrc_put_input_threshold),
SOC_SINGLE_EXT("Stream6 Input Threshold",
- ASRC_STREAM_REG(TEGRA186_ASRC_RX_THRESHOLD, 4), 0, 3, 0,
+ ASRC_STREAM_REG(TEGRA186_ASRC_RX_THRESHOLD, 5), 0, 3, 0,
tegra186_asrc_get_input_threshold,
tegra186_asrc_put_input_threshold),
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: tegra: Fix ASRC Stream6 input threshold control
2026-10-05 8:55 [PATCH] ASoC: tegra: Fix ASRC Stream6 input threshold control Sheetal
@ 2026-10-05 15:24 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2026-10-05 15:24 UTC (permalink / raw)
To: Liam Girdwood, Sheetal
Cc: Jaroslav Kysela, Takashi Iwai, Thierry Reding, Jonathan Hunter,
Sameer Pujar, Kuninori Morimoto, Mohan Kumar, linux-sound,
linux-tegra, linux-kernel, Thierry Reding
On Mon, 05 Oct 2026 08:55:59 +0000, Sheetal wrote:
> ASoC: tegra: Fix ASRC Stream6 input threshold control
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.4
Thanks!
[1/1] ASoC: tegra: Fix ASRC Stream6 input threshold control
https://git.kernel.org/broonie/sound/c/0504e71cc7b8
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-06 8:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-05 8:55 [PATCH] ASoC: tegra: Fix ASRC Stream6 input threshold control Sheetal
2026-10-05 15:24 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®