mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrik Grimler <henrik.grimler@axis.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Peter Griffin <peter.griffin@linaro.org>,
	 Alim Akhtar <alim.akhtar@samsung.com>
Cc: devicetree@vger.kernel.org, waqar.hameed@axis.com,
	 linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Henrik Grimler <henrik.grimler@axis.com>
Subject: [PATCH v2 16/17] ARM: dts: samsung: exynos4210-smdkv310: sort child nodes
Date: Tue, 06 Oct 2026 13:57:30 +0200	[thread overview]
Message-ID: <20261006-exynos-arm-cleanup-v2-16-e8e86a3c8c1f@axis.com> (raw)
In-Reply-To: <20261006-exynos-arm-cleanup-v2-0-e8e86a3c8c1f@axis.com>

Nodes should be sorted alphabetically by name. Move a few of the nodes
and child nodes to achieve alphabetical order.

Fixes dt-check-style in strict mode warnings:

  samsung/exynos4210-smdkv310.dts:28: [child-name-order] child node 'aliases' out of name order
  samsung/exynos4210-smdkv310.dts:43: [child-name-order] child node 'xusbxti' out of name order
  samsung/exynos4210-smdkv310.dts:48: [child-name-order] child node 'pmic-ap-clk' out of name order
  samsung/exynos4210-smdkv310.dts:168: [child-name-order] child node 'keypad-cols-pins' out of name order

Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
 arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts | 40 +++++++++++------------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts b/arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts
index 609853bb840a..5c703efacc87 100644
--- a/arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts
+++ b/arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts
@@ -20,11 +20,6 @@ / {
 	model = "Samsung smdkv310 evaluation board based on Exynos4210";
 	compatible = "samsung,smdkv310", "samsung,exynos4210", "samsung,exynos4";
 
-	memory@40000000 {
-		device_type = "memory";
-		reg = <0x40000000 0x80000000>;
-	};
-
 	aliases {
 		mmc0 = &sdhci_2;
 	};
@@ -35,9 +30,11 @@ chosen {
 	};
 
 	fixed-rate-clocks {
-		xxti {
-			compatible = "samsung,clock-xxti";
-			clock-frequency = <12000000>;
+		pmic_ap_clk: pmic-ap-clk {
+			/* Workaround for missing clock on PMIC */
+			compatible = "fixed-clock";
+			#clock-cells = <0>;
+			clock-frequency = <32768>;
 		};
 
 		xusbxti {
@@ -45,13 +42,16 @@ xusbxti {
 			clock-frequency = <24000000>;
 		};
 
-		pmic_ap_clk: pmic-ap-clk {
-			/* Workaround for missing clock on PMIC */
-			compatible = "fixed-clock";
-			#clock-cells = <0>;
-			clock-frequency = <32768>;
+		xxti {
+			compatible = "samsung,clock-xxti";
+			clock-frequency = <12000000>;
 		};
 	};
+
+	memory@40000000 {
+		device_type = "memory";
+		reg = <0x40000000 0x80000000>;
+	};
 };
 
 &cpu_thermal {
@@ -157,13 +157,6 @@ key-e {
 };
 
 &pinctrl_1 {
-	keypad_rows: keypad-rows-pins {
-		samsung,pins = "gpx2-0", "gpx2-1";
-		samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
-		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
-		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
-	};
-
 	keypad_cols: keypad-cols-pins {
 		samsung,pins = "gpx1-0", "gpx1-1", "gpx1-2", "gpx1-3",
 			       "gpx1-4", "gpx1-5", "gpx1-6", "gpx1-7";
@@ -171,6 +164,13 @@ keypad_cols: keypad-cols-pins {
 		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
 		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
+
+	keypad_rows: keypad-rows-pins {
+		samsung,pins = "gpx2-0", "gpx2-1";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
+	};
 };
 
 &rtc {

-- 
2.43.0


  parent reply	other threads:[~2026-10-06 11:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 11:57 [PATCH v2 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 01/17] ARM: dts: samsung: exynos4: add or remove empty lines Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 02/17] ARM: dts: samsung: exynos4: order *-names properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 03/17] ARM: dts: samsung: exynos4: sort all properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 04/17] ARM: dts: samsung: exynos4-cpu-thermal: fix indentation and sort Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 05/17] ARM: dts: samsung: exynos4210: sort nodes by address Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 06/17] ARM: dts: samsung: exynos4210: add or remove empty lines Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 07/17] ARM: dts: samsung: exynos4210: sort all properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 08/17] ARM: dts: samsung: exynos4210: use operating-points-v2 Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 09/17] ARM: dts: samsung: exynos4210: align all multiline properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 10/17] ARM: dts: samsung: exynos4210-pinctrl: align all continued lines Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 11/17] ARM: dts: samsung: exynos4210-i9100: sort properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 12/17] ARM: dts: samsung: exynos4210-trats: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 13/17] ARM: dts: samsung: exynos4210-origen: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 14/17] ARM: dts: samsung: exynos4210-universal_c210: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 15/17] ARM: dts: samsung: exynos4210-smdkv310: " Henrik Grimler
2026-10-06 11:57 ` Henrik Grimler [this message]
2026-10-06 11:57 ` [PATCH v2 17/17] ARM: dts: samsung: exynos4210-universal_c210: fix alignments Henrik Grimler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261006-exynos-arm-cleanup-v2-16-e8e86a3c8c1f@axis.com \
    --to=henrik.grimler@axis.com \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=waqar.hameed@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®