mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrik Grimler <henrik.grimler@axis.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Peter Griffin <peter.griffin@linaro.org>,
	 Alim Akhtar <alim.akhtar@samsung.com>
Cc: devicetree@vger.kernel.org, waqar.hameed@axis.com,
	 linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Henrik Grimler <henrik.grimler@axis.com>
Subject: [PATCH v2 06/17] ARM: dts: samsung: exynos4210: add or remove empty lines
Date: Tue, 06 Oct 2026 13:57:20 +0200	[thread overview]
Message-ID: <20261006-exynos-arm-cleanup-v2-6-e8e86a3c8c1f@axis.com> (raw)
In-Reply-To: <20261006-exynos-arm-cleanup-v2-0-e8e86a3c8c1f@axis.com>

For better readability it is preferred to have an empty line before
the status property, as well as before every child node. Empty lines
do not really help at start of children nodes though. Add or remove
empty lines where applicable.

dt-check-style in strict mode reports the issues like:

  samsung/exynos4210.dtsi:36: [required-blank-lines] "status" must be preceded by a blank line
  samsung/exynos4210.dtsi:45: [required-blank-lines] child node must be preceded by a blank line

Fixed partially with the help of dtfmt (Devicetree Source formatter).

Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
 arch/arm/boot/dts/samsung/exynos4210.dtsi | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm/boot/dts/samsung/exynos4210.dtsi b/arch/arm/boot/dts/samsung/exynos4210.dtsi
index 66b1a55f703d..66f35c4ae6b1 100644
--- a/arch/arm/boot/dts/samsung/exynos4210.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4210.dtsi
@@ -33,6 +33,7 @@ bus_acp: bus-acp {
 		clocks = <&clock CLK_DIV_ACP>;
 		clock-names = "bus";
 		operating-points-v2 = <&bus_acp_opp_table>;
+
 		status = "disabled";
 
 		bus_acp_opp_table: opp-table {
@@ -42,9 +43,11 @@ bus_acp_opp_table: opp-table {
 			opp-134000000 {
 				opp-hz = /bits/ 64 <134000000>;
 			};
+
 			opp-160000000 {
 				opp-hz = /bits/ 64 <160000000>;
 			};
+
 			opp-200000000 {
 				opp-hz = /bits/ 64 <200000000>;
 			};
@@ -56,6 +59,7 @@ bus_display: bus-display {
 		clocks = <&clock CLK_ACLK160>;
 		clock-names = "bus";
 		operating-points-v2 = <&bus_display_opp_table>;
+
 		status = "disabled";
 
 		bus_display_opp_table: opp-table {
@@ -65,9 +69,11 @@ bus_display_opp_table: opp-table {
 			opp-100000000 {
 				opp-hz = /bits/ 64 <100000000>;
 			};
+
 			opp-134000000 {
 				opp-hz = /bits/ 64 <134000000>;
 			};
+
 			opp-160000000 {
 				opp-hz = /bits/ 64 <160000000>;
 			};
@@ -79,6 +85,7 @@ bus_dmc: bus-dmc {
 		clocks = <&clock CLK_DIV_DMC>;
 		clock-names = "bus";
 		operating-points-v2 = <&bus_dmc_opp_table>;
+
 		status = "disabled";
 
 		bus_dmc_opp_table: opp-table {
@@ -89,10 +96,12 @@ opp-134000000 {
 				opp-hz = /bits/ 64 <134000000>;
 				opp-microvolt = <1025000>;
 			};
+
 			opp-267000000 {
 				opp-hz = /bits/ 64 <267000000>;
 				opp-microvolt = <1050000>;
 			};
+
 			opp-400000000 {
 				opp-hz = /bits/ 64 <400000000>;
 				opp-microvolt = <1150000>;
@@ -106,6 +115,7 @@ bus_fsys: bus-fsys {
 		clocks = <&clock CLK_ACLK133>;
 		clock-names = "bus";
 		operating-points-v2 = <&bus_fsys_opp_table>;
+
 		status = "disabled";
 
 		bus_fsys_opp_table: opp-table {
@@ -115,6 +125,7 @@ bus_fsys_opp_table: opp-table {
 			opp-10000000 {
 				opp-hz = /bits/ 64 <10000000>;
 			};
+
 			opp-134000000 {
 				opp-hz = /bits/ 64 <134000000>;
 			};
@@ -126,6 +137,7 @@ bus_lcd0: bus-lcd0 {
 		clocks = <&clock CLK_ACLK200>;
 		clock-names = "bus";
 		operating-points-v2 = <&bus_leftbus_opp_table>;
+
 		status = "disabled";
 	};
 
@@ -134,6 +146,7 @@ bus_leftbus: bus-leftbus {
 		clocks = <&clock CLK_DIV_GDL>;
 		clock-names = "bus";
 		operating-points-v2 = <&bus_leftbus_opp_table>;
+
 		status = "disabled";
 	};
 
@@ -142,6 +155,7 @@ bus_mfc: bus-mfc {
 		clocks = <&clock CLK_SCLK_MFC>;
 		clock-names = "bus";
 		operating-points-v2 = <&bus_leftbus_opp_table>;
+
 		status = "disabled";
 	};
 
@@ -150,6 +164,7 @@ bus_peri: bus-peri {
 		clocks = <&clock CLK_ACLK100>;
 		clock-names = "bus";
 		operating-points-v2 = <&bus_peri_opp_table>;
+
 		status = "disabled";
 
 		bus_peri_opp_table: opp-table {
@@ -159,6 +174,7 @@ bus_peri_opp_table: opp-table {
 			opp-5000000 {
 				opp-hz = /bits/ 64 <5000000>;
 			};
+
 			opp-100000000 {
 				opp-hz = /bits/ 64 <100000000>;
 			};
@@ -170,6 +186,7 @@ bus_rightbus: bus-rightbus {
 		clocks = <&clock CLK_DIV_GDR>;
 		clock-names = "bus";
 		operating-points-v2 = <&bus_leftbus_opp_table>;
+
 		status = "disabled";
 	};
 
@@ -182,6 +199,7 @@ cluster0 {
 				core0 {
 					cpu = <&cpu0>;
 				};
+
 				core1 {
 					cpu = <&cpu1>;
 				};
@@ -234,9 +252,11 @@ bus_leftbus_opp_table: opp-table-0 {
 		opp-100000000 {
 			opp-hz = /bits/ 64 <100000000>;
 		};
+
 		opp-160000000 {
 			opp-hz = /bits/ 64 <160000000>;
 		};
+
 		opp-200000000 {
 			opp-hz = /bits/ 64 <200000000>;
 			opp-suspend;
@@ -353,6 +373,7 @@ ppmu_lcd1: ppmu@12240000 {
 			reg = <0x12240000 0x2000>;
 			clocks = <&clock CLK_PPMULCD1>;
 			clock-names = "ppmu";
+
 			status = "disabled";
 		};
 
@@ -489,6 +510,7 @@ opp-160000000 {
 			opp-hz = /bits/ 64 <160000000>;
 			opp-microvolt = <950000>;
 		};
+
 		opp-267000000 {
 			opp-hz = /bits/ 64 <267000000>;
 			opp-microvolt = <1050000>;
@@ -511,6 +533,7 @@ &mixer {
 &pmu {
 	interrupts = <2 2>, <3 2>;
 	interrupt-affinity = <&cpu0>, <&cpu1>;
+
 	status = "okay";
 };
 

-- 
2.43.0


  parent reply	other threads:[~2026-10-06 11:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 11:57 [PATCH v2 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 01/17] ARM: dts: samsung: exynos4: add or remove empty lines Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 02/17] ARM: dts: samsung: exynos4: order *-names properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 03/17] ARM: dts: samsung: exynos4: sort all properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 04/17] ARM: dts: samsung: exynos4-cpu-thermal: fix indentation and sort Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 05/17] ARM: dts: samsung: exynos4210: sort nodes by address Henrik Grimler
2026-10-06 11:57 ` Henrik Grimler [this message]
2026-10-06 11:57 ` [PATCH v2 07/17] ARM: dts: samsung: exynos4210: sort all properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 08/17] ARM: dts: samsung: exynos4210: use operating-points-v2 Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 09/17] ARM: dts: samsung: exynos4210: align all multiline properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 10/17] ARM: dts: samsung: exynos4210-pinctrl: align all continued lines Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 11/17] ARM: dts: samsung: exynos4210-i9100: sort properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 12/17] ARM: dts: samsung: exynos4210-trats: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 13/17] ARM: dts: samsung: exynos4210-origen: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 14/17] ARM: dts: samsung: exynos4210-universal_c210: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 15/17] ARM: dts: samsung: exynos4210-smdkv310: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 16/17] ARM: dts: samsung: exynos4210-smdkv310: sort child nodes Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 17/17] ARM: dts: samsung: exynos4210-universal_c210: fix alignments Henrik Grimler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261006-exynos-arm-cleanup-v2-6-e8e86a3c8c1f@axis.com \
    --to=henrik.grimler@axis.com \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=waqar.hameed@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®