mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/6 v1] perf test attr: Fix the re-enabled test
@ 2026-10-06 16:13 Arnaldo Carvalho de Melo
  2026-10-06 16:13 ` [PATCH 1/6] perf test attr: Propagate the return value from the test to the wrapper Arnaldo Carvalho de Melo
                   ` (6 more replies)
  0 siblings, 7 replies; 11+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-10-06 16:13 UTC (permalink / raw)
  To: Namhyung Kim
  Cc: Ingo Molnar, Thomas Gleixner, James Clark, Jiri Olsa, Ian Rogers,
	Adrian Hunter, Clark Williams, linux-kernel, linux-perf-users,
	Arnaldo Carvalho de Melo

From: Arnaldo Carvalho de Melo <acme@redhat.com>

Hello all,

This series fixes the "Perf attribute expectations test" (perf test 82,
formerly "Setup struct perf_event_attr").

Patches 1-2 are Michael Petlan's prerequisite fixes that make the shell
wrapper propagate attr.py's return value and correct the
perf_event_attr size expectation after struct config4 was added.  They
are included at the start of the series so that it applies cleanly on
the current perf-tools-next (and for the review bots to verify the new
patches); the new fixes are patches 3-6.

With the test reporting failures again, several stale expectations
surfaced and are addressed here:

- test-record-graph-dwarf still expected PERF_SAMPLE_ADDR and
  PERF_SAMPLE_DATA_SRC for --call-graph dwarf.  Those were dropped by
  bdd051e249141c79 ("perf record: Split --data-mmap option"), which
  decoupled data MMAP recording from the sample address bits.

- The record and stat group tests expected cache-misses and
  instructions to be the legacy PERF_TYPE_HARDWARE events, but since
  b1c5efbfd92eb84d ("perf parse-events: Remove hard coded legacy
  hardware and cache parsing") they resolve to the core PMU sysfs/JSON
  events, so request the legacy encodings explicitly with the
  legacy-hardware-config term.

- The perf stat default metrics open their events in groups and the
  raw encodings of instructions, branch-misses, cpu-cycles and
  stalled-cycles-frontend/backend differ between Intel and AMD, so
  base-stat now accepts the standalone and group variants and
  test-stat-default/detailed-{1,2,3} gained the per-vendor raw
  encodings.

- attr.py no longer requires a recorded event to be in a group when
  the matching expectation does not declare one, allowing the stat
  tests to verify event attributes without encoding the metric
  grouping.  Expectations that declare a group are still verified in
  both directions.

The test passes with 'perf test -vv attribute' on x86_64.  The AMD
encodings come from the amd_pmu_event_map tables in
arch/x86/events/amd/core.c.

Arnaldo

Arnaldo Carvalho de Melo (4):
  perf test attr: Fix record dwarf sample_type expectation
  perf test attr: Fix legacy event encodings in group tests
  perf test attr: Fix default stat metrics expectations
  perf test attr: Relax group checking for ungrouped expectations

Michael Petlan (2):
  perf test attr: Propagate the return value from the test to the
    wrapper
  perf test attr: Fix wrong size expectation for events

 tools/perf/tests/shell/attr.sh                |  1 +
 tools/perf/tests/shell/attr/README            | 10 +++---
 tools/perf/tests/shell/attr/base-record       |  2 +-
 tools/perf/tests/shell/attr/base-stat         |  8 ++---
 tools/perf/tests/shell/attr/system-wide-dummy |  2 +-
 .../tests/shell/attr/test-record-dummy-C0     |  2 +-
 .../tests/shell/attr/test-record-graph-dwarf  |  2 +-
 .../shell/attr/test-record-group-sampling     |  4 +--
 .../shell/attr/test-record-group-sampling1    |  4 +--
 .../shell/attr/test-record-group-sampling2    |  4 +--
 .../perf/tests/shell/attr/test-record-group1  |  2 +-
 .../perf/tests/shell/attr/test-record-group2  |  2 +-
 .../perf/tests/shell/attr/test-record-group3  |  2 +-
 tools/perf/tests/shell/attr/test-stat-default | 32 +++++++++++++++++--
 .../tests/shell/attr/test-stat-detailed-1     | 32 +++++++++++++++++--
 .../tests/shell/attr/test-stat-detailed-2     | 32 +++++++++++++++++--
 .../tests/shell/attr/test-stat-detailed-3     | 32 +++++++++++++++++--
 tools/perf/tests/shell/attr/test-stat-group1  |  2 +-
 tools/perf/tests/shell/lib/attr.py            | 11 +++++--
 19 files changed, 152 insertions(+), 34 deletions(-)

-- 
2.55.0


^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2026-10-07  8:31 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-06 16:13 [PATCH 0/6 v1] perf test attr: Fix the re-enabled test Arnaldo Carvalho de Melo
2026-10-06 16:13 ` [PATCH 1/6] perf test attr: Propagate the return value from the test to the wrapper Arnaldo Carvalho de Melo
2026-10-06 16:13 ` [PATCH 2/6] perf test attr: Fix wrong size expectation for events Arnaldo Carvalho de Melo
2026-10-06 16:13 ` [PATCH 3/6] perf test attr: Fix record dwarf sample_type expectation Arnaldo Carvalho de Melo
2026-10-06 16:13 ` [PATCH 4/6] perf test attr: Fix legacy event encodings in group tests Arnaldo Carvalho de Melo
2026-10-06 16:13 ` [PATCH 5/6] perf test attr: Fix default stat metrics expectations Arnaldo Carvalho de Melo
2026-10-06 16:13 ` [PATCH 6/6] perf test attr: Relax group checking for ungrouped expectations Arnaldo Carvalho de Melo
2026-10-07  0:00 ` [PATCH 0/6 v1] perf test attr: Fix the re-enabled test Namhyung Kim
2026-10-07  0:22   ` Namhyung Kim
2026-10-07  5:58     ` Arnaldo Melo
2026-10-07  8:31   ` Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®