mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
	x86@kernel.org
Subject: [PATCH 02/16] x86 idle: rename global pm_idle to static x86_idle
Date: Sun, 10 Feb 2013 00:58:09 -0500	[thread overview]
Message-ID: <39a3b810d55a353d23043703bcde5c22afa01846.1360475150.git.len.brown@intel.com> (raw)
In-Reply-To: <1360475903-30007-1-git-send-email-lenb@kernel.org>
In-Reply-To: <2b219d07e0f287c2c713f5465fc8646158fa986e.1360475150.git.len.brown@intel.com>

From: Len Brown <len.brown@intel.com>

(pm_idle)() is being removed from linux/pm.h
because Linux does not have such a cross-architecture concept.

x86 uses an idle function pointer in its architecture
specific code as a backup to cpuidle.  So we re-name
x86 use of pm_idle to x86_idle, and make it static to x86.

Signed-off-by: Len Brown <len.brown@intel.com>
Cc: x86@kernel.org
---
 arch/x86/kernel/process.c | 28 ++++++++++++----------------
 1 file changed, 12 insertions(+), 16 deletions(-)

diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index f571a6e..ceb05db 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -268,10 +268,7 @@ void __switch_to_xtra(struct task_struct *prev_p, struct task_struct *next_p,
 unsigned long boot_option_idle_override = IDLE_NO_OVERRIDE;
 EXPORT_SYMBOL(boot_option_idle_override);
 
-/*
- * Powermanagement idle function, if any..
- */
-void (*pm_idle)(void);
+static void (*x86_idle)(void);
 
 #ifndef CONFIG_SMP
 static inline void play_dead(void)
@@ -348,7 +345,7 @@ void cpu_idle(void)
 			rcu_idle_enter();
 
 			if (cpuidle_idle_call())
-				pm_idle();
+				x86_idle();
 
 			rcu_idle_exit();
 			start_critical_timings();
@@ -395,9 +392,9 @@ EXPORT_SYMBOL(default_idle);
 
 bool set_pm_idle_to_default(void)
 {
-	bool ret = !!pm_idle;
+	bool ret = !!x86_idle;
 
-	pm_idle = default_idle;
+	x86_idle = default_idle;
 
 	return ret;
 }
@@ -564,11 +561,10 @@ static void amd_e400_idle(void)
 void __cpuinit select_idle_routine(const struct cpuinfo_x86 *c)
 {
 #ifdef CONFIG_SMP
-	if (pm_idle == poll_idle && smp_num_siblings > 1) {
+	if (x86_idle == poll_idle && smp_num_siblings > 1)
 		pr_warn_once("WARNING: polling idle and HT enabled, performance may degrade\n");
-	}
 #endif
-	if (pm_idle)
+	if (x86_idle)
 		return;
 
 	if (cpu_has(c, X86_FEATURE_MWAIT) && mwait_usable(c)) {
@@ -576,19 +572,19 @@ void __cpuinit select_idle_routine(const struct cpuinfo_x86 *c)
 		 * One CPU supports mwait => All CPUs supports mwait
 		 */
 		pr_info("using mwait in idle threads\n");
-		pm_idle = mwait_idle;
+		x86_idle = mwait_idle;
 	} else if (cpu_has_amd_erratum(amd_erratum_400)) {
 		/* E400: APIC timer interrupt does not wake up CPU from C1e */
 		pr_info("using AMD E400 aware idle routine\n");
-		pm_idle = amd_e400_idle;
+		x86_idle = amd_e400_idle;
 	} else
-		pm_idle = default_idle;
+		x86_idle = default_idle;
 }
 
 void __init init_amd_e400_c1e_mask(void)
 {
 	/* If we're using amd_e400_idle, we need to allocate amd_e400_c1e_mask. */
-	if (pm_idle == amd_e400_idle)
+	if (x86_idle == amd_e400_idle)
 		zalloc_cpumask_var(&amd_e400_c1e_mask, GFP_KERNEL);
 }
 
@@ -599,7 +595,7 @@ static int __init idle_setup(char *str)
 
 	if (!strcmp(str, "poll")) {
 		pr_info("using polling idle threads\n");
-		pm_idle = poll_idle;
+		x86_idle = poll_idle;
 		boot_option_idle_override = IDLE_POLL;
 	} else if (!strcmp(str, "mwait")) {
 		boot_option_idle_override = IDLE_FORCE_MWAIT;
@@ -612,7 +608,7 @@ static int __init idle_setup(char *str)
 		 * To continue to load the CPU idle driver, don't touch
 		 * the boot_option_idle_override.
 		 */
-		pm_idle = default_idle;
+		x86_idle = default_idle;
 		boot_option_idle_override = IDLE_HALT;
 	} else if (!strcmp(str, "nomwait")) {
 		/*
-- 
1.8.1.3.535.ga923c31


  reply	other threads:[~2013-02-10  6:02 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-10  5:58 pm_idle cleanup patch series Len Brown
2013-02-10  5:58 ` [PATCH 01/16] APM idle: register apm_cpu_idle via cpuidle Len Brown
2013-02-10  5:58   ` Len Brown [this message]
2013-02-10  5:58   ` [PATCH 03/16] sh idle: rename global pm_idle to static sh_idle Len Brown
2013-02-10  5:58   ` [PATCH 04/16] sparc idle: rename pm_idle to sparc_idle Len Brown
2013-02-10 23:08     ` David Miller
2013-02-10  5:58   ` [PATCH 05/16] blackfin idle: delete pm_idle Len Brown
2013-02-18 16:28     ` Lars-Peter Clausen
2013-02-20 17:53       ` Len Brown
2013-02-20 19:52       ` Rafael J. Wysocki
2013-02-20 19:53         ` Lars-Peter Clausen
2013-02-20 19:59           ` Rafael J. Wysocki
2013-02-20 20:21             ` Lars-Peter Clausen
2013-02-20 21:18               ` Rafael J. Wysocki
2013-02-21  9:56                 ` [PATCH] blackfin idle: Fix compile error Lars-Peter Clausen
2013-02-21 16:24                   ` Rafael J. Wysocki
2013-02-10  5:58   ` [PATCH 06/16] ARM idle: delete pm_idle Len Brown
2013-02-11 16:02     ` Catalin Marinas
2013-02-11 16:11       ` Russell King - ARM Linux
2013-02-11 22:42         ` Len Brown
2013-02-12 22:04     ` Kevin Hilman
2013-02-10  5:58   ` [PATCH 07/16] ARM64 " Len Brown
2013-02-12 11:03     ` Catalin Marinas
2013-02-10  5:58   ` [PATCH 08/16] cris idle: delete idle and pm_idle Len Brown
2013-02-11  8:42     ` Jesper Nilsson
2013-02-10  5:58   ` [PATCH 09/16] ia64 idle: delete pm_idle Len Brown
2013-02-21 10:15     ` Lars-Peter Clausen
2013-03-26  3:12       ` Brown, Len
2013-03-26  4:29         ` [PATCH] ia64 idle: delete (*idle)() Len Brown
2013-02-10  5:58   ` [PATCH 10/16] m32r idle: delete pm_idle, and other dead idle code Len Brown
2013-02-10  5:58   ` [PATCH 11/16] microblaze idle: delete pm_idle Len Brown
2013-02-21 10:15     ` [PATCH] microblaze idle: Fix compile error Lars-Peter Clausen
2013-02-21 16:25       ` Rafael J. Wysocki
2013-02-10  5:58   ` [PATCH 12/16] mn10300 idle: delete pm_idle Len Brown
2013-02-10  5:58   ` [PATCH 13/16] openrisc " Len Brown
2013-02-10 17:31     ` [ORLinux] " Jonas Bonn
2013-02-10  5:58   ` [PATCH 14/16] unicore32 idle: delete stray pm_idle comment Len Brown
2013-02-10  5:58   ` [PATCH 15/16] PM idle: remove global declaration of pm_idle Len Brown
2013-02-10  5:58   ` [PATCH 16/16] xen idle: make xen-specific macro xen-specific Len Brown
2013-02-11  9:18   ` [PATCH 01/16] APM idle: register apm_cpu_idle via cpuidle Daniel Lezcano
2013-02-11 22:50     ` Len Brown
2013-02-11 23:03     ` APM: Request to Test Len Brown
2013-02-11 23:03       ` [PATCH v2] APM idle: register apm_cpu_idle via cpuidle Len Brown
2013-02-12 15:00         ` Daniel Lezcano
2013-02-18 13:30         ` Jiri Kosina
2013-02-20 17:48           ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39a3b810d55a353d23043703bcde5c22afa01846.1360475150.git.len.brown@intel.com \
    --to=lenb@kernel.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®