From: Len Brown <lenb@kernel.org>
To: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
linux-m32r@ml.linux-m32r.org
Subject: [PATCH 10/16] m32r idle: delete pm_idle, and other dead idle code
Date: Sun, 10 Feb 2013 00:58:17 -0500 [thread overview]
Message-ID: <50145c48954ee5626107dd1aa4c2ed95dd1bc2b6.1360475150.git.len.brown@intel.com> (raw)
In-Reply-To: <1360475903-30007-1-git-send-email-lenb@kernel.org>
In-Reply-To: <2b219d07e0f287c2c713f5465fc8646158fa986e.1360475150.git.len.brown@intel.com>
From: Len Brown <len.brown@intel.com>
All paths on m32r lead to cpu_relax().
So delete the dead code and simply call cpu_relax() directly.
Signed-off-by: Len Brown <len.brown@intel.com>
Cc: linux-m32r@ml.linux-m32r.org
---
arch/m32r/kernel/process.c | 51 ++--------------------------------------------
1 file changed, 2 insertions(+), 49 deletions(-)
diff --git a/arch/m32r/kernel/process.c b/arch/m32r/kernel/process.c
index 765d0f5..bde899e 100644
--- a/arch/m32r/kernel/process.c
+++ b/arch/m32r/kernel/process.c
@@ -44,36 +44,10 @@ unsigned long thread_saved_pc(struct task_struct *tsk)
return tsk->thread.lr;
}
-/*
- * Powermanagement idle function, if any..
- */
-static void (*pm_idle)(void) = NULL;
-
void (*pm_power_off)(void) = NULL;
EXPORT_SYMBOL(pm_power_off);
/*
- * We use this is we don't have any better
- * idle routine..
- */
-static void default_idle(void)
-{
- /* M32R_FIXME: Please use "cpu_sleep" mode. */
- cpu_relax();
-}
-
-/*
- * On SMP it's slightly faster (but much more power-consuming!)
- * to poll the ->work.need_resched flag instead of waiting for the
- * cross-CPU IPI to arrive. Use this option with caution.
- */
-static void poll_idle (void)
-{
- /* M32R_FIXME */
- cpu_relax();
-}
-
-/*
* The idle thread. There's no useful work to be
* done, so just try to conserve power and have a
* low exit latency (ie sit in a loop waiting for
@@ -84,14 +58,8 @@ void cpu_idle (void)
/* endless idle loop with no priority at all */
while (1) {
rcu_idle_enter();
- while (!need_resched()) {
- void (*idle)(void) = pm_idle;
-
- if (!idle)
- idle = default_idle;
-
- idle();
- }
+ while (!need_resched())
+ cpu_relax();
rcu_idle_exit();
schedule_preempt_disabled();
}
@@ -120,21 +88,6 @@ void machine_power_off(void)
/* M32R_FIXME */
}
-static int __init idle_setup (char *str)
-{
- if (!strncmp(str, "poll", 4)) {
- printk("using poll in idle threads.\n");
- pm_idle = poll_idle;
- } else if (!strncmp(str, "sleep", 4)) {
- printk("using sleep in idle threads.\n");
- pm_idle = default_idle;
- }
-
- return 1;
-}
-
-__setup("idle=", idle_setup);
-
void show_regs(struct pt_regs * regs)
{
printk("\n");
--
1.8.1.3.535.ga923c31
next prev parent reply other threads:[~2013-02-10 5:58 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-10 5:58 pm_idle cleanup patch series Len Brown
2013-02-10 5:58 ` [PATCH 01/16] APM idle: register apm_cpu_idle via cpuidle Len Brown
2013-02-10 5:58 ` [PATCH 02/16] x86 idle: rename global pm_idle to static x86_idle Len Brown
2013-02-10 5:58 ` [PATCH 03/16] sh idle: rename global pm_idle to static sh_idle Len Brown
2013-02-10 5:58 ` [PATCH 04/16] sparc idle: rename pm_idle to sparc_idle Len Brown
2013-02-10 23:08 ` David Miller
2013-02-10 5:58 ` [PATCH 05/16] blackfin idle: delete pm_idle Len Brown
2013-02-18 16:28 ` Lars-Peter Clausen
2013-02-20 17:53 ` Len Brown
2013-02-20 19:52 ` Rafael J. Wysocki
2013-02-20 19:53 ` Lars-Peter Clausen
2013-02-20 19:59 ` Rafael J. Wysocki
2013-02-20 20:21 ` Lars-Peter Clausen
2013-02-20 21:18 ` Rafael J. Wysocki
2013-02-21 9:56 ` [PATCH] blackfin idle: Fix compile error Lars-Peter Clausen
2013-02-21 16:24 ` Rafael J. Wysocki
2013-02-10 5:58 ` [PATCH 06/16] ARM idle: delete pm_idle Len Brown
2013-02-11 16:02 ` Catalin Marinas
2013-02-11 16:11 ` Russell King - ARM Linux
2013-02-11 22:42 ` Len Brown
2013-02-12 22:04 ` Kevin Hilman
2013-02-10 5:58 ` [PATCH 07/16] ARM64 " Len Brown
2013-02-12 11:03 ` Catalin Marinas
2013-02-10 5:58 ` [PATCH 08/16] cris idle: delete idle and pm_idle Len Brown
2013-02-11 8:42 ` Jesper Nilsson
2013-02-10 5:58 ` [PATCH 09/16] ia64 idle: delete pm_idle Len Brown
2013-02-21 10:15 ` Lars-Peter Clausen
2013-03-26 3:12 ` Brown, Len
2013-03-26 4:29 ` [PATCH] ia64 idle: delete (*idle)() Len Brown
2013-02-10 5:58 ` Len Brown [this message]
2013-02-10 5:58 ` [PATCH 11/16] microblaze idle: delete pm_idle Len Brown
2013-02-21 10:15 ` [PATCH] microblaze idle: Fix compile error Lars-Peter Clausen
2013-02-21 16:25 ` Rafael J. Wysocki
2013-02-10 5:58 ` [PATCH 12/16] mn10300 idle: delete pm_idle Len Brown
2013-02-10 5:58 ` [PATCH 13/16] openrisc " Len Brown
2013-02-10 17:31 ` [ORLinux] " Jonas Bonn
2013-02-10 5:58 ` [PATCH 14/16] unicore32 idle: delete stray pm_idle comment Len Brown
2013-02-10 5:58 ` [PATCH 15/16] PM idle: remove global declaration of pm_idle Len Brown
2013-02-10 5:58 ` [PATCH 16/16] xen idle: make xen-specific macro xen-specific Len Brown
2013-02-11 9:18 ` [PATCH 01/16] APM idle: register apm_cpu_idle via cpuidle Daniel Lezcano
2013-02-11 22:50 ` Len Brown
2013-02-11 23:03 ` APM: Request to Test Len Brown
2013-02-11 23:03 ` [PATCH v2] APM idle: register apm_cpu_idle via cpuidle Len Brown
2013-02-12 15:00 ` Daniel Lezcano
2013-02-18 13:30 ` Jiri Kosina
2013-02-20 17:48 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50145c48954ee5626107dd1aa4c2ed95dd1bc2b6.1360475150.git.len.brown@intel.com \
--to=lenb@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m32r@ml.linux-m32r.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®