mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Duc Dang <dhdang@apm.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Loc Ho <lho@apm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	USB list <linux-usb@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, mathias.nyman@intel.com,
	Mark Langsdorf <mlangsdo@redhat.com>, patches <patches@apm.com>,
	Feng Kan <fkan@apm.com>, Duc Dang <dhdang@apm.com>
Subject: [PATCH v6 2/2] usb: Add support for ACPI identification to xhci-platform
Date: Mon, 10 Aug 2015 00:37:22 -0700	[thread overview]
Message-ID: <466084f08a22e7af257f5ed3c7757938c76bf5cd.1439190829.git.dhdang@apm.com> (raw)
In-Reply-To: <eb7cf78f9c43ee61a5ad1f51a1bd53bd7524e05f.1439190829.git.dhdang@apm.com>
In-Reply-To: <20150808092252.GJ7557@n2100.arm.linux.org.uk>

Provide the methods to let ACPI identify the need to use
xhci-platform. Change the Kconfig files so the
xhci-plat.o file is selectable during kernel config.

This has been tested on an ARM64 machine with platform XHCI, an
x86_64 machine with XHCI, and an x86_64 machine without XHCI.
There were no regressions or error messages on the machines
without platform XHCI.

[dhdang: regenerate the patch over 4.2-rc5 and address new comments]
Signed-off-by: Mark Langsdorf <mlangsdo@redhat.com>
Signed-off-by: Duc Dang <dhdang@apm.com>

---
Change from v5:
	Change comment to "XHCI-compliant USB Controller" as
	"PNP0D10" ID is not X-Gene specific

Changes from v4:
        Remove #ifdef CONFIG_ACPI

Changes from v3:
        Regenerate the patch over 4.2-rc5
        No code change

Changes from v2
        Replaced tristate with a boolean as the driver doesn't
                compile as a module
        Correct --help-- to ---help---

Changes from v1
        Renamed from "add support for APM X-Gene to xhci-platform"
        Removed changes to arm64/Kconfig
        Made CONFIG_USB_XHCI_PLATFORM a user selectable config option

 drivers/usb/host/Kconfig     | 7 ++++++-
 drivers/usb/host/xhci-plat.c | 9 +++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 8afc3c1..96231ee 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -32,7 +32,12 @@ config USB_XHCI_PCI
        default y
 
 config USB_XHCI_PLATFORM
-	tristate
+	tristate "xHCI platform driver support"
+	---help---
+	  Say 'Y' to enable the support for the xHCI host controller
+	  as a platform device. Many ARM SoCs provide USB this way.
+
+	  If unsure, say 'Y'.
 
 config USB_XHCI_MVEBU
 	tristate "xHCI support for Marvell Armada 375/38x"
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 5d1b84b..7ec2d31 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -19,6 +19,7 @@
 #include <linux/usb/phy.h>
 #include <linux/slab.h>
 #include <linux/usb/xhci_pdriver.h>
+#include <linux/acpi.h>
 
 #include "xhci.h"
 #include "xhci-mvebu.h"
@@ -266,6 +267,13 @@ static const struct of_device_id usb_xhci_of_match[] = {
 MODULE_DEVICE_TABLE(of, usb_xhci_of_match);
 #endif
 
+static const struct acpi_device_id usb_xhci_acpi_match[] = {
+	/* XHCI-compliant USB Controller */
+	{ "PNP0D10", },
+	{ }
+};
+MODULE_DEVICE_TABLE(acpi, usb_xhci_acpi_match);
+
 static struct platform_driver usb_xhci_driver = {
 	.probe	= xhci_plat_probe,
 	.remove	= xhci_plat_remove,
@@ -273,6 +281,7 @@ static struct platform_driver usb_xhci_driver = {
 		.name = "xhci-hcd",
 		.pm = DEV_PM_OPS,
 		.of_match_table = of_match_ptr(usb_xhci_of_match),
+		.acpi_match_table = ACPI_PTR(usb_xhci_acpi_match),
 	},
 };
 MODULE_ALIAS("platform:xhci-hcd");
-- 
1.9.1


  parent reply	other threads:[~2015-08-10  7:38 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CADaLNDkeOP+gBw0qdSDha551w+w+q4ry9-EevDw5giyiQGdnqA@mail.gmail.com>
2015-08-08  1:03 ` [PATCH v4 1/2] usb: make xhci platform driver use 64 bit or 32 bit DMA Duc Dang
2015-08-08  1:03 ` [PATCH v4 2/2] usb: Add support for ACPI identification to xhci-platform Duc Dang
2015-08-08  1:29   ` Greg KH
2015-08-08  2:40     ` Duc Dang
2015-08-08  3:18       ` [PATCH v5 1/2] usb: make xhci platform driver use 64 bit or 32 bit DMA Duc Dang
2015-08-08  9:22         ` Russell King - ARM Linux
2015-08-08 20:31           ` Duc Dang
2015-08-15 20:05             ` Arnd Bergmann
2015-08-19 21:28               ` Duc Dang
2015-08-20 13:09                 ` Arnd Bergmann
2015-08-20 19:38                   ` [PATCH v7 " Duc Dang
2015-08-31 18:58                     ` Duc Dang
2015-09-01 11:54                       ` Mathias Nyman
2015-09-01 12:07                         ` Russell King - ARM Linux
2015-09-10 20:53                         ` Duc Dang
2015-09-17 18:19                           ` [PATCH v8 0/3] usb: xhci-platform: Configure 64-bit DMA mask if the platform is capable Duc Dang
2015-09-30 21:24                             ` Duc Dang
2015-10-04  9:10                               ` Greg KH
2015-10-07 13:20                                 ` Mathias Nyman
2015-09-17 18:19                           ` [PATCH v8 1/3] usb: make xhci platform driver use 64 bit or 32 bit DMA Duc Dang
2015-09-17 19:51                             ` Arnd Bergmann
2015-09-17 20:29                               ` Duc Dang
2015-09-17 18:19                           ` [PATCH v8 2/3] usb: Add support for ACPI identification to xhci-platform Duc Dang
2015-09-17 18:19                           ` [PATCH v8 3/3] usb: xhci: configure 32-bit DMA if the controller does not support 64-bit DMA Duc Dang
2015-08-20 19:38                   ` [PATCH v7 2/2] usb: Add support for ACPI identification to xhci-platform Duc Dang
2015-08-10  7:37           ` [PATCH v6 1/2] usb: make xhci platform driver use 64 bit or 32 bit DMA Duc Dang
2015-08-10  7:37           ` Duc Dang [this message]
2015-08-08  3:18       ` [PATCH v5 2/2] usb: Add support for ACPI identification to xhci-platform Duc Dang
2015-08-08  5:43     ` [PATCH v4 " Javier Martinez Canillas
2015-08-08 15:37       ` Greg KH
2015-08-08 16:45         ` Duc Dang
2015-08-08 21:05         ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=466084f08a22e7af257f5ed3c7757938c76bf5cd.1439190829.git.dhdang@apm.com \
    --to=dhdang@apm.com \
    --cc=arnd@arndb.de \
    --cc=fkan@apm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=lho@apm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mathias.nyman@intel.com \
    --cc=mlangsdo@redhat.com \
    --cc=patches@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®