mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Duc Dang <dhdang@apm.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Loc Ho <lho@apm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	USB list <linux-usb@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, mathias.nyman@intel.com,
	Mark Langsdorf <mlangsdo@redhat.com>, patches <patches@apm.com>,
	Feng Kan <fkan@apm.com>, Duc Dang <dhdang@apm.com>
Subject: [PATCH v6 1/2] usb: make xhci platform driver use 64 bit or 32 bit DMA
Date: Mon, 10 Aug 2015 00:37:21 -0700	[thread overview]
Message-ID: <eb7cf78f9c43ee61a5ad1f51a1bd53bd7524e05f.1439190829.git.dhdang@apm.com> (raw)
In-Reply-To: <20150808092252.GJ7557@n2100.arm.linux.org.uk>

The xhci platform driver needs to work on systems that
either only support 64-bit DMA or only support 32-bit DMA.
Attempt to set a coherent dma mask for 64-bit DMA, and
attempt again with 32-bit DMA if that fails.

[dhdang: regenerate the patch over 4.2-rc5 and address new comments]
Signed-off-by: Mark Langsdorf <mlangsdo@redhat.com>
Tested-by: Mark Salter <msalter@redhat.com>
Signed-off-by: Duc Dang <dhdang@apm.com>

---
Changes from v5:
	-Change comment
	-Assign dma_mask to coherent_dma_mask if dma_mask is NULL
	to make sure dma_set_mask_and_coherent does not	fail prematurely.

Changes from v4:
        -None

Changes from v3:
        -Re-generate the patch over 4.2-rc5
        -No code change.

Changes from v2:
        -None

Changes from v1:
        -Consolidated to use dma_set_mask_and_coherent
        -Got rid of the check against sizeof(dma_addr_t)

 drivers/usb/host/xhci-plat.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 890ad9d..5d1b84b 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -93,14 +93,18 @@ static int xhci_plat_probe(struct platform_device *pdev)
 	if (irq < 0)
 		return -ENODEV;
 
-	/* Initialize dma_mask and coherent_dma_mask to 32-bits */
-	ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
-	if (ret)
-		return ret;
+	/*
+	 * Try setting dma_mask and coherent_dma_mask to 64 bits,
+	 * then try 32 bits
+	 */
 	if (!pdev->dev.dma_mask)
 		pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask;
-	else
-		dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
+	ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
+	if (ret) {
+		ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
+		if (ret)
+			return ret;
+	}
 
 	hcd = usb_create_hcd(driver, &pdev->dev, dev_name(&pdev->dev));
 	if (!hcd)
-- 
1.9.1


  parent reply	other threads:[~2015-08-10  7:37 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CADaLNDkeOP+gBw0qdSDha551w+w+q4ry9-EevDw5giyiQGdnqA@mail.gmail.com>
2015-08-08  1:03 ` [PATCH v4 " Duc Dang
2015-08-08  1:03 ` [PATCH v4 2/2] usb: Add support for ACPI identification to xhci-platform Duc Dang
2015-08-08  1:29   ` Greg KH
2015-08-08  2:40     ` Duc Dang
2015-08-08  3:18       ` [PATCH v5 1/2] usb: make xhci platform driver use 64 bit or 32 bit DMA Duc Dang
2015-08-08  9:22         ` Russell King - ARM Linux
2015-08-08 20:31           ` Duc Dang
2015-08-15 20:05             ` Arnd Bergmann
2015-08-19 21:28               ` Duc Dang
2015-08-20 13:09                 ` Arnd Bergmann
2015-08-20 19:38                   ` [PATCH v7 " Duc Dang
2015-08-31 18:58                     ` Duc Dang
2015-09-01 11:54                       ` Mathias Nyman
2015-09-01 12:07                         ` Russell King - ARM Linux
2015-09-10 20:53                         ` Duc Dang
2015-09-17 18:19                           ` [PATCH v8 0/3] usb: xhci-platform: Configure 64-bit DMA mask if the platform is capable Duc Dang
2015-09-30 21:24                             ` Duc Dang
2015-10-04  9:10                               ` Greg KH
2015-10-07 13:20                                 ` Mathias Nyman
2015-09-17 18:19                           ` [PATCH v8 1/3] usb: make xhci platform driver use 64 bit or 32 bit DMA Duc Dang
2015-09-17 19:51                             ` Arnd Bergmann
2015-09-17 20:29                               ` Duc Dang
2015-09-17 18:19                           ` [PATCH v8 2/3] usb: Add support for ACPI identification to xhci-platform Duc Dang
2015-09-17 18:19                           ` [PATCH v8 3/3] usb: xhci: configure 32-bit DMA if the controller does not support 64-bit DMA Duc Dang
2015-08-20 19:38                   ` [PATCH v7 2/2] usb: Add support for ACPI identification to xhci-platform Duc Dang
2015-08-10  7:37           ` Duc Dang [this message]
2015-08-10  7:37           ` [PATCH v6 " Duc Dang
2015-08-08  3:18       ` [PATCH v5 " Duc Dang
2015-08-08  5:43     ` [PATCH v4 " Javier Martinez Canillas
2015-08-08 15:37       ` Greg KH
2015-08-08 16:45         ` Duc Dang
2015-08-08 21:05         ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb7cf78f9c43ee61a5ad1f51a1bd53bd7524e05f.1439190829.git.dhdang@apm.com \
    --to=dhdang@apm.com \
    --cc=arnd@arndb.de \
    --cc=fkan@apm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=lho@apm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mathias.nyman@intel.com \
    --cc=mlangsdo@redhat.com \
    --cc=patches@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®