mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Justin Tee <justintee8345@gmail.com>
To: Abdun Nihaal <nihaal@cse.iitm.ac.in>
Cc: justin.tee@broadcom.com, paul.ely@broadcom.com,
	James.Bottomley@HansenPartnership.com,
	martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, jsmart2021@gmail.com,
	stable@vger.kernel.org
Subject: Re: [PATCH] scsi: lpfc: fix potential memory leak in lpfc_read_object()
Date: Tue, 19 May 2026 12:52:36 -0700	[thread overview]
Message-ID: <67ad1039-b6e7-4507-a9be-12600a5fe385@gmail.com> (raw)
In-Reply-To: <20260519074230.110624-1-nihaal@cse.iitm.ac.in>

Hi Abdun,

 > The memory allocated for sge_array inside lpfc_sli4_config() which is
 > attached to mbox, is not freed in one of the error path in
 > lpfc_read_object(). Fix that by calling lpfc_sli4_mbox_cmd_free()
 > instead of directly freeing the mbox.

I don’t believe this is true because in lpfc_read_object(), 
lpfc_sli4_config() is called with LPFC_SLI4_MBX_EMBED.  So, sge_array is 
not kzalloc’ed.  The code as it is today seems already correct without 
this patch.

Regards,
Justin

  reply	other threads:[~2026-05-19 19:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19  7:42 Abdun Nihaal
2026-05-19 19:52 ` Justin Tee [this message]
2026-05-20  6:09   ` Abdun Nihaal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67ad1039-b6e7-4507-a9be-12600a5fe385@gmail.com \
    --to=justintee8345@gmail.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=jsmart2021@gmail.com \
    --cc=justin.tee@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nihaal@cse.iitm.ac.in \
    --cc=paul.ely@broadcom.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®