* [PATCH] hwrng: pr_err() strings should end with newlines
@ 2017-09-25 7:45 Arvind Yadav
2017-10-12 15:09 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-09-25 7:45 UTC (permalink / raw)
To: mpm, herbert, mingo; +Cc: linux-crypto, linux-kernel
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/char/hw_random/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index 9701ac7..ff79844 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -423,7 +423,7 @@ static void start_khwrngd(void)
{
hwrng_fill = kthread_run(hwrng_fillfn, NULL, "hwrng");
if (IS_ERR(hwrng_fill)) {
- pr_err("hwrng_fill thread creation failed");
+ pr_err("hwrng_fill thread creation failed\n");
hwrng_fill = NULL;
}
}
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] hwrng: pr_err() strings should end with newlines
2017-09-25 7:45 [PATCH] hwrng: pr_err() strings should end with newlines Arvind Yadav
@ 2017-10-12 15:09 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2017-10-12 15:09 UTC (permalink / raw)
To: Arvind Yadav; +Cc: mpm, mingo, linux-crypto, linux-kernel
On Mon, Sep 25, 2017 at 01:15:00PM +0530, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-12 15:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-25 7:45 [PATCH] hwrng: pr_err() strings should end with newlines Arvind Yadav
2017-10-12 15:09 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®